All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/brltty: use host pkg-config when building host tools
Date: Wed, 26 Feb 2020 22:17:22 +0100	[thread overview]
Message-ID: <20200226221722.3cf50471@windsurf> (raw)
In-Reply-To: <20200219233748.680423-1-thomas.petazzoni@bootlin.com>

On Thu, 20 Feb 2020 00:37:47 +0100
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> brltty builds host tools which rely on the expat library, and
> pkg-config is used to detect the expat library.
> 
> Since commit cd16e18584066d2817d3acb3822e173f9f23455e ("pkgconf:
> always keep system libs"), the wrapper script added
> --keep-system-libs, which adds a -L$(STAGING_DIR)/usr/lib to the
> pkg-config results instead of just -lexpat. So, previously, by chance,
> the pkg-config result for the target expat was "good enough" for the
> host expat as well. But now that -L$(STAGING_DIR)/usr/lib is added, it
> breaks the build in all sort of ways as obviously building host
> binaries with the library search path pointing to $(STAGING_DIR) is
> not a good idea.
> 
> To fix that, this commit adjusts the brltty build system so that the
> PKG_CONFIG_FOR_BUILD variable is used when using pkg-config to build
> host binaries.
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/5a64dfb845389882c366b6c91aaf5868c090a802/
> 
> Many thanks to the initial work from Fabrice Fontaine at
> http://patchwork.ozlabs.org/patch/1238163/ which provided an initial
> starting point for this investigation.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  ...ss-PKG_CONFIG_FOR_BUILD-to-the-nativ.patch | 38 +++++++++++++++++++
>  package/brltty/brltty.mk                      |  3 ++
>  2 files changed, 41 insertions(+)
>  create mode 100644 package/brltty/0003-mk4build-also-pass-PKG_CONFIG_FOR_BUILD-to-the-nativ.patch

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-02-26 21:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-19 23:37 [Buildroot] [PATCH] package/brltty: use host pkg-config when building host tools Thomas Petazzoni
2020-02-26 21:17 ` Thomas Petazzoni [this message]
2020-03-14 16:43 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200226221722.3cf50471@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.