From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1j7GIX-0002rC-Sg for mharc-qemu-trivial@gnu.org; Thu, 27 Feb 2020 05:21:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42851) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7GIT-0002hK-4h for qemu-trivial@nongnu.org; Thu, 27 Feb 2020 05:21:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7GIE-000535-FN for qemu-trivial@nongnu.org; Thu, 27 Feb 2020 05:21:27 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:32438 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7GID-0004z0-Cn for qemu-trivial@nongnu.org; Thu, 27 Feb 2020 05:21:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582798880; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lp6tGUqiJ9qdZTMOfNDuY83W68+AvVAFdpvmOdYTKKQ=; b=PJBM3dXBzxjBUcRCPB70nCrctQLM22F6YOddEHSTPVZkWwb3pb46XDvKI/8EYQVh/kTYah VwDfScqBO83V3FWy7PqhWNGMEhkC/LRACMdmYh5vJC13fGQrahKbM2fFFPMhDniYPU6H1j zNC/ZkITMjb368TkL7SIne/dRM8BSCE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-439-BDBl2p4aPOeLxg-rb6ma3Q-1; Thu, 27 Feb 2020 05:21:11 -0500 X-MC-Unique: BDBl2p4aPOeLxg-rb6ma3Q-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2D6FC800D50; Thu, 27 Feb 2020 10:21:10 +0000 (UTC) Received: from redhat.com (ovpn-112-43.ams2.redhat.com [10.36.112.43]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A1E768B779; Thu, 27 Feb 2020 10:21:05 +0000 (UTC) Date: Thu, 27 Feb 2020 10:21:02 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Stefan Weil , Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Subject: Re: [PATCH 2/2] util/oslib-win32: Improve error report by calling error_setg_win32() Message-ID: <20200227102102.GC1645630@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20200227100250.20514-1-philmd@redhat.com> <20200227100250.20514-3-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200227100250.20514-3-philmd@redhat.com> User-Agent: Mutt/1.13.3 (2020-01-12) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Feb 2020 10:21:39 -0000 On Thu, Feb 27, 2020 at 11:02:50AM +0100, Philippe Mathieu-Daud=C3=A9 wrote= : > Use error_setg_win32() which adds a hint similar to strerror(errno)). >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > util/oslib-win32.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrang=C3=A9 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberrange= :| |: https://libvirt.org -o- https://fstop138.berrange.com= :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange= :| From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 493BCC4BA3D for ; Thu, 27 Feb 2020 10:23:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 171E724672 for ; Thu, 27 Feb 2020 10:23:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iFiktw7s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 171E724672 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7GKT-0004LA-7K for qemu-devel@archiver.kernel.org; Thu, 27 Feb 2020 05:23:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42829) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7GIE-0002fq-Or for qemu-devel@nongnu.org; Thu, 27 Feb 2020 05:21:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7GIB-0004xX-QR for qemu-devel@nongnu.org; Thu, 27 Feb 2020 05:21:22 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:48524 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7GIA-0004sW-Jf for qemu-devel@nongnu.org; Thu, 27 Feb 2020 05:21:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582798877; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lp6tGUqiJ9qdZTMOfNDuY83W68+AvVAFdpvmOdYTKKQ=; b=iFiktw7s4n+AHpWEECJeXpBAyPagXiAfSAcYYnP/+nixA1kK164NigyZSD7zcGHEP0CPTB gF2KKfh8vpmBcFUkOE3Iqv0GCQMoR2oiJ1WAwQodCQtfJFtHRPDZrIytvCOms1kInvWu3D 6C4K5uoh09YBXVnP5V6SXh5QjhqAKEg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-439-BDBl2p4aPOeLxg-rb6ma3Q-1; Thu, 27 Feb 2020 05:21:11 -0500 X-MC-Unique: BDBl2p4aPOeLxg-rb6ma3Q-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2D6FC800D50; Thu, 27 Feb 2020 10:21:10 +0000 (UTC) Received: from redhat.com (ovpn-112-43.ams2.redhat.com [10.36.112.43]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A1E768B779; Thu, 27 Feb 2020 10:21:05 +0000 (UTC) Date: Thu, 27 Feb 2020 10:21:02 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH 2/2] util/oslib-win32: Improve error report by calling error_setg_win32() Message-ID: <20200227102102.GC1645630@redhat.com> References: <20200227100250.20514-1-philmd@redhat.com> <20200227100250.20514-3-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200227100250.20514-3-philmd@redhat.com> User-Agent: Mutt/1.13.3 (2020-01-12) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: qemu-trivial@nongnu.org, Stefan Weil , qemu-devel@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Feb 27, 2020 at 11:02:50AM +0100, Philippe Mathieu-Daud=C3=A9 wrote= : > Use error_setg_win32() which adds a hint similar to strerror(errno)). >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > util/oslib-win32.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrang=C3=A9 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberrange= :| |: https://libvirt.org -o- https://fstop138.berrange.com= :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange= :|