From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Michael Petlan <mpetlan@redhat.com>,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
Andi Kleen <ak@linux.intel.com>, Kajol Jain <kjain@linux.ibm.com>,
John Garry <john.garry@huawei.com>
Subject: Re: [PATCHv2 0/5] perf expr: Add flex scanner
Date: Thu, 27 Feb 2020 10:46:25 -0300 [thread overview]
Message-ID: <20200227134625.GC10761@kernel.org> (raw)
In-Reply-To: <20200227121000.GE34774@krava>
Em Thu, Feb 27, 2020 at 01:10:00PM +0100, Jiri Olsa escreveu:
> On Mon, Feb 24, 2020 at 09:29:13AM +0100, Jiri Olsa wrote:
> > hi,
> > while preparing changes for user defined metric expressions
> > I also moved the expression manual parser to flex.
> >
> > The reason is to have an easy and reasonable way to support
> > and parse multiple user-defined metric expressions from
> > command line or file.
> >
> > I was posponing the change, but I just saw another update to
> > the expr manual scanner (from Kajol Jain), so cherry picked
> > just the expr flex code changes to get it out.
> >
> > Kajol Jain,
> > I think it should ease up your change for unknown values marked
> > by '?'. Would you consider rebasing your changes on top of this?
> >
> >
>
> kajoljain found and issue in this one, I'll send v3 as
> soon as he confirms the fix
Ok, I'll hold off processing those patches then, thanks!
- Arnaldo
> jirka
>
>
> > v2 changes:
> > - handle special chars properly
> > - fix return value for expr__parse
> >
> > Available also in:
> > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
> > perf/metric_flex
> >
> > thanks,
> > jirka
> >
> >
> > ---
> > Jiri Olsa (5):
> > perf expr: Add expr.c object
> > perf expr: Move expr lexer to flex
> > perf expr: Increase EXPR_MAX_OTHER
> > perf expr: Straighten expr__parse/expr__find_other interface
> > perf expr: Make expr__parse return -1 on error
> >
> > tools/perf/tests/expr.c | 10 +++---
> > tools/perf/util/Build | 11 ++++++-
> > tools/perf/util/expr.c | 112 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > tools/perf/util/expr.h | 8 ++---
> > tools/perf/util/expr.l | 87 +++++++++++++++++++++++++++++++++++++++++++++++++++
> > tools/perf/util/expr.y | 208 ++++++++++++++++++++++++++++++++-----------------------------------------------------------------------------------------
> > tools/perf/util/stat-shadow.c | 4 +--
> > 7 files changed, 272 insertions(+), 168 deletions(-)
> > create mode 100644 tools/perf/util/expr.c
> > create mode 100644 tools/perf/util/expr.l
> >
>
--
- Arnaldo
prev parent reply other threads:[~2020-02-27 14:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 8:29 [PATCHv2 0/5] perf expr: Add flex scanner Jiri Olsa
2020-02-24 8:29 ` [PATCH 1/5] perf expr: Add expr.c object Jiri Olsa
2020-02-24 8:29 ` [PATCH 2/5] perf expr: Move expr lexer to flex Jiri Olsa
2020-02-24 8:29 ` [PATCH 3/5] perf expr: Increase EXPR_MAX_OTHER Jiri Olsa
2020-02-24 21:03 ` Andi Kleen
2020-02-24 8:29 ` [PATCH 4/5] perf expr: Straighten expr__parse/expr__find_other interface Jiri Olsa
2020-02-24 8:29 ` [PATCH 5/5] perf expr: Make expr__parse return -1 on error Jiri Olsa
2020-02-27 12:10 ` [PATCHv2 0/5] perf expr: Add flex scanner Jiri Olsa
2020-02-27 13:46 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227134625.GC10761@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=ravi.bangoria@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.