From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9590FC11D3D for ; Thu, 27 Feb 2020 15:17:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 662D524688 for ; Thu, 27 Feb 2020 15:17:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A/crpsd4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="PFbYRJJM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 662D524688 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1oIKP+6LnRwZWln2l2hqL9ItnB+jIqhJlKxyXq6DaPs=; b=A/crpsd4FLbHr1 l9nBP+uOtWOUtwAHD5/7nGb+TS7RuVYV6f0kT93AlzV/JowQJ/qCoKOp2Qq+xL4QWAngxP9Anm1aB Z56BTDNwQM9c0doZtJfieQrFH6hmzK+Foq2k1y5qjaft6OtEWK52AzIgtoKd64Wfiiy50TZuS1OZO 9Jxh8at7d0lZgklLFTOIRE4kJDTSF/1x9qdzLx1qmm8x1RzaGRFL26Fm27gyEL5cPpVxiR/DHOuUc d6UOj14mgQycGSZii8dyjVD8zsFrATntbr3eud8ESFCywAiX0yU122TenhT8m51hKw6Xd/pmOl/+m Oh1lK8yEJzS1iLxIDjZw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7KvG-0003gY-RL; Thu, 27 Feb 2020 15:17:58 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7KvD-0003fo-KM for linux-arm-kernel@lists.infradead.org; Thu, 27 Feb 2020 15:17:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/amHjcp1m9GoN8wK56yOYd/PS1D0Vy3heZyNFBxc3ds=; b=PFbYRJJMzHEFkfxOTRfSgTi3G gE5m1bTrwGEHezS9/LTsHpkZz4dteZuwm74wT0ghQVY1F1f6MMHbJRBr5vQyn9xCE1qv+YGPllo0S xZ6Th/U0hZEY0pu6gQHj3eRjq9P6kQBTe87swuLU0Ci1NdlGzZaZAN3FLMcorpLZ1mtEj2Ct4PwVB UQsOuU6LiErdmCFJQxZe4kf0Pnr0Ij8dUhrtqN3DmEAGdjQK4MpyJQwdy+1Lmcj7KQE+UlrnVCmmy fGDQKyu5aSfn3isWf3vw0wILNTtRfKhY+RXo6w3f/AZZqfgqmjgsNtShUqh03T+WWEpo4RV8rhKet NfxR8xXdA==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:53522) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j7Kuz-0006Jo-8N; Thu, 27 Feb 2020 15:17:41 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1j7Kux-00014m-3H; Thu, 27 Feb 2020 15:17:39 +0000 Date: Thu, 27 Feb 2020 15:17:39 +0000 From: Russell King - ARM Linux admin To: Fabio Estevam Subject: Re: [PATCH] ARM: dts: imx6qdl-sr-som-ti: indicate powering off wifi is safe Message-ID: <20200227151738.GM25745@shell.armlinux.org.uk> References: <20200227134538.GK25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200227134538.GK25745@shell.armlinux.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200227_071755_665742_5902E79A X-CRM114-Status: GOOD ( 18.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Sascha Hauer , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 27, 2020 at 01:45:39PM +0000, Russell King - ARM Linux admin wrote: > On Thu, Feb 27, 2020 at 09:57:40AM -0300, Fabio Estevam wrote: > > Hi Russell, > > > > On Thu, Feb 27, 2020 at 9:19 AM Russell King wrote: > > > > > > We need to indicate that powering off the TI WiFi is safe, to avoid: > > > > > > wl18xx_driver wl18xx.2.auto: Unbalanced pm_runtime_enable! > > > wl1271_sdio mmc0:0001:2: wl12xx_sdio_power_on: failed to get_sync(-13) > > > > > > which prevents the WiFi being functional. > > > > > > Signed-off-by: Russell King > > > > Shouldn't this have a Fixes tag so that it can be backported to stable kernels? > > If I knew where the breakage happened and what commit was responsible > for it, then yes - but it used to work with earlier kernels (I don't > know which) and at some point it broke. > > The suggestion for how to fix it came from Jon Nettleton. Jon says: "It was changes to the mmc power handling. Basically telling the controller that the card should be able to wake it up from a sleep state. "I think it has to do with the runtime PM addition. This was added to the TI driver in commit, 9b71578de08748defb3bcae3ce8ed1a75cb6a8d7 I don't know if that is what broke it, but that was the initial integration. "That was added after changes to the MMC layer were done I believe." Jon thinks the idea for fixing it came from a post on one of the mailing lists, but is unable to find it now. So, I think the cause is now lost in the mists of time. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FEAAC11D3D for ; Thu, 27 Feb 2020 15:17:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 05A5024688 for ; Thu, 27 Feb 2020 15:17:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="PFbYRJJM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729751AbgB0PRq (ORCPT ); Thu, 27 Feb 2020 10:17:46 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:39334 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729279AbgB0PRq (ORCPT ); Thu, 27 Feb 2020 10:17:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/amHjcp1m9GoN8wK56yOYd/PS1D0Vy3heZyNFBxc3ds=; b=PFbYRJJMzHEFkfxOTRfSgTi3G gE5m1bTrwGEHezS9/LTsHpkZz4dteZuwm74wT0ghQVY1F1f6MMHbJRBr5vQyn9xCE1qv+YGPllo0S xZ6Th/U0hZEY0pu6gQHj3eRjq9P6kQBTe87swuLU0Ci1NdlGzZaZAN3FLMcorpLZ1mtEj2Ct4PwVB UQsOuU6LiErdmCFJQxZe4kf0Pnr0Ij8dUhrtqN3DmEAGdjQK4MpyJQwdy+1Lmcj7KQE+UlrnVCmmy fGDQKyu5aSfn3isWf3vw0wILNTtRfKhY+RXo6w3f/AZZqfgqmjgsNtShUqh03T+WWEpo4RV8rhKet NfxR8xXdA==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:53522) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j7Kuz-0006Jo-8N; Thu, 27 Feb 2020 15:17:41 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1j7Kux-00014m-3H; Thu, 27 Feb 2020 15:17:39 +0000 Date: Thu, 27 Feb 2020 15:17:39 +0000 From: Russell King - ARM Linux admin To: Fabio Estevam Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Sascha Hauer , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Subject: Re: [PATCH] ARM: dts: imx6qdl-sr-som-ti: indicate powering off wifi is safe Message-ID: <20200227151738.GM25745@shell.armlinux.org.uk> References: <20200227134538.GK25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200227134538.GK25745@shell.armlinux.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Feb 27, 2020 at 01:45:39PM +0000, Russell King - ARM Linux admin wrote: > On Thu, Feb 27, 2020 at 09:57:40AM -0300, Fabio Estevam wrote: > > Hi Russell, > > > > On Thu, Feb 27, 2020 at 9:19 AM Russell King wrote: > > > > > > We need to indicate that powering off the TI WiFi is safe, to avoid: > > > > > > wl18xx_driver wl18xx.2.auto: Unbalanced pm_runtime_enable! > > > wl1271_sdio mmc0:0001:2: wl12xx_sdio_power_on: failed to get_sync(-13) > > > > > > which prevents the WiFi being functional. > > > > > > Signed-off-by: Russell King > > > > Shouldn't this have a Fixes tag so that it can be backported to stable kernels? > > If I knew where the breakage happened and what commit was responsible > for it, then yes - but it used to work with earlier kernels (I don't > know which) and at some point it broke. > > The suggestion for how to fix it came from Jon Nettleton. Jon says: "It was changes to the mmc power handling. Basically telling the controller that the card should be able to wake it up from a sleep state. "I think it has to do with the runtime PM addition. This was added to the TI driver in commit, 9b71578de08748defb3bcae3ce8ed1a75cb6a8d7 I don't know if that is what broke it, but that was the initial integration. "That was added after changes to the MMC layer were done I believe." Jon thinks the idea for fixing it came from a post on one of the mailing lists, but is unable to find it now. So, I think the cause is now lost in the mists of time. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up