From: Jason Gunthorpe <jgg@ziepe.ca>
To: Bernard Metzler <BMT@zurich.ibm.com>
Cc: syzbot <syzbot+55de90ab5f44172b0c90@syzkaller.appspotmail.com>,
chuck.lever@oracle.com, dledford@redhat.com, leon@kernel.org,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, parav@mellanox.com,
syzkaller-bugs@googlegroups.com, willy@infradead.org
Subject: Re: possible deadlock in cma_netdev_callback
Date: Thu, 27 Feb 2020 11:53:35 -0400 [thread overview]
Message-ID: <20200227155335.GI31668@ziepe.ca> (raw)
In-Reply-To: <OF0B62EDE7.E13D40E8-ON0025851B.0037F560-0025851B.0037F56C@notes.na.collabserv.com>
On Thu, Feb 27, 2020 at 10:11:13AM +0000, Bernard Metzler wrote:
> Thanks for letting me know! Hmm, we cannot use RCU locks since
> we potentially sleep. One solution would be to create a list
> of matching interfaces while under lock, unlock and use that
> list for calling siw_listen_address() (which may sleep),
> right...?
Why do you need to iterate over addresses anyhow? Shouldn't the listen
just be done with the address the user gave and a BIND DEVICE to the
device siw is connected to?
Also that loop in siw_create looks wrong to me
Jason
next prev parent reply other threads:[~2020-02-27 15:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 5:39 possible deadlock in cma_netdev_callback syzbot
2020-02-26 20:42 ` Jason Gunthorpe
2020-02-27 10:11 ` Bernard Metzler
2020-02-27 15:53 ` Jason Gunthorpe [this message]
2020-02-27 16:21 ` Bernard Metzler
2020-02-27 16:46 ` Jason Gunthorpe
2020-02-28 13:05 ` Bernard Metzler
2020-02-28 13:35 ` Jason Gunthorpe
2020-02-28 16:42 ` Bernard Metzler
2020-02-28 16:49 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227155335.GI31668@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=BMT@zurich.ibm.com \
--cc=chuck.lever@oracle.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=parav@mellanox.com \
--cc=syzbot+55de90ab5f44172b0c90@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.