From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73326C35677 for ; Thu, 27 Feb 2020 17:30:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46185246A0 for ; Thu, 27 Feb 2020 17:30:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V3mC+K5j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46185246A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CnDdRGrp5Q3Qs6tVEpnmL6Pp2ZjF1rOkymvY+3VbA44=; b=V3mC+K5jFxbAfL AUjqmkemWaXBNJb9VmVylefokhNarQ8R5lXHfC+ytj4srN+lxVoCcVtcKx4diq9ajEUj//CYVn8JJ 1RJleBRru+XZ+8nBH/WgXczX4VLn2uX87ysiPIeRm3ma7ZMWPZN9G054DMff1N9UYIU2XNRkq1dGt 9+/C4wUTztvM+4QzJkPFL7ovBXqlUON3QPadZyu3mh8tHNhArLYY7+GE603Pmrpjccm0Xv/igZp8b aZlKOGKc6MzLNB6N10IllML6y3AqUhKe3XV0aBJGprs5sM6ewWiL36y2f+GEeWhvQGrG/GSzKSMuR gqIlsCoOQ5JFN0X4ZaIA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7Mzi-0003YR-SH; Thu, 27 Feb 2020 17:30:42 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7Mzf-0003WQ-8y for linux-mtd@lists.infradead.org; Thu, 27 Feb 2020 17:30:41 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 09A3E296482; Thu, 27 Feb 2020 17:30:36 +0000 (GMT) Date: Thu, 27 Feb 2020 18:30:32 +0100 From: Boris Brezillon To: "Ramuthevar, Vadivel MuruganX" Subject: Re: [PATCH v11 2/2] spi: cadence-quadspi: Add support for the Cadence QSPI controller Message-ID: <20200227183032.77ef0795@collabora.com> In-Reply-To: <20200227062708.21544-3-vadivel.muruganx.ramuthevar@linux.intel.com> References: <20200227062708.21544-1-vadivel.muruganx.ramuthevar@linux.intel.com> <20200227062708.21544-3-vadivel.muruganx.ramuthevar@linux.intel.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200227_093040_048489_4C7C8687 X-CRM114-Status: GOOD ( 14.57 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, tudor.ambarus@gmail.com, vigneshr@ti.com, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, cyrille.pitchen@atmel.com, marex@denx.de, boris.brezillon@free-electrons.com, tien.fong.chee@intel.com, richard@nod.at, simon.k.r.goldschmidt@gmail.com, devicetree@vger.kernel.org, cheol.yong.kim@intel.com, robh+dt@kernel.org, qi-ming.wu@intel.com, david.oberhollenzer@sigma-star.at, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, dinguyen@kernel.org, broonie@kernel.org, computersforpeace@gmail.com, dwmw2@infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, 27 Feb 2020 14:27:08 +0800 "Ramuthevar, Vadivel MuruganX" wrote: > From: Ramuthevar Vadivel Murugan > > Add support for the Cadence QSPI controller. This controller is > present in the Intel Lightning Mountain(LGM) SoCs, Altera and TI SoCs. > This driver has been tested on the Intel LGM SoCs. > > This driver does not support generic SPI and also the implementation > only supports spi-mem interface to replace the existing driver in > mtd/spi-nor/cadence-quadspi.c, the existing driver only support SPI-NOR > flash memory. Is it really supporting SPI NORs only, or is it just that you only tested it with a spi-nor? > > Signed-off-by: Ramuthevar Vadivel Murugan > Signed-off-by: Vignesh Raghavendra > Reported-by: kbuild test robot > Reported-by: Dan Carpenter Reported-by? What has been reported? > --- > drivers/mtd/spi-nor/Kconfig | 11 - > drivers/mtd/spi-nor/Makefile | 1 - > drivers/spi/Kconfig | 10 + > drivers/spi/Makefile | 1 + > .../spi-cadence-quadspi.c} | 641 ++++++++++----------- Looks like this could be split in several patches to ease the review: 1/ convert to spi-mem 2/ move the driver to drivers/spi 3/ add support for intel,lgm-qspi other than that, that's good to see one more spi-nor controller driver converted to spi-mem. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v11 2/2] spi: cadence-quadspi: Add support for the Cadence QSPI controller Date: Thu, 27 Feb 2020 18:30:32 +0100 Message-ID: <20200227183032.77ef0795@collabora.com> References: <20200227062708.21544-1-vadivel.muruganx.ramuthevar@linux.intel.com> <20200227062708.21544-3-vadivel.muruganx.ramuthevar@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, vigneshr-l0cyMroinI0@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, marex-ynQEQJNshbs@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tien.fong.chee-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, tudor.ambarus-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, richard-/L3Ra7n9ekc@public.gmane.org, qi-ming.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, simon.k.r.goldschmidt-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, david.oberhollenzer-S6VGOU4v5edDinCvNWH78Q@public.gmane.org, dinguyen-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, miquel.raynal-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org, cheol.yong.kim-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org To: "Ramuthevar, Vadivel MuruganX" Return-path: In-Reply-To: <20200227062708.21544-3-vadivel.muruganx.ramuthevar-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Thu, 27 Feb 2020 14:27:08 +0800 "Ramuthevar, Vadivel MuruganX" wrote: > From: Ramuthevar Vadivel Murugan > > Add support for the Cadence QSPI controller. This controller is > present in the Intel Lightning Mountain(LGM) SoCs, Altera and TI SoCs. > This driver has been tested on the Intel LGM SoCs. > > This driver does not support generic SPI and also the implementation > only supports spi-mem interface to replace the existing driver in > mtd/spi-nor/cadence-quadspi.c, the existing driver only support SPI-NOR > flash memory. Is it really supporting SPI NORs only, or is it just that you only tested it with a spi-nor? > > Signed-off-by: Ramuthevar Vadivel Murugan > Signed-off-by: Vignesh Raghavendra > Reported-by: kbuild test robot > Reported-by: Dan Carpenter Reported-by? What has been reported? > --- > drivers/mtd/spi-nor/Kconfig | 11 - > drivers/mtd/spi-nor/Makefile | 1 - > drivers/spi/Kconfig | 10 + > drivers/spi/Makefile | 1 + > .../spi-cadence-quadspi.c} | 641 ++++++++++----------- Looks like this could be split in several patches to ease the review: 1/ convert to spi-mem 2/ move the driver to drivers/spi 3/ add support for intel,lgm-qspi other than that, that's good to see one more spi-nor controller driver converted to spi-mem. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83D57C11D3D for ; Thu, 27 Feb 2020 17:30:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 641C7246A3 for ; Thu, 27 Feb 2020 17:30:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729678AbgB0Rai (ORCPT ); Thu, 27 Feb 2020 12:30:38 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:40292 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729635AbgB0Rai (ORCPT ); Thu, 27 Feb 2020 12:30:38 -0500 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 09A3E296482; Thu, 27 Feb 2020 17:30:36 +0000 (GMT) Date: Thu, 27 Feb 2020 18:30:32 +0100 From: Boris Brezillon To: "Ramuthevar, Vadivel MuruganX" Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, broonie@kernel.org, vigneshr@ti.com, robh+dt@kernel.org, marex@denx.de, devicetree@vger.kernel.org, tien.fong.chee@intel.com, tudor.ambarus@gmail.com, boris.brezillon@free-electrons.com, richard@nod.at, qi-ming.wu@intel.com, simon.k.r.goldschmidt@gmail.com, david.oberhollenzer@sigma-star.at, dinguyen@kernel.org, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, cheol.yong.kim@intel.com, mark.rutland@arm.com, computersforpeace@gmail.com, dwmw2@infradead.org, cyrille.pitchen@atmel.com Subject: Re: [PATCH v11 2/2] spi: cadence-quadspi: Add support for the Cadence QSPI controller Message-ID: <20200227183032.77ef0795@collabora.com> In-Reply-To: <20200227062708.21544-3-vadivel.muruganx.ramuthevar@linux.intel.com> References: <20200227062708.21544-1-vadivel.muruganx.ramuthevar@linux.intel.com> <20200227062708.21544-3-vadivel.muruganx.ramuthevar@linux.intel.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 27 Feb 2020 14:27:08 +0800 "Ramuthevar, Vadivel MuruganX" wrote: > From: Ramuthevar Vadivel Murugan > > Add support for the Cadence QSPI controller. This controller is > present in the Intel Lightning Mountain(LGM) SoCs, Altera and TI SoCs. > This driver has been tested on the Intel LGM SoCs. > > This driver does not support generic SPI and also the implementation > only supports spi-mem interface to replace the existing driver in > mtd/spi-nor/cadence-quadspi.c, the existing driver only support SPI-NOR > flash memory. Is it really supporting SPI NORs only, or is it just that you only tested it with a spi-nor? > > Signed-off-by: Ramuthevar Vadivel Murugan > Signed-off-by: Vignesh Raghavendra > Reported-by: kbuild test robot > Reported-by: Dan Carpenter Reported-by? What has been reported? > --- > drivers/mtd/spi-nor/Kconfig | 11 - > drivers/mtd/spi-nor/Makefile | 1 - > drivers/spi/Kconfig | 10 + > drivers/spi/Makefile | 1 + > .../spi-cadence-quadspi.c} | 641 ++++++++++----------- Looks like this could be split in several patches to ease the review: 1/ convert to spi-mem 2/ move the driver to drivers/spi 3/ add support for intel,lgm-qspi other than that, that's good to see one more spi-nor controller driver converted to spi-mem.