All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/eudev: support openrc init
Date: Thu, 27 Feb 2020 21:35:56 +0100	[thread overview]
Message-ID: <20200227203556.GD8743@scaer> (raw)
In-Reply-To: <20200227145123.5654-3-unixmania@gmail.com>

Carlos, All,

On 2020-02-27 11:51 -0300, unixmania at gmail.com spake thusly:
> From: Carlos Santos <unixmania@gmail.com>
> 
> Select udev-gentoo-scripts and avoid installing the sysv init script.
> 
> Signed-off-by: Carlos Santos <unixmania@gmail.com>
> ---
>  package/eudev/Config.in | 1 +
>  package/eudev/eudev.mk  | 4 ++++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/package/eudev/Config.in b/package/eudev/Config.in
> index b1d2f37a72..b0ce76171a 100644
> --- a/package/eudev/Config.in
> +++ b/package/eudev/Config.in
> @@ -5,6 +5,7 @@ config BR2_PACKAGE_EUDEV
>  	depends on BR2_USE_WCHAR # needs C99 compiler
>  	depends on !BR2_STATIC_LIBS # kmod
>  	select BR2_PACKAGE_HAS_UDEV
> +	select BR2_PACKAGE_UDEV_GENTOO_SCRIPTS if BR2_INIT_OPENRC
>  	select BR2_PACKAGE_UTIL_LINUX
>  	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
>  	select BR2_PACKAGE_KMOD
> diff --git a/package/eudev/eudev.mk b/package/eudev/eudev.mk
> index 99b5befd09..abcabb343c 100644
> --- a/package/eudev/eudev.mk
> +++ b/package/eudev/eudev.mk
> @@ -44,9 +44,13 @@ else
>  EUDEV_CONF_OPTS += --disable-selinux
>  endif
>  
> +# Avoid installing S10udev with openrc, as the service is started by a unit
> +# from the udev-gentoo-scripts package.
> +ifeq ($(BR2_INIT_OPENRC),)
>  define EUDEV_INSTALL_INIT_SYSV
>  	$(INSTALL) -D -m 0755 package/eudev/S10udev $(TARGET_DIR)/etc/init.d/S10udev
>  endef
> +endif

There is indeed no sane solution but a hack in this situation. However,
I prefer the previous version that defined a fake hook, so I reused that
instead (with a little tweak of yours from another comment! ;-) ).

Applied to next with that fixed. Thanks!

Regards,
Yann E. MORIN.

>  # Required by default rules for input devices
>  define EUDEV_USERS
> -- 
> 2.18.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2020-02-27 20:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27 14:51 [Buildroot] [PATCH 0/2] package/eudev: support openrc init unixmania at gmail.com
2020-02-27 14:51 ` [Buildroot] [PATCH 1/2] udev-gentoo-scripts: new packages unixmania at gmail.com
2020-02-27 20:29   ` Yann E. MORIN
2020-02-27 20:36     ` Yann E. MORIN
2020-02-27 14:51 ` [Buildroot] [PATCH 2/2] package/eudev: support openrc init unixmania at gmail.com
2020-02-27 20:35   ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200227203556.GD8743@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.