From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FSL_HELO_FAKE,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54846C3F2C0 for ; Thu, 27 Feb 2020 21:52:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 12D3C246A1 for ; Thu, 27 Feb 2020 21:52:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Nu/xJQJc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12D3C246A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A64186B0006; Thu, 27 Feb 2020 16:52:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A143A6B0007; Thu, 27 Feb 2020 16:52:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DBBF6B0008; Thu, 27 Feb 2020 16:52:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0226.hostedemail.com [216.40.44.226]) by kanga.kvack.org (Postfix) with ESMTP id 778886B0006 for ; Thu, 27 Feb 2020 16:52:43 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4E9DB824C741 for ; Thu, 27 Feb 2020 21:52:43 +0000 (UTC) X-FDA: 76537257006.08.scent22_34c89d538db2e X-HE-Tag: scent22_34c89d538db2e X-Filterd-Recvd-Size: 3702 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Feb 2020 21:52:42 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id y5so519591pfb.11 for ; Thu, 27 Feb 2020 13:52:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=a8tz7pn6WYS1zSkKOSE65k1PsuDxpcFOThMRyfGsXzE=; b=Nu/xJQJcfGP5wjtq6rtG/YhcMWcwj5otv44cx4FAAyishIVQiJQUHZjthXqMGPt5mx q3ZItdbyNqwOLeJLnUgK7Ij7Xz6qHMF8gxezXja59kyh659wtD/c5NTCYvpI+N/feY7n zJynnhsSZEQvADPTbT7WzlnuziaDLdClsJDtRzZKzVGSZ6ioBrHzl0Ow/2N5dnIxDwyY 9YvVLFUhSv6Qld1wjqqIcFdYhanLQItBzbmIXkZWjk92iQPuWJbeSrBKk9Hu7M3RwsDg R5oJGClkDbCW5J5gP35HFIkaV7DyO9w8adVx4dA7AvU1PlUG49dEnAi8TDjSV0rKmRxD uqmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=a8tz7pn6WYS1zSkKOSE65k1PsuDxpcFOThMRyfGsXzE=; b=KF01+N4Y9POL5/YINyob9QzbsCIFbQHixT2WQkZy8zumzq9+L9zgUhrhwbo51jIQ5S 4rdw2SwLcDBjeOOu7WPS/PpJMBRfvpOnwpwwXjQlD0NGijFSrd9DH7mzZpGFzKIXWGx8 dgzIElBg9+Oz35W/u2g0XCrSXZfTbi9yIF/pS7/Esk+475rczPJBOXhNkkL3OJIw5eiE tIru90hkYCeYpIpqUAD4hpXweOfFKcD9p1bcEt9m7321c45Q6eMxF3Erz3PDVYLPZRtt qwZ/Q14oC4kEEWhrVfGhM60rGclBMZ3leMb4/1gNUXOlGuHstrQfm65FlSPPyFDrdUEP /efA== X-Gm-Message-State: APjAAAU5ycwRSVLTw9yE+X1qoQ9AfBEs5MQGAqfTiHpUANUlHIo1+oUs RFf/dJ2r8SLOC5nSXiYzPIA= X-Google-Smtp-Source: APXvYqwMWOfBtYQa9aLe/LcC/6wxpuCKtnPAnSxFoNQzxZ7DvSIHHrLoB+J3JktcFJ99CvsUTlYRhQ== X-Received: by 2002:a63:36cd:: with SMTP id d196mr1396472pga.280.1582840361366; Thu, 27 Feb 2020 13:52:41 -0800 (PST) Received: from google.com ([2620:15c:211:1:3e01:2939:5992:52da]) by smtp.gmail.com with ESMTPSA id w25sm8060951pfi.106.2020.02.27.13.52.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 13:52:37 -0800 (PST) Date: Thu, 27 Feb 2020 13:52:35 -0800 From: Minchan Kim To: Jules Irenge Cc: linux-kernel@vger.kernel.org, boqun.feng@gmail.com, Nitin Gupta , Sergey Senozhatsky , Andrew Morton , "open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR" Subject: Re: [PATCH 10/30] mm/zsmalloc: Add missing annotation for migrate_read_lock() Message-ID: <20200227215235.GB215068@google.com> References: <0/30> <20200214204741.94112-1-jbi.octave@gmail.com> <20200214204741.94112-11-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200214204741.94112-11-jbi.octave@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000236, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 14, 2020 at 08:47:21PM +0000, Jules Irenge wrote: > Sparse reports a warning at migrate_read_lock()() > > warning: context imbalance in migrate_read_lock() - wrong count at exit > > The root cause is the missing annotation at migrate_read_lock() > Add the missing __acquires(&zspage->lock) annotation > > Signed-off-by: Jules Irenge Acked-by: Minchan Kim