From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CAAFC3F2C2 for ; Thu, 27 Feb 2020 23:23:01 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA696246A4 for ; Thu, 27 Feb 2020 23:23:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA696246A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 3A22B10FC36CB; Thu, 27 Feb 2020 15:23:52 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.210.68; helo=mail-ot1-f68.google.com; envelope-from=robherring2@gmail.com; receiver= Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0ACCD10FC359A for ; Thu, 27 Feb 2020 15:23:49 -0800 (PST) Received: by mail-ot1-f68.google.com with SMTP id r16so918740otd.2 for ; Thu, 27 Feb 2020 15:22:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UkIj7Br6bPd7hbW7TV5UiV4FHsIuHQGX64PWFr24Elw=; b=B+0TjGtL8A4g+IPOstmuqAce3wxzFXjj5w7IFlTv7nqKP+xouujiVd8t1ZyBXhguew HtA7QasSoKGDOIfnmwt15bb6QYWqzlrOv6tPKdgAepqj+2oSWuMLXZh1mALHyjHUYJLL rvzP3HNL2qEzOgOZxZ6ulCKK2xt533advsG2OoRmvs0MKeAx8OC7n3o0xibrQBlda6cw g4VD6x7mQQLKwv/uZ3Pk6nrFgoQCQ3C5yjsb75Iw1DI+63GIZW7deujv/PhPAlL6rQe7 oz4sXPRVc7+z6h25pzz4sWx9Fac3xnvnv4Zpp0T3sHl/cAmChkAlitM55+DoN71JzdfB YhPw== X-Gm-Message-State: APjAAAXhkbiEzWXNxCiQlWPTMl9CYidDKYtgsWEDrrbtGtscusdvmSiC 3Z+M3UAAuac4FR+3CmxrGQ== X-Google-Smtp-Source: APXvYqwyoGSeOvDsr/b/4MBxlzKifGUIKH2KNXIq/Dsvt2qo0CMzRCuC3CpAFxDHEcT2vx8OeH8M/A== X-Received: by 2002:a9d:12a2:: with SMTP id g31mr1069694otg.283.1582845777179; Thu, 27 Feb 2020 15:22:57 -0800 (PST) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id n25sm2496905oic.6.2020.02.27.15.22.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 15:22:55 -0800 (PST) Received: (nullmailer pid 15847 invoked by uid 1000); Thu, 27 Feb 2020 23:22:53 -0000 Date: Thu, 27 Feb 2020 17:22:53 -0600 From: Rob Herring To: Alistair Delva Subject: Re: [PATCH v3 3/3] dt-bindings: pmem-region: Document memory-region Message-ID: <20200227232253.GA5966@bogus> References: <20200224021029.142701-1-adelva@google.com> <20200224021029.142701-3-adelva@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200224021029.142701-3-adelva@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Message-ID-Hash: TO7WI35ZRENDREI4EOM2GJHMWEOW6MC3 X-Message-ID-Hash: TO7WI35ZRENDREI4EOM2GJHMWEOW6MC3 X-MailFrom: robherring2@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: linux-kernel@vger.kernel.org, Kenny Root , devicetree@vger.kernel.org, linux-nvdimm@lists.01.org, kernel-team@android.com X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sun, Feb 23, 2020 at 06:10:29PM -0800, Alistair Delva wrote: > From: Kenny Root > > Add documentation and example for memory-region in pmem. > > Signed-off-by: Kenny Root > Signed-off-by: Alistair Delva > Cc: "Oliver O'Halloran" > Cc: Rob Herring > Cc: Dan Williams > Cc: Vishal Verma > Cc: Dave Jiang > Cc: Ira Weiny > Cc: devicetree@vger.kernel.org > Cc: linux-nvdimm@lists.01.org > Cc: kernel-team@android.com > --- > [v3: adelva: remove duplicate "From:"] > .../devicetree/bindings/pmem/pmem-region.txt | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pmem/pmem-region.txt b/Documentation/devicetree/bindings/pmem/pmem-region.txt > index 5cfa4f016a00..0ec87bd034e0 100644 > --- a/Documentation/devicetree/bindings/pmem/pmem-region.txt > +++ b/Documentation/devicetree/bindings/pmem/pmem-region.txt > @@ -29,6 +29,18 @@ Required properties: > in a separate device node. Having multiple address ranges in a > node implies no special relationship between the two ranges. > > + This property may be replaced or supplemented with a > + memory-region property. Only one of reg or memory-region > + properties is required. > + > + - memory-region: > + Reference to the reserved memory node. The reserved memory > + node should be defined as per the bindings in > + reserved-memory.txt Though we've never enforced it, but /reserved-memory should be within the bounds of /memory node(s). Is that the intent here? If so, how does that work? Wouldn't all the memory be persistent then? Or some other system processor is preserving the contents? > + > + This property may be replaced or supplemented with a reg > + property. Only one of reg or memory-region is required. > + > Optional properties: > - Any relevant NUMA assocativity properties for the target platform. > > @@ -63,3 +75,20 @@ Examples: > volatile; > }; > > + > + /* > + * This example uses a reserved-memory entry instead of > + * specifying the memory region directly in the node. > + */ > + > + reserved-memory { > + pmem_1: pmem@5000 { > + no-map; Just add 'compatible = "pmem-region";' here and be done with it. Why add a layer of indirection? > + reg = <0x00005000 0x00001000>; > + }; > + }; > + > + pmem@1 { No 'reg', so shouldn't have a unit-address here. > + compatible = "pmem-region"; > + memory-region = <&pmem_1>; > + }; > -- > 2.25.0.265.gbab2e86ba0-goog > _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B579C3F2C6 for ; Thu, 27 Feb 2020 23:22:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE47B246A4 for ; Thu, 27 Feb 2020 23:22:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582845778; bh=7+gTZW27aY4hf5vwBl9dT1mMM0XSUpttYHUYVSGA70c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=mbZQvaM4LKlFuFMMxvrJR9VZXtOk1D/vyw+bzGTF7BkG5BxfsY9XunKxlJw+5LVDQ aMeg0kqfZ/ilrwIu7RIL8FQfTBg9/D3mgz7AtE1U0GGNrnfOSXdkangb2HoPrR2NQF WY819kk9MQloyVw1xx7023o+GRgW9xWg00mIvJDg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729586AbgB0XW6 (ORCPT ); Thu, 27 Feb 2020 18:22:58 -0500 Received: from mail-ot1-f66.google.com ([209.85.210.66]:44407 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729391AbgB0XW6 (ORCPT ); Thu, 27 Feb 2020 18:22:58 -0500 Received: by mail-ot1-f66.google.com with SMTP id h9so864768otj.11; Thu, 27 Feb 2020 15:22:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UkIj7Br6bPd7hbW7TV5UiV4FHsIuHQGX64PWFr24Elw=; b=LDozMsfxXmeO1BiQO6QhIKiUwrhCYJRNJbGBaSS4YrE+tOAy8JMCAxDP4jEmLeAZer 2ak3VpM7+VUvgC5ZGwFsg5jwmqLNeCETnakCl9mU3oHd1jToKSrQkRTrnRWEGlB57CzZ l6UvGTCypPphbR90zxvYf88xBEOQepNp/SGdiitzomX7jPJYVeA/lWWnQF2DQdDuTn6X xyFrEwsxmhXka8DATyKj2LeFN/+n4huKOcWIqneUNiDRWITrdqLDd7XUO/v+X+a3o5f5 KlCETYzFLF0hfQs4nbPz8COBe4sN1QwYhPak81VWmMCKzR3Yaw9NIALhhEhxWbiVJQ6h 1ckA== X-Gm-Message-State: APjAAAUssXgeLi/3PxB6fttyvn1/EErMao5kcSIhAtAxd9lF5wagPJQe a6srsyvTs3EO9O9eXeGM+w== X-Google-Smtp-Source: APXvYqwyoGSeOvDsr/b/4MBxlzKifGUIKH2KNXIq/Dsvt2qo0CMzRCuC3CpAFxDHEcT2vx8OeH8M/A== X-Received: by 2002:a9d:12a2:: with SMTP id g31mr1069694otg.283.1582845777179; Thu, 27 Feb 2020 15:22:57 -0800 (PST) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id n25sm2496905oic.6.2020.02.27.15.22.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 15:22:55 -0800 (PST) Received: (nullmailer pid 15847 invoked by uid 1000); Thu, 27 Feb 2020 23:22:53 -0000 Date: Thu, 27 Feb 2020 17:22:53 -0600 From: Rob Herring To: Alistair Delva Cc: linux-kernel@vger.kernel.org, Kenny Root , Oliver O'Halloran , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , devicetree@vger.kernel.org, linux-nvdimm@lists.01.org, kernel-team@android.com Subject: Re: [PATCH v3 3/3] dt-bindings: pmem-region: Document memory-region Message-ID: <20200227232253.GA5966@bogus> References: <20200224021029.142701-1-adelva@google.com> <20200224021029.142701-3-adelva@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200224021029.142701-3-adelva@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Feb 23, 2020 at 06:10:29PM -0800, Alistair Delva wrote: > From: Kenny Root > > Add documentation and example for memory-region in pmem. > > Signed-off-by: Kenny Root > Signed-off-by: Alistair Delva > Cc: "Oliver O'Halloran" > Cc: Rob Herring > Cc: Dan Williams > Cc: Vishal Verma > Cc: Dave Jiang > Cc: Ira Weiny > Cc: devicetree@vger.kernel.org > Cc: linux-nvdimm@lists.01.org > Cc: kernel-team@android.com > --- > [v3: adelva: remove duplicate "From:"] > .../devicetree/bindings/pmem/pmem-region.txt | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pmem/pmem-region.txt b/Documentation/devicetree/bindings/pmem/pmem-region.txt > index 5cfa4f016a00..0ec87bd034e0 100644 > --- a/Documentation/devicetree/bindings/pmem/pmem-region.txt > +++ b/Documentation/devicetree/bindings/pmem/pmem-region.txt > @@ -29,6 +29,18 @@ Required properties: > in a separate device node. Having multiple address ranges in a > node implies no special relationship between the two ranges. > > + This property may be replaced or supplemented with a > + memory-region property. Only one of reg or memory-region > + properties is required. > + > + - memory-region: > + Reference to the reserved memory node. The reserved memory > + node should be defined as per the bindings in > + reserved-memory.txt Though we've never enforced it, but /reserved-memory should be within the bounds of /memory node(s). Is that the intent here? If so, how does that work? Wouldn't all the memory be persistent then? Or some other system processor is preserving the contents? > + > + This property may be replaced or supplemented with a reg > + property. Only one of reg or memory-region is required. > + > Optional properties: > - Any relevant NUMA assocativity properties for the target platform. > > @@ -63,3 +75,20 @@ Examples: > volatile; > }; > > + > + /* > + * This example uses a reserved-memory entry instead of > + * specifying the memory region directly in the node. > + */ > + > + reserved-memory { > + pmem_1: pmem@5000 { > + no-map; Just add 'compatible = "pmem-region";' here and be done with it. Why add a layer of indirection? > + reg = <0x00005000 0x00001000>; > + }; > + }; > + > + pmem@1 { No 'reg', so shouldn't have a unit-address here. > + compatible = "pmem-region"; > + memory-region = <&pmem_1>; > + }; > -- > 2.25.0.265.gbab2e86ba0-goog >