From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>
Subject: Re: [PATCH 1/2] kvm: vmx: Use basic exit reason to check if it's the specific VM EXIT
Date: Thu, 27 Feb 2020 15:57:39 -0800 [thread overview]
Message-ID: <20200227235739.GM17014@linux.intel.com> (raw)
In-Reply-To: <022bf970-1b86-d952-5563-0d18c9eea6e2@intel.com>
On Thu, Feb 27, 2020 at 04:35:20PM +0800, Xiaoyao Li wrote:
> On 2/27/2020 7:59 AM, Sean Christopherson wrote:
> >Ah, good point. But, that's just another bug in my psuedo patch :-)
> >It's literally one call site that needs to be updated. E.g.
> >
> > if (is_guest_mode(vcpu) && nested_vmx_exit_reflected(vcpu, exit_reason))
> > return nested_vmx_reflect_vmexit(vcpu, full_exit_reason);
> >
>
> shouldn't we also pass full_exit_reason to nested_vmx_exit_reflected()?
Yep, see the patch I sent. Alternatively, and perhaps a better approach
once we have the union, would be to not pass exit_reason at all and instead
have nested_vmx_exit_reflected() grab it directly from vmx->...
>
> >Everywhere else KVM calls nested_vmx_reflect_vmexit() is (currently) done
>
> I guess you wanted to say nested_vmx_vmexit() not
> nested_vmx_reflect_vmexit() here.
Ya.
> >with a hardcoded value (except handle_vmfunc(), but I actually want to
> >change that one).
> >
>
next prev parent reply other threads:[~2020-02-27 23:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 2:07 [PATCH 0/2] KVM: VMX: Use basic exit reason for cheking and indexing Xiaoyao Li
2020-02-24 2:07 ` [PATCH 1/2] kvm: vmx: Use basic exit reason to check if it's the specific VM EXIT Xiaoyao Li
2020-02-24 10:16 ` Vitaly Kuznetsov
2020-02-24 12:01 ` Xiaoyao Li
2020-02-24 13:04 ` Vitaly Kuznetsov
2020-02-24 16:17 ` Sean Christopherson
2020-02-25 0:13 ` Xiaoyao Li
2020-02-25 6:13 ` Sean Christopherson
2020-02-25 6:41 ` Xiaoyao Li
2020-02-26 23:59 ` Sean Christopherson
2020-02-27 8:35 ` Xiaoyao Li
2020-02-27 23:57 ` Sean Christopherson [this message]
2020-02-25 0:27 ` Krish Sadhukhan
2020-02-25 13:11 ` Vitaly Kuznetsov
2020-02-25 18:28 ` Krish Sadhukhan
2020-02-24 2:07 ` [PATCH 2/2] kvm: nvmx: Use basic(exit_reason) when checking specific EXIT_REASON Xiaoyao Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227235739.GM17014@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.