From: Tao Ren <rentao.bupt@gmail.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v5 7/7] dt-bindings: usb: add documentation for aspeed usb-vhub
Date: Thu, 27 Feb 2020 17:05:20 -0800 [thread overview]
Message-ID: <20200228010444.GA19910@taoren-ubuntu-R90MNF91> (raw)
In-Reply-To: <3150424b9e9f5856c747a0fbf44647919f49209d.camel@kernel.crashing.org>
On Fri, Feb 28, 2020 at 10:30:02AM +1100, Benjamin Herrenschmidt wrote:
> On Thu, 2020-02-27 at 15:05 -0800, rentao.bupt at gmail.com wrote:
>
> .../...
>
> You haven't fixed the problem spotted by Rob which is that the example
> is now out of sync, it's missing the required properties.
Ahhh, now I know where my problem is..
Let me see why I cannot reproduce the error on my side; otherwise I may
create more noise in my next patch set (customize device IDs/strings)..
> Also long run I think best is going to have a child node per downstream
> port, so we create a matching linux struct device. This will make it
> easier to deal with the other device-controller in the ast2600 which is
> basically one of these without a vhub above it.
Maybe a dumb question: what would be the proper place to parse the child
node/properties when they are added? For example, in some usb_gadget_ops
callback?
Cheers,
Tao
WARNING: multiple messages have this Message-ID (diff)
From: Tao Ren <rentao.bupt@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Colin Ian King <colin.king@canonical.com>,
Stephen Boyd <swboyd@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org,
taoren@fb.com
Subject: Re: [PATCH v5 7/7] dt-bindings: usb: add documentation for aspeed usb-vhub
Date: Thu, 27 Feb 2020 17:05:20 -0800 [thread overview]
Message-ID: <20200228010444.GA19910@taoren-ubuntu-R90MNF91> (raw)
In-Reply-To: <3150424b9e9f5856c747a0fbf44647919f49209d.camel@kernel.crashing.org>
On Fri, Feb 28, 2020 at 10:30:02AM +1100, Benjamin Herrenschmidt wrote:
> On Thu, 2020-02-27 at 15:05 -0800, rentao.bupt@gmail.com wrote:
>
> .../...
>
> You haven't fixed the problem spotted by Rob which is that the example
> is now out of sync, it's missing the required properties.
Ahhh, now I know where my problem is..
Let me see why I cannot reproduce the error on my side; otherwise I may
create more noise in my next patch set (customize device IDs/strings)..
> Also long run I think best is going to have a child node per downstream
> port, so we create a matching linux struct device. This will make it
> easier to deal with the other device-controller in the ast2600 which is
> basically one of these without a vhub above it.
Maybe a dumb question: what would be the proper place to parse the child
node/properties when they are added? For example, in some usb_gadget_ops
callback?
Cheers,
Tao
WARNING: multiple messages have this Message-ID (diff)
From: Tao Ren <rentao.bupt@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Felipe Balbi <balbi@kernel.org>,
linux-aspeed@lists.ozlabs.org, devicetree@vger.kernel.org,
Andrew Jeffery <andrew@aj.id.au>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
openbmc@lists.ozlabs.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
taoren@fb.com, Chunfeng Yun <chunfeng.yun@mediatek.com>,
Colin Ian King <colin.king@canonical.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 7/7] dt-bindings: usb: add documentation for aspeed usb-vhub
Date: Thu, 27 Feb 2020 17:05:20 -0800 [thread overview]
Message-ID: <20200228010444.GA19910@taoren-ubuntu-R90MNF91> (raw)
In-Reply-To: <3150424b9e9f5856c747a0fbf44647919f49209d.camel@kernel.crashing.org>
On Fri, Feb 28, 2020 at 10:30:02AM +1100, Benjamin Herrenschmidt wrote:
> On Thu, 2020-02-27 at 15:05 -0800, rentao.bupt@gmail.com wrote:
>
> .../...
>
> You haven't fixed the problem spotted by Rob which is that the example
> is now out of sync, it's missing the required properties.
Ahhh, now I know where my problem is..
Let me see why I cannot reproduce the error on my side; otherwise I may
create more noise in my next patch set (customize device IDs/strings)..
> Also long run I think best is going to have a child node per downstream
> port, so we create a matching linux struct device. This will make it
> easier to deal with the other device-controller in the ast2600 which is
> basically one of these without a vhub above it.
Maybe a dumb question: what would be the proper place to parse the child
node/properties when they are added? For example, in some usb_gadget_ops
callback?
Cheers,
Tao
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-28 1:05 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 23:05 [PATCH v5 0/7] aspeed-g6: enable usb support rentao.bupt
2020-02-27 23:05 ` rentao.bupt
2020-02-27 23:05 ` rentao.bupt
2020-02-27 23:05 ` [PATCH v5 1/7] usb: gadget: aspeed: support per-vhub usb descriptors rentao.bupt
2020-02-27 23:05 ` rentao.bupt
2020-02-27 23:05 ` rentao.bupt
2020-02-27 23:05 ` [PATCH v5 2/7] usb: gadget: aspeed: read vhub properties from device tree rentao.bupt
2020-02-27 23:05 ` rentao.bupt
2020-02-27 23:05 ` rentao.bupt
2020-02-27 23:05 ` [PATCH v5 3/7] usb: gadget: aspeed: add ast2600 vhub support rentao.bupt
2020-02-27 23:05 ` rentao.bupt
2020-02-27 23:05 ` rentao.bupt
2020-02-27 23:05 ` [PATCH v5 4/7] ARM: dts: aspeed-g6: add usb functions rentao.bupt
2020-02-27 23:05 ` rentao.bupt
2020-02-27 23:05 ` rentao.bupt
2020-02-27 23:05 ` [PATCH v5 5/7] ARM: dts: aspeed-g5: add vhub port and endpoint properties rentao.bupt
2020-02-27 23:05 ` rentao.bupt
2020-02-27 23:05 ` rentao.bupt
2020-02-27 23:05 ` [PATCH v5 6/7] ARM: dts: aspeed-g4: " rentao.bupt
2020-02-27 23:05 ` rentao.bupt
2020-02-27 23:05 ` rentao.bupt
2020-02-27 23:05 ` [PATCH v5 7/7] dt-bindings: usb: add documentation for aspeed usb-vhub rentao.bupt
2020-02-27 23:05 ` rentao.bupt
2020-02-27 23:05 ` rentao.bupt
2020-02-27 23:30 ` Benjamin Herrenschmidt
2020-02-27 23:30 ` Benjamin Herrenschmidt
2020-02-27 23:30 ` Benjamin Herrenschmidt
2020-02-28 1:05 ` Tao Ren [this message]
2020-02-28 1:05 ` Tao Ren
2020-02-28 1:05 ` Tao Ren
2020-02-28 3:02 ` Benjamin Herrenschmidt
2020-02-28 3:02 ` Benjamin Herrenschmidt
2020-02-28 3:02 ` Benjamin Herrenschmidt
2020-02-28 8:13 ` Tao Ren
2020-02-28 8:13 ` Tao Ren
2020-02-28 8:13 ` Tao Ren
2020-03-02 4:49 ` Benjamin Herrenschmidt
2020-03-02 4:49 ` Benjamin Herrenschmidt
2020-03-02 4:49 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228010444.GA19910@taoren-ubuntu-R90MNF91 \
--to=rentao.bupt@gmail.com \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.