From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85D2FC3F2D0 for ; Fri, 28 Feb 2020 07:47:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D4ED246A2 for ; Fri, 28 Feb 2020 07:47:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TDJ7QoIL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D4ED246A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JVlNIsbyTe0sfty20LUM5Kgi1E0m/j+NDqk7x2JQa7w=; b=TDJ7QoILkO412s +UIVqLrWowJj+GGffjEYilySmfOisAu8Ah8nXR/PP2F4N57W9hHto/9oo8jIdhHDCgchgVhzU+dgT HOhv2wPquXnFmr3iyTQzDmg8foanOnvH10sgVixz5WqV1erOE1OMkvdfJA9MilRuWXvaP3VPkmMIp 8+WKn3PoZlLSyyNftV+DBII5cObCLT/sgzPVB7VX2vrgYcspyQazUk+9ia0zMwL+2F+s4EcakbkMT 9DK99Fp5NriHYcZSSxryKTkDLbLDFqMCnpxpIEHcZrMuAUduef/No+rLOoqTYcdNdcLXwIVFcX3gR IXBrlQ6cg/aMq2pBzetw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7aMP-0008Bn-7p; Fri, 28 Feb 2020 07:47:01 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7aML-0008Am-Ia for linux-mtd@lists.infradead.org; Fri, 28 Feb 2020 07:46:59 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id CC48B29691E; Fri, 28 Feb 2020 07:46:54 +0000 (GMT) Date: Fri, 28 Feb 2020 08:46:51 +0100 From: Boris Brezillon To: "Ramuthevar, Vadivel MuruganX" Subject: Re: [PATCH v11 2/2] spi: cadence-quadspi: Add support for the Cadence QSPI controller Message-ID: <20200228084651.1ad0e334@collabora.com> In-Reply-To: References: <20200227062708.21544-1-vadivel.muruganx.ramuthevar@linux.intel.com> <20200227062708.21544-3-vadivel.muruganx.ramuthevar@linux.intel.com> <20200227183032.77ef0795@collabora.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200227_234657_745272_0AAAC202 X-CRM114-Status: GOOD ( 16.61 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, tudor.ambarus@gmail.com, vigneshr@ti.com, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, cyrille.pitchen@atmel.com, marex@denx.de, boris.brezillon@free-electrons.com, tien.fong.chee@intel.com, richard@nod.at, simon.k.r.goldschmidt@gmail.com, devicetree@vger.kernel.org, cheol.yong.kim@intel.com, robh+dt@kernel.org, qi-ming.wu@intel.com, david.oberhollenzer@sigma-star.at, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, dinguyen@kernel.org, broonie@kernel.org, computersforpeace@gmail.com, dwmw2@infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gRnJpLCAyOCBGZWIgMjAyMCAxMjoxMTowOSArMDgwMAoiUmFtdXRoZXZhciwgVmFkaXZlbCBN dXJ1Z2FuWCIKPHZhZGl2ZWwubXVydWdhbngucmFtdXRoZXZhckBsaW51eC5pbnRlbC5jb20+IHdy b3RlOgoKPiBIaSBCb3JpcywKPiAKPiAgwqDCoMKgwqAgVGhhbmsgeW91IHNvIG11Y2ggZm9yIHRo ZSByZXZpZXcgY29tbWVudHMuLi4KPiAKPiBPbiAyOC8yLzIwMjAgMTozMCBBTSwgQm9yaXMgQnJl emlsbG9uIHdyb3RlOgo+ID4gT24gVGh1LCAyNyBGZWIgMjAyMCAxNDoyNzowOCArMDgwMAo+ID4g IlJhbXV0aGV2YXIsIFZhZGl2ZWwgTXVydWdhblgiCj4gPiA8dmFkaXZlbC5tdXJ1Z2FueC5yYW11 dGhldmFyQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gPiAgCj4gPj4gRnJvbTogUmFtdXRoZXZh ciBWYWRpdmVsIE11cnVnYW4gPHZhZGl2ZWwubXVydWdhbngucmFtdXRoZXZhckBsaW51eC5pbnRl bC5jb20+Cj4gPj4KPiA+PiBBZGQgc3VwcG9ydCBmb3IgdGhlIENhZGVuY2UgUVNQSSBjb250cm9s bGVyLiBUaGlzIGNvbnRyb2xsZXIgaXMKPiA+PiBwcmVzZW50IGluIHRoZSBJbnRlbCBMaWdodG5p bmcgTW91bnRhaW4oTEdNKSBTb0NzLCBBbHRlcmEgYW5kIFRJIFNvQ3MuCj4gPj4gVGhpcyBkcml2 ZXIgaGFzIGJlZW4gdGVzdGVkIG9uIHRoZSBJbnRlbCBMR00gU29Dcy4KPiA+Pgo+ID4+IFRoaXMg ZHJpdmVyIGRvZXMgbm90IHN1cHBvcnQgZ2VuZXJpYyBTUEkgYW5kIGFsc28gdGhlIGltcGxlbWVu dGF0aW9uCj4gPj4gb25seSBzdXBwb3J0cyBzcGktbWVtIGludGVyZmFjZSB0byByZXBsYWNlIHRo ZSBleGlzdGluZyBkcml2ZXIgaW4KPiA+PiBtdGQvc3BpLW5vci9jYWRlbmNlLXF1YWRzcGkuYywg dGhlIGV4aXN0aW5nIGRyaXZlciBvbmx5IHN1cHBvcnQgU1BJLU5PUgo+ID4+IGZsYXNoIG1lbW9y eSAgCj4gPiBJcyBpdCByZWFsbHkgc3VwcG9ydGluZyBTUEkgTk9ScyBvbmx5LCBvciBpcyBpdCBq dXN0IHRoYXQgeW91IG9ubHkKPiA+IHRlc3RlZCBpdCB3aXRoIGEgc3BpLW5vcj8gIAo+IAo+IFRo ZSBleGlzdGluZyBkcml2ZXJzL210ZC9zcGktbm9yL2NhZGVuY2UtcXVhZHNwaS5jIHN1cHBvcnRz IFNQSS1OT1JzIAo+IG9ubHksIGJlY2F1c2UgdGhlIGRyaXZlciBpcyBkZXZlbG9wZWQKPiAKPiBz dWNoIGEgd2F5IHRoYXQgaXQgZG9lcyBub3Qgc3VwcG9ydCBvdGhlciBTUEkgYmFzZWQgZmxhc2gg bWVtb3JpZXMsIGFsc28gCj4gbmV2ZXIgdXNlcyBTUEkvU1BJLU1FTSBiYXNlZCBmcmFtZXdvcmsu Cj4gCj4gU28gd2UgVmlnbmVzaCBzdWdnZXN0ZWQgbWUgdG/CoCBkZXZlbG9wIHRoZSBuZXcgZHJp dmVyIHdoaWNoIHN1cHBvcnRzIAo+IGJvdGggU1BJLU5PUiBhbmQgU1BJLU5BTkQgYmFzZWQgb24g dGhlIFNQSS1NRU0gZnJhbWV3b3JrLgoKSG0sIHlvdXIgY29tbWl0IG1lc3NhZ2UgbWFrZXMgaXQg c291bmQgbGlrZSBldmVuIHRoZSBuZXcgZHJpdmVyIGlzbid0CmdlbmVyaWMgZW5vdWdoIHRvIHN1 cHBvcnQgU1BJIE5BTkRzLiBNYXliZSB0aGVyZSdzIHNvbWV0aGluZyB0byBpbXByb3ZlCnRvIGNs YXJpZnkgdGhlIGZhY3QgdGhhdCB0aGlzIG5ldyB2ZXJzaW9uIGlzIG5vdCBsaW1pdGVkIHRvIFNQ SSBOT1JzLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v11 2/2] spi: cadence-quadspi: Add support for the Cadence QSPI controller Date: Fri, 28 Feb 2020 08:46:51 +0100 Message-ID: <20200228084651.1ad0e334@collabora.com> References: <20200227062708.21544-1-vadivel.muruganx.ramuthevar@linux.intel.com> <20200227062708.21544-3-vadivel.muruganx.ramuthevar@linux.intel.com> <20200227183032.77ef0795@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, vigneshr-l0cyMroinI0@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, marex-ynQEQJNshbs@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tien.fong.chee-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, tudor.ambarus-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, richard-/L3Ra7n9ekc@public.gmane.org, qi-ming.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, simon.k.r.goldschmidt-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, david.oberhollenzer-S6VGOU4v5edDinCvNWH78Q@public.gmane.org, dinguyen-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, miquel.raynal-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org, cheol.yong.kim-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org To: "Ramuthevar, Vadivel MuruganX" Return-path: In-Reply-To: Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Fri, 28 Feb 2020 12:11:09 +0800 "Ramuthevar, Vadivel MuruganX" wrote: > Hi Boris, > >      Thank you so much for the review comments... > > On 28/2/2020 1:30 AM, Boris Brezillon wrote: > > On Thu, 27 Feb 2020 14:27:08 +0800 > > "Ramuthevar, Vadivel MuruganX" > > wrote: > > > >> From: Ramuthevar Vadivel Murugan > >> > >> Add support for the Cadence QSPI controller. This controller is > >> present in the Intel Lightning Mountain(LGM) SoCs, Altera and TI SoCs. > >> This driver has been tested on the Intel LGM SoCs. > >> > >> This driver does not support generic SPI and also the implementation > >> only supports spi-mem interface to replace the existing driver in > >> mtd/spi-nor/cadence-quadspi.c, the existing driver only support SPI-NOR > >> flash memory > > Is it really supporting SPI NORs only, or is it just that you only > > tested it with a spi-nor? > > The existing drivers/mtd/spi-nor/cadence-quadspi.c supports SPI-NORs > only, because the driver is developed > > such a way that it does not support other SPI based flash memories, also > never uses SPI/SPI-MEM based framework. > > So we Vignesh suggested me to  develop the new driver which supports > both SPI-NOR and SPI-NAND based on the SPI-MEM framework. Hm, your commit message makes it sound like even the new driver isn't generic enough to support SPI NANDs. Maybe there's something to improve to clarify the fact that this new version is not limited to SPI NORs. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11D66C3F2D0 for ; Fri, 28 Feb 2020 07:47:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E75FB246A2 for ; Fri, 28 Feb 2020 07:47:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726899AbgB1Hq5 convert rfc822-to-8bit (ORCPT ); Fri, 28 Feb 2020 02:46:57 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:47948 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726740AbgB1Hq5 (ORCPT ); Fri, 28 Feb 2020 02:46:57 -0500 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id CC48B29691E; Fri, 28 Feb 2020 07:46:54 +0000 (GMT) Date: Fri, 28 Feb 2020 08:46:51 +0100 From: Boris Brezillon To: "Ramuthevar, Vadivel MuruganX" Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, broonie@kernel.org, vigneshr@ti.com, robh+dt@kernel.org, marex@denx.de, devicetree@vger.kernel.org, tien.fong.chee@intel.com, tudor.ambarus@gmail.com, boris.brezillon@free-electrons.com, richard@nod.at, qi-ming.wu@intel.com, simon.k.r.goldschmidt@gmail.com, david.oberhollenzer@sigma-star.at, dinguyen@kernel.org, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, cheol.yong.kim@intel.com, mark.rutland@arm.com, computersforpeace@gmail.com, dwmw2@infradead.org, cyrille.pitchen@atmel.com Subject: Re: [PATCH v11 2/2] spi: cadence-quadspi: Add support for the Cadence QSPI controller Message-ID: <20200228084651.1ad0e334@collabora.com> In-Reply-To: References: <20200227062708.21544-1-vadivel.muruganx.ramuthevar@linux.intel.com> <20200227062708.21544-3-vadivel.muruganx.ramuthevar@linux.intel.com> <20200227183032.77ef0795@collabora.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 28 Feb 2020 12:11:09 +0800 "Ramuthevar, Vadivel MuruganX" wrote: > Hi Boris, > >      Thank you so much for the review comments... > > On 28/2/2020 1:30 AM, Boris Brezillon wrote: > > On Thu, 27 Feb 2020 14:27:08 +0800 > > "Ramuthevar, Vadivel MuruganX" > > wrote: > > > >> From: Ramuthevar Vadivel Murugan > >> > >> Add support for the Cadence QSPI controller. This controller is > >> present in the Intel Lightning Mountain(LGM) SoCs, Altera and TI SoCs. > >> This driver has been tested on the Intel LGM SoCs. > >> > >> This driver does not support generic SPI and also the implementation > >> only supports spi-mem interface to replace the existing driver in > >> mtd/spi-nor/cadence-quadspi.c, the existing driver only support SPI-NOR > >> flash memory > > Is it really supporting SPI NORs only, or is it just that you only > > tested it with a spi-nor? > > The existing drivers/mtd/spi-nor/cadence-quadspi.c supports SPI-NORs > only, because the driver is developed > > such a way that it does not support other SPI based flash memories, also > never uses SPI/SPI-MEM based framework. > > So we Vignesh suggested me to  develop the new driver which supports > both SPI-NOR and SPI-NAND based on the SPI-MEM framework. Hm, your commit message makes it sound like even the new driver isn't generic enough to support SPI NANDs. Maybe there's something to improve to clarify the fact that this new version is not limited to SPI NORs.