From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/lvm2: lvmetad systemd integration
Date: Fri, 28 Feb 2020 11:17:42 +0100 [thread overview]
Message-ID: <20200228111742.0c9ec807@windsurf.home> (raw)
In-Reply-To: <20200228081859.4237-1-p.debruijn@unilogic.nl>
Hello Pascal!
On Fri, 28 Feb 2020 09:18:59 +0100
Pascal de Bruijn <p.debruijn@unilogic.nl> wrote:
> diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
> index 43370b03bf..6b866ce92b 100644
> --- a/package/lvm2/lvm2.mk
> +++ b/package/lvm2/lvm2.mk
> @@ -54,6 +54,14 @@ else
> LVM2_CONF_OPTS += --disable-applib
> endif
>
> +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> +LVM2_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) install install_systemd_units install_systemd_generators
> +endif
This should be in a separate change, as it's unrelated.
Also, I'd prefer:
LVM2_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) install
ifeq ($(BR2_PACKAGE_SYSTEMD),y)
LVM2_INSTALL_TARGET_OPTS += install_systemd_units install_systemd_generators
endif
> +ifeq ($(BR2_PACKAGE_LVM2_LVMETAD),y)
> +LVM2_CONF_OPTS += --enable-lvmetad
else
LVM2_CONF_OPTS += --disable-lvmetad
> +endif
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-02-28 10:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 8:18 [Buildroot] [PATCH] package/lvm2: lvmetad systemd integration Pascal de Bruijn
2020-02-28 10:17 ` Thomas Petazzoni [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-02-27 7:46 Pascal de Bruijn
2020-02-27 8:10 ` Thomas Petazzoni
2020-02-05 8:13 Pascal de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228111742.0c9ec807@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.