All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Donald Sharp <sharpd@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, dsahern@kernel.org, roopa@cumulusnetworks.com
Subject: Re: [PATCH] ip route: Do not imply pref and ttl-propagate are per nexthop
Date: Fri, 28 Feb 2020 13:47:06 -0800	[thread overview]
Message-ID: <20200228134706.38c873cf@hermes.lan> (raw)
In-Reply-To: <20200225131213.2709230-1-sharpd@cumulusnetworks.com>

On Tue, 25 Feb 2020 08:12:13 -0500
Donald Sharp <sharpd@cumulusnetworks.com> wrote:

> Currently `ip -6 route show` gives us this output:
> 
> sharpd@eva ~/i/ip (master)> ip -6 route show
> ::1 dev lo proto kernel metric 256 pref medium
> 4:5::6:7 nhid 18 proto static metric 20
>         nexthop via fe80::99 dev enp39s0 weight 1
>         nexthop via fe80::44 dev enp39s0 weight 1 pref medium
> 
> Displaying `pref medium` as the last bit of output implies
> that the RTA_PREF is a per nexthop value, when it is infact
> a per route piece of data.
> 
> Change the output to display RTA_PREF and RTA_TTL_PROPAGATE
> before the RTA_MULTIPATH data is shown:
> 
> sharpd@eva ~/i/ip (master)> ./ip -6 route show
> ::1 dev lo proto kernel metric 256 pref medium
> 4:5::6:7 nhid 18 proto static metric 20 pref medium
>         nexthop via fe80::99 dev enp39s0 weight 1
>         nexthop via fe80::44 dev enp39s0 weight 1
> 
> Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Looks good applied

      parent reply	other threads:[~2020-02-28 21:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-25 13:12 [PATCH] ip route: Do not imply pref and ttl-propagate are per nexthop Donald Sharp
2020-02-28 18:30 ` Andrea Claudi
2020-02-28 18:54 ` Roopa Prabhu
2020-02-28 21:47 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200228134706.38c873cf@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=dsahern@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=sharpd@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.