From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Rohit Sarkar <rohitsarkar5398@gmail.com>
Cc: <linux-iio@vger.kernel.org>, <jic23@kernel.org>
Subject: Re: [PATCH v2] staging: iio: update TODO
Date: Fri, 28 Feb 2020 17:36:15 +0000 [thread overview]
Message-ID: <20200228173615.00003c16@Huawei.com> (raw)
In-Reply-To: <20200225144933.19876-1-rohitsarkar5398@gmail.com>
On Tue, 25 Feb 2020 20:19:33 +0530
Rohit Sarkar <rohitsarkar5398@gmail.com> wrote:
> since there are no uses of the old GPIO API, remove the item from the
> TODO and some new items.
>
> Changes from v1:
> Add work item mentioned by Alexandru in https://marc.info/?l=linux-iio&m=158261515624212&w=2
My main issue here is we are adding to the "staging" todo,
a list of tasks that are relevant to all drivers, not those
in staging alone.
Please break this into a simple patch removing the gpio stuff
that is no longer relevant and a second patch to propose additions.
That way I can pick up the uncontroversial part and we can talk
further about whether it makes sense to put system wide TODO entries
in here.
Thanks,
Jonathan
>
> Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com>
> ---
> drivers/staging/iio/TODO | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/iio/TODO b/drivers/staging/iio/TODO
> index 1b8ebf2c1b69..e54510c2ef5f 100644
> --- a/drivers/staging/iio/TODO
> +++ b/drivers/staging/iio/TODO
> @@ -1,11 +1,17 @@
> -2018-04-15
> +2020-02-25
>
> -All affected drivers:
> -Convert all uses of the old GPIO API from <linux/gpio.h> to the
> -GPIO descriptor API in <linux/gpio/consumer.h> and look up GPIO
> -lines from device tree, ACPI or board files, board files should
> -use <linux/gpio/machine.h>.
> +- Documentation
> + - Binding docs for devices that are obviously used via device tree
> + - Yaml conversions for abandoned drivers
> + - ABI Documentation
> + - Audit driviers/iio/staging/Documentation
>
> +- Replace iio_dev->mlock by either a local lock or use iio_claim_direct.
> + (Requires analysis of the purpose of the lock.)
> +
> +- Converting drivers from device tree centric to more generic property handlers
> + Refactor old platform_data constructs from drivers and convert it to state
> + struct and using property handlers and readers.
>
> ADI Drivers:
> CC the device-drivers-devel@blackfin.uclinux.org mailing list when
next prev parent reply other threads:[~2020-02-28 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 19:59 [PATCH] staging: iio: update TODO Rohit Sarkar
2020-02-25 14:49 ` [PATCH v2] " Rohit Sarkar
2020-02-28 17:36 ` Jonathan Cameron [this message]
2020-02-28 19:46 ` Rohit Sarkar
-- strict thread matches above, loose matches on Subject: below --
2020-02-25 15:01 Rohit Sarkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228173615.00003c16@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=rohitsarkar5398@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.