From: afzal mohammed <afzal.mohd.ma@gmail.com>
To: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Cc: Greg Ungerer <gerg@linux-m68k.org>,
Thomas Gleixner <tglx@linutronix.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Finn Thain <fthain@telegraphics.com.au>
Subject: Re: [PATCH v2 06/18] m68k: Replace setup_irq() by request_irq()
Date: Sat, 29 Feb 2020 18:45:53 +0530 [thread overview]
Message-ID: <20200229131553.GA4985@afzalpc> (raw)
In-Reply-To: <00b0bf964278dd0bb3e093283994399ff796cca5.1582471508.git.afzal.mohd.ma@gmail.com>
Hi,
v3 has been posted w/ following changes,
1. Avoid unnecessary derefencing w.r.t irq name in pr_err
2. Modify pr_err() string so as to display in the form similar to,
"Failed to request irq 2 (cascade)"
3. More commit message massage
Above are based on tglx feedback & would be applied to all patches in
addition to rearranging as required in other patches for readability.
Specific to m68k, following changes has been made based on m68 family
;) feedback,
1. Catch the errror code & display the symbolic error name usin "%pe"
format specifier
2. irq # in pr_err (already covered by following pt 2 pattern above)
3. s/pr_err/pr_debug
No altering of control flow based on error value has been done.
Regards
afzal
next prev parent reply other threads:[~2020-02-29 13:15 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 0:47 [PATCH v2 00/18] genirq: Remove setup_irq() afzal mohammed
2020-02-24 0:59 ` afzal mohammed
2020-02-24 0:47 ` afzal mohammed
2020-02-24 0:48 ` [PATCH v2 01/18] alpha: replace setup_irq() by request_irq() afzal mohammed
2020-02-24 0:49 ` [PATCH v2 02/18] ARM: " afzal mohammed
2020-02-24 0:49 ` afzal mohammed
2020-02-24 10:13 ` Lubomir Rintel
2020-02-24 10:13 ` Lubomir Rintel
2020-02-26 16:31 ` Tony Lindgren
2020-02-26 16:31 ` Tony Lindgren
2020-02-24 0:49 ` [PATCH v2 03/18] c6x: " afzal mohammed
2020-02-24 0:49 ` [PATCH v2 04/18] hexagon: " afzal mohammed
2020-02-24 0:49 ` [PATCH v2 05/18] ia64: " afzal mohammed
2020-02-24 0:49 ` afzal mohammed
2020-02-24 0:50 ` [PATCH v2 06/18] m68k: Replace " afzal mohammed
2020-02-26 0:42 ` Greg Ungerer
2020-02-26 1:11 ` Finn Thain
2020-02-26 2:11 ` Greg Ungerer
2020-02-26 6:39 ` Finn Thain
2020-02-26 12:26 ` Greg Ungerer
2020-02-26 22:31 ` Finn Thain
2020-02-27 6:37 ` Greg Ungerer
2020-02-27 22:19 ` Finn Thain
2020-02-27 8:18 ` afzal mohammed
2020-02-27 8:32 ` Geert Uytterhoeven
2020-02-27 12:06 ` afzal mohammed
2020-02-27 22:38 ` Finn Thain
2020-02-29 12:41 ` afzal mohammed
2020-02-28 7:05 ` Greg Ungerer
2020-02-29 12:47 ` afzal mohammed
2020-02-29 13:15 ` afzal mohammed [this message]
2020-02-29 23:11 ` Finn Thain
2020-03-01 1:05 ` afzal mohammed
2020-03-01 3:26 ` Finn Thain
2020-03-01 6:13 ` afzal mohammed
2020-03-02 6:26 ` Finn Thain
2020-03-04 1:24 ` afzal mohammed
2020-02-24 0:50 ` [PATCH v2 07/18] microblaze: " afzal mohammed
2020-02-24 0:50 ` [PATCH v2 08/18] MIPS: " afzal mohammed
2020-02-24 0:50 ` afzal mohammed
2020-02-24 0:51 ` [PATCH v2 09/18] parisc: " afzal mohammed
2020-02-24 0:51 ` [PATCH v2 10/18] powerpc: " afzal mohammed
2020-02-24 0:51 ` afzal mohammed
2020-02-24 0:51 ` [PATCH v2 11/18] s390: replace " afzal mohammed
2020-02-24 0:51 ` [PATCH v2 12/18] sh: " afzal mohammed
2020-02-24 0:51 ` afzal mohammed
2020-02-24 0:52 ` [PATCH v2 13/18] unicore32: " afzal mohammed
2020-02-24 0:52 ` [PATCH v2 14/18] x86: Replace " afzal mohammed
2020-02-24 0:52 ` [PATCH v2 15/18] xtensa: replace " afzal mohammed
2020-02-24 0:52 ` [PATCH v2 16/18] clocksource: Replace " afzal mohammed
2020-02-24 0:52 ` afzal mohammed
2020-02-24 0:52 ` afzal mohammed
2020-02-25 2:52 ` kbuild test robot
2020-02-25 2:52 ` kbuild test robot
2020-02-25 2:52 ` kbuild test robot
2020-02-25 2:52 ` kbuild test robot
2020-02-25 7:51 ` afzal mohammed
2020-02-25 7:51 ` afzal mohammed
2020-02-25 7:51 ` afzal mohammed
2020-02-27 10:59 ` [PATCH v3 " afzal mohammed
2020-02-27 10:59 ` afzal mohammed
2020-02-27 10:59 ` afzal mohammed
2020-02-27 11:18 ` Daniel Lezcano
2020-02-27 11:18 ` Daniel Lezcano
2020-02-27 11:18 ` Daniel Lezcano
2020-03-12 6:48 ` [PATCH v4] clocksource/drivers/timer-cs5535: request irq with non-NULL dev_id afzal mohammed
2020-03-12 6:48 ` afzal mohammed
2020-03-12 6:48 ` afzal mohammed
2020-03-12 7:10 ` afzal mohammed
2020-03-12 7:10 ` afzal mohammed
2020-03-12 7:10 ` afzal mohammed
2020-03-12 18:23 ` Daniel Lezcano
2020-03-12 18:23 ` Daniel Lezcano
2020-03-12 18:23 ` Daniel Lezcano
2020-03-19 8:47 ` [tip: timers/core] clocksource/drivers/timer-cs5535: Request " tip-bot2 for afzal mohammed
2020-04-16 16:08 ` [PATCH v4] clocksource/drivers/timer-cs5535: request " patchwork-bot+linux-amlogic
2020-02-24 0:53 ` [PATCH v2 17/18] irqchip: Replace setup_irq() by request_irq() afzal mohammed
2020-02-24 0:53 ` [PATCH v2 18/18] genirq: Remove setup_irq() and remove_irq() afzal mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200229131553.GA4985@afzalpc \
--to=afzal.mohd.ma@gmail.com \
--cc=fthain@telegraphics.com.au \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.