All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: David Miller <davem@davemloft.net>
Cc: akiyano@amazon.com, netdev@vger.kernel.org, dwmw@amazon.com,
	zorik@amazon.com, matua@amazon.com, saeedb@amazon.com,
	msw@amazon.com, aliguori@amazon.com, nafea@amazon.com,
	gtzalik@amazon.com, netanel@amazon.com, alisaidi@amazon.com,
	benh@amazon.com, ndagan@amazon.com, shayagr@amazon.com,
	sameehj@amazon.com
Subject: Re: [RESEND PATCH V1 net-next] net: ena: fix broken interface between ENA driver and FW
Date: Sun, 1 Mar 2020 15:50:07 +0200	[thread overview]
Message-ID: <20200301135007.GS12414@unreal> (raw)
In-Reply-To: <20200226.204809.102099518712120120.davem@davemloft.net>

On Wed, Feb 26, 2020 at 08:48:09PM -0800, David Miller wrote:
> From: <akiyano@amazon.com>
> Date: Wed, 26 Feb 2020 12:03:35 +0200
>
> > From: Arthur Kiyanovski <akiyano@amazon.com>
> >
> > In this commit we revert the part of
> > commit 1a63443afd70 ("net/amazon: Ensure that driver version is aligned to the linux kernel"),
> > which breaks the interface between the ENA driver and FW.
> >
> > We also replace the use of DRIVER_VERSION with DRIVER_GENERATION
> > when we bring back the deleted constants that are used in interface with
> > ENA device FW.
> >
> > This commit does not change the driver version reported to the user via
> > ethtool, which remains the kernel version.
> >
> > Fixes: 1a63443afd70 ("net/amazon: Ensure that driver version is aligned to the linux kernel")
> > Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
>
> Applied.

Dave,

I see that I'm late here and my email sounds like old man grumbling,
but I asked from those guys to update their commit with request
to put the following line:
"/* DO NOT CHANGE DRV_MODULE_GEN_* values in in-tree code */"
https://lore.kernel.org/netdev/20200224162649.GA4526@unreal/

I also asked how those versions are transferred to FW and used there,
but was ignored.
https://lore.kernel.org/netdev/20200224094116.GD422704@unreal/

BTW, It is also unclear why I wasn't CCed in this patch.

Thanks

  reply	other threads:[~2020-03-01 13:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26 10:03 [RESEND PATCH V1 net-next] net: ena: fix broken interface between ENA driver and FW akiyano
2020-02-27  4:48 ` David Miller
2020-03-01 13:50   ` Leon Romanovsky [this message]
2020-03-05 14:28     ` Kiyanovski, Arthur
2020-03-05 19:16       ` Leon Romanovsky
2020-03-05 20:37         ` Machulsky, Zorik
2020-03-06 12:08           ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200301135007.GS12414@unreal \
    --to=leon@kernel.org \
    --cc=akiyano@amazon.com \
    --cc=aliguori@amazon.com \
    --cc=alisaidi@amazon.com \
    --cc=benh@amazon.com \
    --cc=davem@davemloft.net \
    --cc=dwmw@amazon.com \
    --cc=gtzalik@amazon.com \
    --cc=matua@amazon.com \
    --cc=msw@amazon.com \
    --cc=nafea@amazon.com \
    --cc=ndagan@amazon.com \
    --cc=netanel@amazon.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedb@amazon.com \
    --cc=sameehj@amazon.com \
    --cc=shayagr@amazon.com \
    --cc=zorik@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.