From: Jonathan Cameron <jic23@kernel.org>
To: Sergiu Cuciurean <sergiu.cuciurean@analog.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
<pmeerw@pmeerw.net>, <Michael.Hennerich@analog.com>,
<marcelo.schmitt1@gmail.com>
Subject: Re: [PATCH] iio: adc: ad9292: Use new structure for SPI transfer delays
Date: Sun, 1 Mar 2020 14:36:47 +0000 [thread overview]
Message-ID: <20200301143647.7e611d6b@archlinux> (raw)
In-Reply-To: <20200227121814.14442-1-sergiu.cuciurean@analog.com>
On Thu, 27 Feb 2020 14:18:14 +0200
Sergiu Cuciurean <sergiu.cuciurean@analog.com> wrote:
> In a recent change to the SPI subsystem [1], a new `delay` struct was added
> to replace the `delay_usecs`. This change replaces the current
> `delay_usecs` with `delay` for this driver.
>
> The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
> that both `delay_usecs` & `delay` are used (in this order to preserve
> backwards compatibility).
>
> [1] commit bebcfd272df6 ("spi: introduce `delay` field for
> `spi_transfer` + spi_transfer_delay_exec()")
>
> Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/ad7292.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7292.c b/drivers/iio/adc/ad7292.c
> index a6798f7dfdb8..6595fd196288 100644
> --- a/drivers/iio/adc/ad7292.c
> +++ b/drivers/iio/adc/ad7292.c
> @@ -122,7 +122,10 @@ static int ad7292_single_conversion(struct ad7292_state *st,
> {
> .tx_buf = &st->d8,
> .len = 4,
> - .delay_usecs = 6,
> + .delay = {
> + .value = 6,
> + .unit = SPI_DELAY_UNIT_USECS
> + },
> }, {
> .rx_buf = &st->d16,
> .len = 2,
prev parent reply other threads:[~2020-03-01 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 12:18 [PATCH] iio: adc: ad9292: Use new structure for SPI transfer delays Sergiu Cuciurean
2020-03-01 14:36 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200301143647.7e611d6b@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=sergiu.cuciurean@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.