From: Willy Tarreau <w@1wt.eu>
To: Joe Perches <joe@perches.com>
Cc: Denis Efremov <efremov@linux.com>, Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH v2 0/6] floppy: make use of the local/global fdc explicit
Date: Sun, 1 Mar 2020 22:20:23 +0100 [thread overview]
Message-ID: <20200301212023.GA11317@1wt.eu> (raw)
In-Reply-To: <03a2ea0b91ab61ba9a11230e82f1fb3bdf420a50.camel@perches.com>
On Sun, Mar 01, 2020 at 12:33:25PM -0800, Joe Perches wrote:
> On Sun, 2020-03-01 at 20:55 +0100, Willy Tarreau wrote:
> > This is an update to the first minimal cleanup of the floppy driver in
> > order to make use of the FDC number explicit so as to avoid bugs like
> > the one fixed by 2e90ca68 ("floppy: check FDC index for errors before
> > assigning it").
>
> Thanks Willy.
>
> trivia: you could style check the patches using checkpatch.
Oh yes, sorry about this, I did it in the first series but forgot to
do it again. What checkpatch complains about is essentially lines which
slightly exceed 80 characters due to the macro expansions, while I tried
to limit the changes to the strict minimum. I guess that's OK to keep
future fixes easier to backport.
Thanks,
Willy
next prev parent reply other threads:[~2020-03-01 21:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-01 19:55 [PATCH v2 0/6] floppy: make use of the local/global fdc explicit Willy Tarreau
2020-03-01 19:55 ` [PATCH v2 1/6] floppy: remove dead code for drives scanning on ARM Willy Tarreau
2020-03-01 19:55 ` [PATCH v2 2/6] floppy: remove incomplete support for second FDC from ARM code Willy Tarreau
2020-03-01 19:55 ` [PATCH v2 3/6] floppy: prepare ARM code to simplify base address separation Willy Tarreau
2020-03-01 19:55 ` [PATCH v2 4/6] floppy: introduce new functions fdc_inb() and fdc_outb() Willy Tarreau
2020-03-01 19:55 ` [PATCH v2 5/6] floppy: separate the FDC's base address from its registers Willy Tarreau
2020-03-01 19:55 ` [PATCH v2 6/6] floppy: rename the global "fdc" variable to "current_fdc" Willy Tarreau
2020-03-01 20:33 ` [PATCH v2 0/6] floppy: make use of the local/global fdc explicit Joe Perches
2020-03-01 21:20 ` Willy Tarreau [this message]
2020-03-08 13:12 ` Denis Efremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200301212023.GA11317@1wt.eu \
--to=w@1wt.eu \
--cc=axboe@kernel.dk \
--cc=efremov@linux.com \
--cc=joe@perches.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.