From: Douglas Gilbert <dgilbert@interlog.com>
To: linux-scsi@vger.kernel.org
Cc: martin.petersen@oracle.com, jejb@linux.vnet.ibm.com, hare@suse.de
Subject: [PATCH v8 37/38] sg: warn v3 write system call users
Date: Sun, 1 Mar 2020 22:32:48 -0500 [thread overview]
Message-ID: <20200302033249.4515-38-dgilbert@interlog.com> (raw)
In-Reply-To: <20200302033249.4515-1-dgilbert@interlog.com>
Should generate one log message per kernel run when the write()
system call is used with the sg interface version 3. Due to
security concerns suggest that they use ioctl(SG_SUBMIT_v3)
instead.
Sg interface version 1 or 2 based code may also be calling
write() in this context. There is no easy solution for them
(short of upgrading their interface to version 3 or 4), so
don't produce a warning suggesting the conversion will be
simple.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
---
drivers/scsi/sg.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index 0d835ae88c35..d899c2f18acf 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -645,6 +645,10 @@ sg_write(struct file *filp, const char __user *p, size_t count, loff_t *ppos)
__func__);
return -EPERM;
}
+ WARN_ONCE(true, "Please use %s instead of write(),\n%s\n",
+ "ioctl(SG_SUBMIT_V3)",
+ " See: http://sg.danny.cz/sg/sg_v40.html");
+
res = sg_v3_submit(filp, sfp, h3p, false, NULL);
return res < 0 ? res : (int)count;
}
--
2.25.1
next prev parent reply other threads:[~2020-03-02 3:33 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 3:32 [PATCH v8 00/38] sg: add v4 interface Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 01/38] sg: move functions around Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 02/38] sg: remove typedefs, type+formatting cleanup Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 03/38] sg: sg_log and is_enabled Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 04/38] sg: rework sg_poll(), minor changes Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 05/38] sg: bitops in sg_device Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 06/38] sg: make open count an atomic Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 07/38] sg: move header to uapi section Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 08/38] sg: speed sg_poll and sg_get_num_waiting Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 09/38] sg: sg_allow_if_err_recovery and renames Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 10/38] sg: improve naming Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 11/38] sg: change rwlock to spinlock Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 12/38] sg: ioctl handling Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 13/38] sg: split sg_read Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 14/38] sg: sg_common_write add structure for arguments Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 15/38] sg: rework sg_vma_fault Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 16/38] sg: rework sg_mmap Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 17/38] sg: replace sg_allow_access Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 18/38] sg: rework scatter gather handling Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 19/38] sg: introduce request state machine Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 20/38] sg: sg_find_srp_by_id Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 21/38] sg: sg_fill_request_element Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 22/38] sg: printk change %p to %pK Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 23/38] sg: xarray for fds in device Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 24/38] sg: xarray for reqs in fd Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 25/38] sg: replace rq array with lists Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 26/38] sg: sense buffer rework Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 27/38] sg: add sg v4 interface support Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 28/38] sg: rework debug info Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 29/38] sg: add 8 byte SCSI LUN to sg_scsi_id Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 30/38] sg: expand sg_comm_wr_t Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 31/38] sg: add sg_iosubmit_v3 and sg_ioreceive_v3 ioctls Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 32/38] sg: add some __must_hold macros Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 33/38] sg: move procfs objects to avoid forward decls Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 34/38] sg: protect multiple receivers Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 35/38] sg: first debugfs support Douglas Gilbert
2020-03-02 3:32 ` [PATCH v8 36/38] sg: rework mmap support Douglas Gilbert
2020-03-02 3:32 ` Douglas Gilbert [this message]
2020-03-02 3:32 ` [PATCH v8 38/38] sg: bump version to 4.0.08 Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302033249.4515-38-dgilbert@interlog.com \
--to=dgilbert@interlog.com \
--cc=hare@suse.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.