All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Smatch indenting warnings?
Date: Mon, 02 Mar 2020 15:49:42 +0300	[thread overview]
Message-ID: <20200302124942.GD4118@kadam> (raw)

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

Smatch prints a lot of warnings about inconsistent indenting.

sound/soc/codecs/max98088.c:1746 max98088_i2c_probe() warn: inconsistent indenting
sound/core/seq/oss/seq_oss_event.c:297 note_on_event() warn: inconsistent indenting
sound/core/rawmidi.c:1882 alsa_rawmidi_init() warn: inconsistent indenting


$ grep "inconsistent indenting" smatch_warns.txt | wc -l
321

These are generally not bugs, but the check has a low false positive
ratio and it's all stuff which really should be fixed.  I seldom report
them but it would be nice if kbuild reported them automatically.

regards,
dan carpenter

             reply	other threads:[~2020-03-02 12:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-02 12:49 Dan Carpenter [this message]
2020-03-02 15:06 ` Smatch indenting warnings? Li, Philip
2020-03-02 15:12   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200302124942.GD4118@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.