From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1683DC3F2D2 for ; Mon, 2 Mar 2020 13:02:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF9B120863 for ; Mon, 2 Mar 2020 13:02:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="M4boMbZW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727869AbgCBNCA (ORCPT ); Mon, 2 Mar 2020 08:02:00 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:41250 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727644AbgCBNCA (ORCPT ); Mon, 2 Mar 2020 08:02:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FiLor1i8rXZoXEJEzNkZ/KpyLzC6P9f7qqRBo8GyGJA=; b=M4boMbZWwibGWaDa9Ay/YE+uzp +FavjE7Y3btmzUCr8WYtI8x+aN1Z8phBn6zQ7lHkgG3TpDu2gpxWfd3NLUrk9mNI1XJaoW33RVU26 e2MF9T63w/jicFdTjjFJqWgKKVovfVmpElwvpb7EPJ/BbjF98dKBFqwkfuh8mhkwz+GI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1j8khn-0005Sl-V7; Mon, 02 Mar 2020 14:01:55 +0100 Date: Mon, 2 Mar 2020 14:01:55 +0100 From: Andrew Lunn To: sunil.kovvuri@gmail.com Cc: netdev@vger.kernel.org, davem@davemloft.net, Geetha sowjanya , Sunil Goutham Subject: Re: [PATCH 3/7] octeontx2-pf: Support to enable/disable pause frames via ethtool Message-ID: <20200302130155.GE31977@lunn.ch> References: <1583133568-5674-1-git-send-email-sunil.kovvuri@gmail.com> <1583133568-5674-4-git-send-email-sunil.kovvuri@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1583133568-5674-4-git-send-email-sunil.kovvuri@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Sunil > +static int otx2_set_pauseparam(struct net_device *netdev, > + struct ethtool_pauseparam *pause) > +{ > + struct otx2_nic *pfvf = netdev_priv(netdev); > + > + if (pause->autoneg) > + return -EOPNOTSUPP; Nice to see somebody getting that bit correct. Reviewed-by: Andrew Lunn Andrew