From: Jiri Olsa <jolsa@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Leo Yan <leo.yan@linaro.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 03/13] kprobes: Add symbols for kprobe insn pages
Date: Mon, 2 Mar 2020 15:43:07 +0100 [thread overview]
Message-ID: <20200302144307.GD204976@krava> (raw)
In-Reply-To: <20200229184913.4e13e516@oasis.local.home>
On Sat, Feb 29, 2020 at 06:49:13PM -0500, Steven Rostedt wrote:
> On Sat, 29 Feb 2020 13:49:47 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > On Fri, 28 Feb 2020 18:20:04 +0100
> > Jiri Olsa <jolsa@redhat.com> wrote:
> >
> > > > BTW, it seems to pretend to be a module, but is there no concern of
> > > > confusing users? Shouldn't it be [*kprobes] so that it is non-exist
> > > > module name?
> > >
> > > note we already have bpf symbols as [bpf] module
> >
> > Yeah, and this series adds [kprobe(s)] and [ftrace] too.
> > I simply concern that the those module names implicitly become
> > special word (rule) and embedded in the code. If such module names
> > are not exposed to users, it is OK (but I hope to have some comments).
> > However, it is under /proc, which means users can notice it.
>
> I share Masami's concerns. It would be good to have something
> differentiate local functions that are not modules. That's one way I
> look to see if something is a module or built in, is to see if kallsyms
> has it as a [].
>
> Perhaps prepend with: '&' ?
that would break some of the perf code.. IMO Arnaldo's explanation
makes sense and we could keep it as it is
jirka
next prev parent reply other threads:[~2020-03-02 14:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 13:51 [PATCH V3 00/13] perf/x86: Add perf text poke events Adrian Hunter
2020-02-28 13:51 ` [PATCH V3 01/13] perf: Add perf text poke event Adrian Hunter
2020-02-28 13:51 ` [PATCH V3 02/13] perf/x86: Add support for perf text poke event for text_poke_bp_batch() callers Adrian Hunter
2020-02-28 13:51 ` [PATCH V3 03/13] kprobes: Add symbols for kprobe insn pages Adrian Hunter
2020-02-28 14:36 ` Masami Hiramatsu
2020-02-28 17:20 ` Jiri Olsa
2020-02-28 18:51 ` Arnaldo Carvalho de Melo
2020-02-29 4:49 ` Masami Hiramatsu
2020-02-29 23:49 ` Steven Rostedt
2020-03-02 14:43 ` Jiri Olsa [this message]
2020-03-03 10:47 ` [OT] Pseudo module name in kallsyms (Re: [PATCH V3 03/13] kprobes: Add symbols for kprobe insn pages) Masami Hiramatsu
2020-03-03 10:55 ` Adrian Hunter
2020-03-03 14:21 ` Steven Rostedt
2020-03-03 15:40 ` Masami Hiramatsu
2020-02-28 13:51 ` [PATCH V3 04/13] kprobes: Add perf ksymbol events for kprobe insn pages Adrian Hunter
2020-02-28 15:11 ` Masami Hiramatsu
2020-02-29 3:51 ` Masami Hiramatsu
2020-02-28 13:51 ` [PATCH V3 05/13] perf/x86: Add perf text poke events for kprobes Adrian Hunter
2020-02-28 13:51 ` [PATCH V3 06/13] ftrace: Add symbols for ftrace trampolines Adrian Hunter
2020-02-28 16:27 ` Steven Rostedt
2020-02-28 13:51 ` [PATCH V3 07/13] ftrace: Add perf ksymbol events " Adrian Hunter
2020-02-28 13:51 ` [PATCH V3 08/13] ftrace: Add perf text poke " Adrian Hunter
2020-02-28 13:51 ` [PATCH V3 09/13] perf kcore_copy: Fix module map when there are no modules loaded Adrian Hunter
2020-02-28 13:51 ` [PATCH V3 10/13] perf evlist: Disable 'immediate' events last Adrian Hunter
2020-02-28 13:51 ` [PATCH V3 11/13] perf tools: Add support for PERF_RECORD_TEXT_POKE Adrian Hunter
2020-02-28 13:51 ` [PATCH V3 12/13] perf tools: Add support for PERF_RECORD_KSYMBOL_TYPE_OOL Adrian Hunter
2020-02-28 13:51 ` [PATCH V3 13/13] perf intel-pt: Add support for text poke events Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302144307.GD204976@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.