From: Rob Herring <robh@kernel.org>
To: frowand.list@gmail.com
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
pantelis.antoniou@konsulko.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Alan Tull <atull@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH] of: unittest: make gpio overlay test dependent on CONFIG_OF_GPIO
Date: Mon, 2 Mar 2020 11:31:23 -0600 [thread overview]
Message-ID: <20200302173123.GA12343@bogus> (raw)
In-Reply-To: <1582863389-3118-1-git-send-email-frowand.list@gmail.com>
On Thu, 27 Feb 2020 22:16:29 -0600, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> Randconfig testing found compile errors in drivers/of/unittest.c if
> CONFIG_GPIOLIB is not set because CONFIG_OF_GPIO depends on
> CONFIG_GPIOLIB. Make the gpio overlay test depend on CONFIG_OF_GPIO.
>
> No code is modified, it is only moved to a different location and
> protected with #ifdef CONFIG_OF_GPIO. An empty
> of_unittest_overlay_gpio() is added in the #else.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
> drivers/of/unittest.c | 465 ++++++++++++++++++++++++++------------------------
> 1 file changed, 238 insertions(+), 227 deletions(-)
>
Applied, thanks.
Rob
prev parent reply other threads:[~2020-03-02 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 4:16 [PATCH] of: unittest: make gpio overlay test dependent on CONFIG_OF_GPIO frowand.list
2020-02-28 4:25 ` Randy Dunlap
2020-02-28 14:10 ` Frank Rowand
2020-03-02 17:33 ` Rob Herring
2020-03-02 17:31 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302173123.GA12343@bogus \
--to=robh@kernel.org \
--cc=atull@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.