All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: CPU reset vs DeviceState reset
Date: Mon, 2 Mar 2020 16:40:36 -0500	[thread overview]
Message-ID: <20200302214036.GO4440@habkost.net> (raw)
In-Reply-To: <CAFEAcA8AY4ZPuWh=oPd4heepAAZziLP1DLNHhrC_3jLuMXnBcQ@mail.gmail.com>

On Mon, Mar 02, 2020 at 06:41:31PM +0000, Peter Maydell wrote:
> On Mon, 2 Mar 2020 at 17:45, Eduardo Habkost <ehabkost@redhat.com> wrote:
> >
> > My impression is that this is just historical legacy, but I'm not
> > sure how much work a conversion to the new system would require.
> > I see lots of cpu_reset() calls scattered around the code.
> 
> I think we can just make the cpu_reset() function be a
> wrapper that calls device_cold_reset(DEVICE(cpu)).
> We would need to update the prototypes for

[1] This might have unintended side effects, as it will also call
    cpu_common_reset().  I still think we should try it.

> 
> > To make it worse, TYPE_CPU do have a DeviceClass::reset method
> > implemented, but cpu_reset() won't call it because it bypasses
> > the Device reset system completely.  I will do some git
> > archaeology work to try to find out why the code is this way.
> 
> At least for Arm CPUs, I don't think it does (well, it
> has the default DeviceState base class reset method
> which does nothing). Is there somewhere I missed?

TYPE_CPU points DeviceClass::reset to cpu_common_reset(),
so I believe this affects all TYPE_CPU descendants.

> 
> (I'm currently attempting to wrestle Coccinelle into
> doing the conversion of the target/ code automatically.)

I see 3 separate problems we might want to address:

1) Making device_cold_reset() end up calling CPUClass::reset
   in addition to existing cpu_common_reset()
   (easier to do without side effects).  This would get rid of
   the custom reset callbacks on machine code.

2) Making cpu_reset() call device_cold_reset()
   (will have side effects, needs additional care[1]).
   This would make us have only one method of resetting CPUs.

3) Replacing CPUClass::reset with the new reset mechanisms..
   This would let us get rid of legacy CPU reset code.

-- 
Eduardo



  reply	other threads:[~2020-03-02 21:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-02 17:20 CPU reset vs DeviceState reset Peter Maydell
2020-03-02 17:25 ` Peter Maydell
2020-03-02 17:45 ` Eduardo Habkost
2020-03-02 18:19   ` Philippe Mathieu-Daudé
2020-03-02 18:42     ` Peter Maydell
2020-03-02 21:42       ` Eduardo Habkost
2020-03-02 18:41   ` Peter Maydell
2020-03-02 21:40     ` Eduardo Habkost [this message]
2020-03-02 21:55       ` Peter Maydell
2020-03-02 22:12         ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200302214036.GO4440@habkost.net \
    --to=ehabkost@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.