From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F40FC3F2D1 for ; Tue, 3 Mar 2020 01:42:40 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CCC5821D56 for ; Tue, 3 Mar 2020 01:42:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="nu6YSHAx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCC5821D56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 30D0C1673; Tue, 3 Mar 2020 02:41:48 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 30D0C1673 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1583199758; bh=FCRHZFY4XwBLlkUSJjiRDLp68eLVuwbkrGsACThosxM=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nu6YSHAxSob8MRg3aCe5aUXlrVgjOBIyAPp5uIgozvYVYTJUpTNkee/uzdROZaqqL VQ828w13zDIHw8VcYSrdRfLrYYlDdRaAOfMWlqSu8bpXEoEqhh0DoG5HpnKvY2j6ob sOlocE1LA5xgezVuvPmHmP0IRrfzwlNPa1G1ZYko= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7EA05F800E5; Tue, 3 Mar 2020 02:41:47 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9D131F801ED; Tue, 3 Mar 2020 02:41:45 +0100 (CET) Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 58F23F800E5 for ; Tue, 3 Mar 2020 02:41:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 58F23F800E5 Received: by mail-ot1-f65.google.com with SMTP id x19so1412999otp.7 for ; Mon, 02 Mar 2020 17:41:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wTmd93QvHJKnRP/iE9AlgpSex86ml4dgAiKBLvXi4d8=; b=ilmGvLfZgg0VzBuDD7GNjBR0KvXYcCo6IitxMMkWEacitG3/xtutob3PwEMFQPUvj7 PLfz/nBjo9lSU+fjetOIN5TdBVQ+rJIHR0STkjlVrEsscX9oiL4cYmr6/cwSBaOtgV9z tFBsBez9xv4txtyzw6gKFhchstRfOIL61l0nJ0j45XBkkOVr3VUOE1r2K4ZsyfsSTzMO V+GGwUocDVgvHku3fHcwRAT/Jc225zISvBgsPbnAP6GhV/oOEdUXJllbSLGZPJXr5HWs ZWndoCD7lI/XkFY+aS3mRQ4VCrFhwLDarGeGm6iyp6lb6RBEih1Y0cED/IDTyAWdhqI6 5cFQ== X-Gm-Message-State: ANhLgQ315UNi83sTO2SFJWTGMrTaFO6TiCWVfBBq+ug702Fk+Zt96QhW 8vaKIfW90kHa1xcXJ3tKsQ== X-Google-Smtp-Source: ADFU+vsdNg78DFlU+1lj7jVL9V1hy4eNjciajaJxnlZGh0to9M1K+WoyXSAT3r6zp73f0HaM+PIrow== X-Received: by 2002:a9d:836:: with SMTP id 51mr1698659oty.318.1583199694975; Mon, 02 Mar 2020 17:41:34 -0800 (PST) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 16sm6365123otc.33.2020.03.02.17.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2020 17:41:34 -0800 (PST) Received: (nullmailer pid 25998 invoked by uid 1000); Tue, 03 Mar 2020 01:41:33 -0000 Date: Mon, 2 Mar 2020 19:41:33 -0600 From: Rob Herring To: Shengjiu Wang Subject: Re: [PATCH v4 1/8] ASoC: dt-bindings: fsl_asrc: Change asrc-width to asrc-format Message-ID: <20200303014133.GA24596@bogus> References: <872c2e1082de6348318e14ccd31884d62355c282.1583039752.git.shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <872c2e1082de6348318e14ccd31884d62355c282.1583039752.git.shengjiu.wang@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, timur@kernel.org, Xiubo.Lee@gmail.com, shawnguo@kernel.org, s.hauer@pengutronix.de, tiwai@suse.com, lgirdwood@gmail.com, nicoleotsuka@gmail.com, broonie@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sun, Mar 01, 2020 at 01:24:12PM +0800, Shengjiu Wang wrote: > asrc_format is more inteligent, which is align with the alsa > definition snd_pcm_format_t, we don't need to convert it to > format in driver, and it can distinguish S24_LE & S24_3LE. > > Signed-off-by: Shengjiu Wang > --- > Documentation/devicetree/bindings/sound/fsl,asrc.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt > index cb9a25165503..0cbb86c026d5 100644 > --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt > +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt > @@ -38,7 +38,9 @@ Required properties: > > - fsl,asrc-rate : Defines a mutual sample rate used by DPCM Back Ends. > > - - fsl,asrc-width : Defines a mutual sample width used by DPCM Back Ends. > + - fsl,asrc-format : Defines a mutual sample format used by DPCM Back > + Ends. The value is one of SNDRV_PCM_FORMAT_XX in > + "include/uapi/sound/asound.h" You can't just change properties. They are an ABI. > > - fsl,asrc-clk-map : Defines clock map used in driver. which is required > by imx8qm/imx8qxp platform > -- > 2.21.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3EFEC3F2CD for ; Tue, 3 Mar 2020 01:43:34 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E97C24677 for ; Tue, 3 Mar 2020 01:43:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E97C24677 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48WftD53m7zDqdW for ; Tue, 3 Mar 2020 12:43:32 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.210.68; helo=mail-ot1-f68.google.com; envelope-from=robherring2@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48Wfr13hTmzDqQv for ; Tue, 3 Mar 2020 12:41:37 +1100 (AEDT) Received: by mail-ot1-f68.google.com with SMTP id x97so1411355ota.6 for ; Mon, 02 Mar 2020 17:41:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wTmd93QvHJKnRP/iE9AlgpSex86ml4dgAiKBLvXi4d8=; b=qyuvmYVUtUq7hm+uX48jKMvZFQsWbBf60+paZODlJ7fEFQ4YnxKy7DnH5t0/U1vnKE k/2c5ZXXBGdaENf0sIZUS+qexBQfudM4FUFMmNgA5FUpHL0wmpmomX0fA6KAKsiFLK1p /e3tXqE/YnyJaNIgSJLwYTMG3hncyToTKGAjMQtM+kr+YszCGRM32jUufV3ITSkBRB/m NgAKsJvNalonIsRkaSZu32QI1s51vbmG8tnmhxXOBEMPu06OzpCWtMkG+B62hFgBuV7T MI8bL4PSq3zxIA064Wp6JprqJhU9AU7zj9xF75cF1k7T46UCECorG61oT+mlSHsE7AiB l2XQ== X-Gm-Message-State: ANhLgQ11v9bi76KIt9sE2Q6eml95GGMIxgW7uMwRs94xljv1chE42NSp zUlaag83yiiYChQVJxnoHg== X-Google-Smtp-Source: ADFU+vsdNg78DFlU+1lj7jVL9V1hy4eNjciajaJxnlZGh0to9M1K+WoyXSAT3r6zp73f0HaM+PIrow== X-Received: by 2002:a9d:836:: with SMTP id 51mr1698659oty.318.1583199694975; Mon, 02 Mar 2020 17:41:34 -0800 (PST) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 16sm6365123otc.33.2020.03.02.17.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2020 17:41:34 -0800 (PST) Received: (nullmailer pid 25998 invoked by uid 1000); Tue, 03 Mar 2020 01:41:33 -0000 Date: Mon, 2 Mar 2020 19:41:33 -0600 From: Rob Herring To: Shengjiu Wang Subject: Re: [PATCH v4 1/8] ASoC: dt-bindings: fsl_asrc: Change asrc-width to asrc-format Message-ID: <20200303014133.GA24596@bogus> References: <872c2e1082de6348318e14ccd31884d62355c282.1583039752.git.shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <872c2e1082de6348318e14ccd31884d62355c282.1583039752.git.shengjiu.wang@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, timur@kernel.org, Xiubo.Lee@gmail.com, shawnguo@kernel.org, s.hauer@pengutronix.de, tiwai@suse.com, lgirdwood@gmail.com, perex@perex.cz, nicoleotsuka@gmail.com, broonie@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sun, Mar 01, 2020 at 01:24:12PM +0800, Shengjiu Wang wrote: > asrc_format is more inteligent, which is align with the alsa > definition snd_pcm_format_t, we don't need to convert it to > format in driver, and it can distinguish S24_LE & S24_3LE. > > Signed-off-by: Shengjiu Wang > --- > Documentation/devicetree/bindings/sound/fsl,asrc.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt > index cb9a25165503..0cbb86c026d5 100644 > --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt > +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt > @@ -38,7 +38,9 @@ Required properties: > > - fsl,asrc-rate : Defines a mutual sample rate used by DPCM Back Ends. > > - - fsl,asrc-width : Defines a mutual sample width used by DPCM Back Ends. > + - fsl,asrc-format : Defines a mutual sample format used by DPCM Back > + Ends. The value is one of SNDRV_PCM_FORMAT_XX in > + "include/uapi/sound/asound.h" You can't just change properties. They are an ABI. > > - fsl,asrc-clk-map : Defines clock map used in driver. which is required > by imx8qm/imx8qxp platform > -- > 2.21.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 999BAC3F2D1 for ; Tue, 3 Mar 2020 01:41:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B2B024677 for ; Tue, 3 Mar 2020 01:41:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="G/O/o6PV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B2B024677 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3lKex+6qE+9MEbAePGnOUBM++X5MYW1mb7xnotkLOZE=; b=G/O/o6PVPDmIx5 JcK//U3XC4zgF6yrB5NXWyE8/5O9w6ciPGoHgdIY6XMQ2aBbTU+xD1FgC25Dz2Ic8JPIhupk5C9qd bbeR+2Mld3P440OzkWfKvV8F9OESQTNF5G+vmokt84uFdktS+kqwH/QufTNZkYkYefwc9vh4JReAN 3+4GCAZX4FzzuS4XM12BYCWnHzAz6SNGPLznH78J1ryu3t4iy3PdoQYbRwv+dJUMaPjF3OSyONutV ocoAHe0UlXY2nRqYzeT+dox1cNWIPf82MekBAlD8qhKs26Tw7Ew6S6gm8GdvtWYCy7NZ/9y5gapNd W9C5VbWz4JIQk9N3r1rA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j8wZ3-0005b7-L3; Tue, 03 Mar 2020 01:41:41 +0000 Received: from mail-ot1-f66.google.com ([209.85.210.66]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j8wZ0-0005aC-8A for linux-arm-kernel@lists.infradead.org; Tue, 03 Mar 2020 01:41:39 +0000 Received: by mail-ot1-f66.google.com with SMTP id i14so1421702otp.5 for ; Mon, 02 Mar 2020 17:41:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wTmd93QvHJKnRP/iE9AlgpSex86ml4dgAiKBLvXi4d8=; b=j7edoqBbfbisCWGOrMmI3VSGd+Bkw2j42czNqPOMcbKKwk2Gv1AJ41kA+vtMquHJxE o6s5J14ezR6+Ztj7qF2kd7Hw+HX2bOlbJISo23H7+HDFpM473W3lZvN5avsnogbEGhUj LOFYOUb3kbpyxoiA4s9b26FxOH/e5RwC47U9BzkW0W2UZMXPxXGYOADK95BS/JKOVfxQ yd2QS6NAjEVHAY7mOPva2XxHIXV0TOYLEF6wfzQFwXhYdcmdrxAOomDykIbsLhofayQG iFvLWBVEeDpHh1yvlKdRAWI9zERjd7cGc/FsN9z3vE1VnpzjsYchgz0Us7bTx3DUcCaa AYsQ== X-Gm-Message-State: ANhLgQ2zlGCv22hH4vb5IMnlzSx9EoQG4XAEKf8+3n3ZQcO2t3Yr5RXs 2iN2uLxSYocfwRb0aCdcSQ== X-Google-Smtp-Source: ADFU+vsdNg78DFlU+1lj7jVL9V1hy4eNjciajaJxnlZGh0to9M1K+WoyXSAT3r6zp73f0HaM+PIrow== X-Received: by 2002:a9d:836:: with SMTP id 51mr1698659oty.318.1583199694975; Mon, 02 Mar 2020 17:41:34 -0800 (PST) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 16sm6365123otc.33.2020.03.02.17.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2020 17:41:34 -0800 (PST) Received: (nullmailer pid 25998 invoked by uid 1000); Tue, 03 Mar 2020 01:41:33 -0000 Date: Mon, 2 Mar 2020 19:41:33 -0600 From: Rob Herring To: Shengjiu Wang Subject: Re: [PATCH v4 1/8] ASoC: dt-bindings: fsl_asrc: Change asrc-width to asrc-format Message-ID: <20200303014133.GA24596@bogus> References: <872c2e1082de6348318e14ccd31884d62355c282.1583039752.git.shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <872c2e1082de6348318e14ccd31884d62355c282.1583039752.git.shengjiu.wang@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200302_174138_291834_48E8027B X-CRM114-Status: GOOD ( 14.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, timur@kernel.org, Xiubo.Lee@gmail.com, shawnguo@kernel.org, s.hauer@pengutronix.de, tiwai@suse.com, lgirdwood@gmail.com, perex@perex.cz, nicoleotsuka@gmail.com, broonie@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Mar 01, 2020 at 01:24:12PM +0800, Shengjiu Wang wrote: > asrc_format is more inteligent, which is align with the alsa > definition snd_pcm_format_t, we don't need to convert it to > format in driver, and it can distinguish S24_LE & S24_3LE. > > Signed-off-by: Shengjiu Wang > --- > Documentation/devicetree/bindings/sound/fsl,asrc.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt > index cb9a25165503..0cbb86c026d5 100644 > --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt > +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt > @@ -38,7 +38,9 @@ Required properties: > > - fsl,asrc-rate : Defines a mutual sample rate used by DPCM Back Ends. > > - - fsl,asrc-width : Defines a mutual sample width used by DPCM Back Ends. > + - fsl,asrc-format : Defines a mutual sample format used by DPCM Back > + Ends. The value is one of SNDRV_PCM_FORMAT_XX in > + "include/uapi/sound/asound.h" You can't just change properties. They are an ABI. > > - fsl,asrc-clk-map : Defines clock map used in driver. which is required > by imx8qm/imx8qxp platform > -- > 2.21.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1DCDC3F2CD for ; Tue, 3 Mar 2020 01:41:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91A0221D56 for ; Tue, 3 Mar 2020 01:41:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583199696; bh=FCRHZFY4XwBLlkUSJjiRDLp68eLVuwbkrGsACThosxM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=BnhO+SwInRhj8Pie6GEEEIq400X11787LBlh75Zor4UgD10UqxJpK6QLtazg8qUoX fFXo45XskBvIOw5hoP/xIQ+2Teh4YTTteQcZv7Y+acMfL7kN/ngJEGJezq3w6ApgwW MfvcSH0LxgYPCw05kosaH3rNeSjue98Ed2d81+yA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726843AbgCCBlg (ORCPT ); Mon, 2 Mar 2020 20:41:36 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:43090 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726773AbgCCBlf (ORCPT ); Mon, 2 Mar 2020 20:41:35 -0500 Received: by mail-ot1-f67.google.com with SMTP id j5so1392386otn.10; Mon, 02 Mar 2020 17:41:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wTmd93QvHJKnRP/iE9AlgpSex86ml4dgAiKBLvXi4d8=; b=HnL0eK6h39nv2tHEQnhGhARkA8qQrmgaxOsvpW4vJ4MCblOf+zNwQ4pw8Q1ku36cor AMXlHwWKlZQZfhnld1SqFCaHI22ZiEChPqatWLpSZwyhKv+f3fE3oEX33giTgHOHLQ9K pXACzouanLF8t8eKavNRzDWbSqTFBfCouBZtwnT1jGHwNODHPPxBwHEB48yCungETfpy mrA+eIs9NJNaDqyFbjksGfYgxxr93VjOxX0/NF+xBxmctqNaSDS5GssYXGXKGcB3cg9S V3QpuQy0ZcXGmc7lw3wNvjpOfrvfcaEFFbcx1LTsh6I+RGyVoRLEQC49ND/nhlAJm+Be hpqw== X-Gm-Message-State: ANhLgQ2IPOYsEJG2gSa9nzSsbnDDmuSHanJYCuti2kgYo+UuBE3M0DVl bzecSE3J6bYqRlQ/pexKlA== X-Google-Smtp-Source: ADFU+vsdNg78DFlU+1lj7jVL9V1hy4eNjciajaJxnlZGh0to9M1K+WoyXSAT3r6zp73f0HaM+PIrow== X-Received: by 2002:a9d:836:: with SMTP id 51mr1698659oty.318.1583199694975; Mon, 02 Mar 2020 17:41:34 -0800 (PST) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 16sm6365123otc.33.2020.03.02.17.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2020 17:41:34 -0800 (PST) Received: (nullmailer pid 25998 invoked by uid 1000); Tue, 03 Mar 2020 01:41:33 -0000 Date: Mon, 2 Mar 2020 19:41:33 -0600 From: Rob Herring To: Shengjiu Wang Cc: timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, broonie@kernel.org, alsa-devel@alsa-project.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, mark.rutland@arm.com, devicetree@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/8] ASoC: dt-bindings: fsl_asrc: Change asrc-width to asrc-format Message-ID: <20200303014133.GA24596@bogus> References: <872c2e1082de6348318e14ccd31884d62355c282.1583039752.git.shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <872c2e1082de6348318e14ccd31884d62355c282.1583039752.git.shengjiu.wang@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Mar 01, 2020 at 01:24:12PM +0800, Shengjiu Wang wrote: > asrc_format is more inteligent, which is align with the alsa > definition snd_pcm_format_t, we don't need to convert it to > format in driver, and it can distinguish S24_LE & S24_3LE. > > Signed-off-by: Shengjiu Wang > --- > Documentation/devicetree/bindings/sound/fsl,asrc.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt > index cb9a25165503..0cbb86c026d5 100644 > --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt > +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt > @@ -38,7 +38,9 @@ Required properties: > > - fsl,asrc-rate : Defines a mutual sample rate used by DPCM Back Ends. > > - - fsl,asrc-width : Defines a mutual sample width used by DPCM Back Ends. > + - fsl,asrc-format : Defines a mutual sample format used by DPCM Back > + Ends. The value is one of SNDRV_PCM_FORMAT_XX in > + "include/uapi/sound/asound.h" You can't just change properties. They are an ABI. > > - fsl,asrc-clk-map : Defines clock map used in driver. which is required > by imx8qm/imx8qxp platform > -- > 2.21.0 >