From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Qiming Yang <qiming.yang@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix X722 performance drop
Date: Tue, 3 Mar 2020 09:56:07 +0800 [thread overview]
Message-ID: <20200303015607.GD25927@intel.com> (raw)
In-Reply-To: <20200226092221.85536-1-qiming.yang@intel.com>
Hi, Qiming
On 02/26, Qiming Yang wrote:
>GL_SWR_PM_UP_THR value lack in X722 caused configure register write not be
>called. This is the root cause of performance drop. This patch add support
>for:
Could you elaborate what kind of performance drop caused by the missing register
cfg?
Thanks,
Xiaolong
>
> Device-ID Value Comments
> 0x37D0 0x03030303 4x10G FPK
>
>Fixes: 3320d4a240da ("net/i40e: workaround performance degradation")
>Cc: stable@dpdk.org
>
>Signed-off-by: Qiming Yang <qiming.yang@intel.com>
>---
> drivers/net/i40e/i40e_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>index 9fbda1c..c09b9b9 100644
>--- a/drivers/net/i40e/i40e_ethdev.c
>+++ b/drivers/net/i40e/i40e_ethdev.c
>@@ -10504,6 +10504,7 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value)
> { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_KX_C) },
> { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T) },
> { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T4) },
>+ { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_SFP_X722) },
>
> { I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_KX_B) },
> { I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_QSFP_A) },
>--
>2.9.5
>
next prev parent reply other threads:[~2020-03-03 1:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 9:22 [dpdk-dev] [PATCH] net/i40e: fix X722 performance drop Qiming Yang
2020-03-03 1:56 ` Ye Xiaolong [this message]
2020-03-03 5:45 ` [dpdk-dev] [PATCH v2] " Qiming Yang
2020-03-03 6:14 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303015607.GD25927@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.