From: Mel Gorman <mgorman@techsingularity.net>
To: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Juri Lelli <juri.lelli@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>,
Valentin Schneider <valentin.schneider@arm.com>,
Lukasz Luba <lukasz.luba@arm.com>, Phil Auld <pauld@redhat.com>,
Hillf Danton <hdanton@sina.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Paul McKenney <paulmck@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Mel Gorman <mgorman@techsingularity.net>
Subject: [PATCH 1/3] sched/fair: Fix statistics for find_idlest_group()
Date: Tue, 3 Mar 2020 11:02:56 +0000 [thread overview]
Message-ID: <20200303110258.1092-2-mgorman@techsingularity.net> (raw)
In-Reply-To: <20200303110258.1092-1-mgorman@techsingularity.net>
From: Vincent Guittot <vincent.guittot@linaro.org>
From: Vincent Guittot <vincent.guittot@linaro.org>
sgs->group_weight is not set while gathering statistics in
update_sg_wakeup_stats(). This means that a group can be classified as
fully busy with 0 running tasks if utilization is high enough.
This path is mainly used for fork and exec.
Fixes: 57abff067a08 ("sched/fair: Rework find_idlest_group()")
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Mel Gorman <mgorman@techsingularity.net>
Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
Link: https://lore.kernel.org/r/20200218144534.4564-1-vincent.guittot@linaro.org
---
kernel/sched/fair.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index fcc968669aea..4b5d5e5e701e 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -8561,6 +8561,8 @@ static inline void update_sg_wakeup_stats(struct sched_domain *sd,
sgs->group_capacity = group->sgc->capacity;
+ sgs->group_weight = group->group_weight;
+
sgs->group_type = group_classify(sd->imbalance_pct, group, sgs);
/*
--
2.16.4
next prev parent reply other threads:[~2020-03-03 11:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 11:02 [PATCH 0/3] Accumulated fixes for Load/NUMA Balancing reconcilation series Mel Gorman
2020-03-03 11:02 ` Mel Gorman [this message]
2020-03-03 11:14 ` [PATCH 1/3] sched/fair: Fix statistics for find_idlest_group() Vincent Guittot
2020-03-03 11:44 ` Mel Gorman
2020-03-03 13:11 ` Vincent Guittot
2020-03-03 11:02 ` [PATCH 2/3] sched/fair: Fix kernel build warning in test_idle_cores() for !SMT NUMA Mel Gorman
2020-03-06 14:42 ` [tip: sched/core] " tip-bot2 for Valentin Schneider
2020-03-03 11:02 ` [PATCH 3/3] sched/numa: Acquire RCU lock when checking idle cores during NUMA balancing Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303110258.1092-2-mgorman@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=anshuman.khandual@arm.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=hdanton@sina.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mingo@kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=pauld@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.