From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 3 Mar 2020 11:37:17 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20200303113717.GD3170@work-vm> References: <20200227055927.24566-1-misono.tomohiro@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200227055927.24566-1-misono.tomohiro@jp.fujitsu.com> Subject: Re: [Virtio-fs] [PATCH v4 0/2] virtiofsd: Fix xattr operations List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Misono Tomohiro Cc: virtio-fs@redhat.com, qemu-devel@nongnu.org, vgoyal@redhat.com * Misono Tomohiro (misono.tomohiro@jp.fujitsu.com) wrote: > Currently xattr operations on virtiofs does not work properly in some case: > - directory ... cannot set > - special files (pipe) ... cause hang > > This fixes these problems and now xfstests generic/062 passes on virtiofs > with -o xattr option (I tested with xfs). > > v3 -> v4: > - No logic change > - Some code style fix/update comments and commit log as suggested by Vivek > - CC qemu-devel ML too > > Previous versions can be found in virtiofs ML: > v3: https://www.redhat.com/archives/virtio-fs/2020-February/msg00032.html > > Thanks, Thanks, Reviewed-by: Dr. David Alan Gilbert and queued. (I suspect there's some more cleanup involved in the error paths in those functions; I'll have a look another time). Dave > Misono Tomohiro (2): > virtiofsd: passthrough_ll: cleanup getxattr/listxattr > virtiofsd: Fix xattr operations > > tools/virtiofsd/fuse_virtio.c | 13 +++ > tools/virtiofsd/passthrough_ll.c | 139 ++++++++++++++++--------------- > tools/virtiofsd/seccomp.c | 6 ++ > 3 files changed, 89 insertions(+), 69 deletions(-) > > -- > 2.21.1 > > > _______________________________________________ > Virtio-fs mailing list > Virtio-fs@redhat.com > https://www.redhat.com/mailman/listinfo/virtio-fs -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK