From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: linux-sgx@vger.kernel.org
Subject: Re: [PATCH 2/2] x86/sgx: Remove non-LC bit from sgx_einit()
Date: Wed, 4 Mar 2020 01:12:30 +0200 [thread overview]
Message-ID: <20200303231230.GA709903@linux.intel.com> (raw)
In-Reply-To: <20200303223346.GD1439@linux.intel.com>
On Tue, Mar 03, 2020 at 02:33:46PM -0800, Sean Christopherson wrote:
> On Tue, Mar 03, 2020 at 10:53:59PM +0200, Jarkko Sakkinen wrote:
> > Remove the non-LC flow. While doing this, start using __encls_ret_3()
> > instead __einit() to reduce the insane amount of wrapping we have in
> > this flow.
>
> I strongly prefer keeping __einit(), I find it much more readable than
> __encls_ret_3(EINIT, ...). If you remove __einit() then I don't see the
> justification for keeping all the other wrappers, and for me, removing
> all of those would be a big step backwards.
Rather than arguing about this I'll merge only the part that removes
the LC flow.
/Jarkko
prev parent reply other threads:[~2020-03-03 23:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 20:53 [PATCH 1/2] x86/sgx: cleanup: Remove unused struct Jarkko Sakkinen
2020-03-03 20:53 ` [PATCH 2/2] x86/sgx: Remove non-LC bit from sgx_einit() Jarkko Sakkinen
2020-03-03 22:33 ` Sean Christopherson
2020-03-03 23:12 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303231230.GA709903@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=linux-sgx@vger.kernel.org \
--cc=sean.j.christopherson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.