From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F632C3F2CE for ; Wed, 4 Mar 2020 16:10:17 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC8DC215A4 for ; Wed, 4 Mar 2020 16:10:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="LCKbntdc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC8DC215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 39F711616; Wed, 4 Mar 2020 17:09:25 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 39F711616 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1583338215; bh=s3TF4WL3MaslzgAqaQFrV3WsMgeYgAAuiMDowInkXbI=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=LCKbntdc2Psd4+0he/Tq9NnVrkreEELWl7ouVN5TkBaphFm0WETj7O9/Ef/qL3v4S sfDtg2WJu35dh4spT5D55KuQ4pTDWWev3zK2WlUZQuVXAZX5P3B8VsyGxKCLjzVhXb 8rVMQFKaRwcinteyCMBxAv14vHgbmyMfoBxk1Xio= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 83B65F801EC; Wed, 4 Mar 2020 17:09:24 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D71C1F801ED; Wed, 4 Mar 2020 17:09:22 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by alsa1.perex.cz (Postfix) with ESMTP id 791D5F8011C for ; Wed, 4 Mar 2020 17:09:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 791D5F8011C Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5408031B; Wed, 4 Mar 2020 08:09:18 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C8AED3F6CF; Wed, 4 Mar 2020 08:09:17 -0800 (PST) Date: Wed, 4 Mar 2020 16:09:16 +0000 From: Mark Brown To: Jaroslav Kysela Subject: Re: 5.5.y - apply "ASoC: intel/skl/hda - export number of digital microphones via control components" Message-ID: <20200304160916.GC5646@sirena.org.uk> References: <147efa37-eb57-7f17-b9eb-84a9fe5ad475@perex.cz> <20200304154450.GB5646@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lMM8JwqTlfDpEaS6" Content-Disposition: inline In-Reply-To: X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Sasha Levin , Takashi Iwai , ALSA development , Pierre-louis Bossart , stable@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --lMM8JwqTlfDpEaS6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Mar 04, 2020 at 04:53:27PM +0100, Jaroslav Kysela wrote: > Dne 04. 03. 20 v 16:44 Mark Brown napsal(a): > > This looks more like a new feature than a bug fix and I've been trying > > to get the stable people to calm down with the backports, there's been > > *far* too many regressions introduced recently in just the x86 stuff > > found after the fact. Does this fix systems that used to work? > The released ALSA UCM does not work correctly for some platforms without > this information (the number of digital microphones is not identified > correctly). That's not the question I asked - have these platforms ever worked with older kernel versions? > The regression probability is really low for this one and we're using it in > Fedora kernels for months without issues (in this code). It's partly the principle of the thing, if it were just patches that had individually been identified as being good for stable by someone with some understanding of the code (like this one :/ ) that were being backported I'd be a lot less concerned but the automated selections are missing dependencies or other context and people are reporting problems with them so I'm inclined to push back on things. --lMM8JwqTlfDpEaS6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5f0qsACgkQJNaLcl1U h9BadQf+O1EQDc7YktVj1dC5/GTJz8ZI39rao4i3XGtN7dx08fwW2RXYC18WBt+x riZeag6zydhoqeV55meXCXfC2jLybdLPqmVmVaRd6nKm1oTeaounn0gs7ftCGkz4 gWcnYcKpOuDbKFRqY8BDZX9f0LwO0huWXRm8+AAaflC0504sJuIerJXZcX3feFmG e5ISl0zjH1CUYglUmhpDc/KCuEBF2V+o6zz54klclEgmGYlSJe3eC6JJOX3XrO/p N3Tp0rgUVpgF2bcskQtdDx8KeOyejo8wf8a7MV+fG9daHi0Wr4HPBsCcHSvd1OHy phspjKXc1sWogPFibsNvaF22PQWA0g== =1QQV -----END PGP SIGNATURE----- --lMM8JwqTlfDpEaS6-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF352C3F2D7 for ; Wed, 4 Mar 2020 16:09:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C777921739 for ; Wed, 4 Mar 2020 16:09:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583338159; bh=s3TF4WL3MaslzgAqaQFrV3WsMgeYgAAuiMDowInkXbI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=0NcTPWy7J/tfBpjZCJMgWRXD/08bxQ4Sv5opVF3Yzy5jiXIUynRB1OaweeC02kuRa ND2cKMkGHs6FYpCccaRaV1mbzAydpwYEihu+UybKr+azsz0vrDc2M3fdPGZIr2TgGe hEncMsQbi410grdsnIjFup4y2gdsBpY0WCcDIBTU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728432AbgCDQJT (ORCPT ); Wed, 4 Mar 2020 11:09:19 -0500 Received: from foss.arm.com ([217.140.110.172]:36288 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728278AbgCDQJT (ORCPT ); Wed, 4 Mar 2020 11:09:19 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5408031B; Wed, 4 Mar 2020 08:09:18 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C8AED3F6CF; Wed, 4 Mar 2020 08:09:17 -0800 (PST) Date: Wed, 4 Mar 2020 16:09:16 +0000 From: Mark Brown To: Jaroslav Kysela Cc: stable@vger.kernel.org, Sasha Levin , Pierre-louis Bossart , Takashi Iwai , ALSA development Subject: Re: 5.5.y - apply "ASoC: intel/skl/hda - export number of digital microphones via control components" Message-ID: <20200304160916.GC5646@sirena.org.uk> References: <147efa37-eb57-7f17-b9eb-84a9fe5ad475@perex.cz> <20200304154450.GB5646@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lMM8JwqTlfDpEaS6" Content-Disposition: inline In-Reply-To: X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org --lMM8JwqTlfDpEaS6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Mar 04, 2020 at 04:53:27PM +0100, Jaroslav Kysela wrote: > Dne 04. 03. 20 v 16:44 Mark Brown napsal(a): > > This looks more like a new feature than a bug fix and I've been trying > > to get the stable people to calm down with the backports, there's been > > *far* too many regressions introduced recently in just the x86 stuff > > found after the fact. Does this fix systems that used to work? > The released ALSA UCM does not work correctly for some platforms without > this information (the number of digital microphones is not identified > correctly). That's not the question I asked - have these platforms ever worked with older kernel versions? > The regression probability is really low for this one and we're using it in > Fedora kernels for months without issues (in this code). It's partly the principle of the thing, if it were just patches that had individually been identified as being good for stable by someone with some understanding of the code (like this one :/ ) that were being backported I'd be a lot less concerned but the automated selections are missing dependencies or other context and people are reporting problems with them so I'm inclined to push back on things. --lMM8JwqTlfDpEaS6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5f0qsACgkQJNaLcl1U h9BadQf+O1EQDc7YktVj1dC5/GTJz8ZI39rao4i3XGtN7dx08fwW2RXYC18WBt+x riZeag6zydhoqeV55meXCXfC2jLybdLPqmVmVaRd6nKm1oTeaounn0gs7ftCGkz4 gWcnYcKpOuDbKFRqY8BDZX9f0LwO0huWXRm8+AAaflC0504sJuIerJXZcX3feFmG e5ISl0zjH1CUYglUmhpDc/KCuEBF2V+o6zz54klclEgmGYlSJe3eC6JJOX3XrO/p N3Tp0rgUVpgF2bcskQtdDx8KeOyejo8wf8a7MV+fG9daHi0Wr4HPBsCcHSvd1OHy phspjKXc1sWogPFibsNvaF22PQWA0g== =1QQV -----END PGP SIGNATURE----- --lMM8JwqTlfDpEaS6--