All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Liran Alon <liran.alon@oracle.com>
Cc: pbonzini@redhat.com, Bhavesh Davda <bhavesh.davda@oracle.com>,
	qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [PATCH] configure: Fix pkg_config --exists parameter
Date: Wed, 4 Mar 2020 17:42:17 +0000	[thread overview]
Message-ID: <20200304174217.GI4104@work-vm> (raw)
In-Reply-To: <20200304174120.11970-1-liran.alon@oracle.com>

* Liran Alon (liran.alon@oracle.com) wrote:
> pkg_config parameter should be "--exists", not "--exist".
> This is probably a typo.
> 
> Fixes: 3a67848134d0 ("configure: Enable test and libs for zstd")
> Reviewed-by: Bhavesh Davda <bhavesh.davda@oracle.com>
> Signed-off-by: Liran Alon <liran.alon@oracle.com>

That's the same as 20200303124925.28079-1-dplotnikov@virtuozzo.com from
Denis yesterday.

Dave

> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 50c4d96e2a8c..280f3654f786 100755
> --- a/configure
> +++ b/configure
> @@ -2464,7 +2464,7 @@ fi
>  # zstd check
>  
>  if test "$zstd" != "no" ; then
> -    if $pkg_config --exist libzstd ; then
> +    if $pkg_config --exists libzstd ; then
>          zstd_cflags="$($pkg_config --cflags libzstd)"
>          zstd_libs="$($pkg_config --libs libzstd)"
>          LIBS="$zstd_libs $LIBS"
> -- 
> 2.20.1
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK



  reply	other threads:[~2020-03-04 17:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 17:41 [PATCH] configure: Fix pkg_config --exists parameter Liran Alon
2020-03-04 17:42 ` Dr. David Alan Gilbert [this message]
2020-03-04 19:05   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200304174217.GI4104@work-vm \
    --to=dgilbert@redhat.com \
    --cc=bhavesh.davda@oracle.com \
    --cc=liran.alon@oracle.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.