From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-block <linux-block@vger.kernel.org>,
dm-devel@redhat.com, Mikulas Patocka <mpatocka@redhat.com>,
Hou Tao <houtao1@huawei.com>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Alasdair G Kergon <agk@redhat.com>
Subject: Re: [dm-devel] [git pull] device mapper fixes for 5.6-rc5
Date: Wed, 4 Mar 2020 15:02:50 -0500 [thread overview]
Message-ID: <20200304200250.GE74069@mit.edu> (raw)
In-Reply-To: <20200304192335.GA24296@redhat.com>
On Wed, Mar 04, 2020 at 02:23:35PM -0500, Mike Snitzer wrote:
>
> These versions are for userspace's benefit (be it lvm2, cryptsetup,
> multipath-tools, etc). But yes, these versions are bogus even for
> that -- primarily because it requires userspace to know when a
> particular feature/fix it cares about was introduced. In addition: if
> fixes, that also bump version, are marked for stable@ then we're quickly
> in versioning hell -- which is why I always try to decouple version
> bumps from fixes.
>
> Others have suggested setting feature flags. I expect you'd hate those
> too. I suspect I quickly would too given flag bits are finite and
> really tedious to deal with.
>
> I'll think further about this issue and consult with userspace
> developers and see what we might do.
What I do for e2fsprogs is that it looks for the existence of files in
/sys/fs/ext4/features:
% ls /sys/fs/ext4/features/
total 0
0 batched_discard 0 encryption 0 meta_bg_resize 0 verity
0 casefold 0 lazy_itable_init 0 metadata_csum_seed
I started this because sometimes ext4 features get backported
(sometimes to ancient 3.18 kernels for Android, sigh, but also once or
twice for enterprise distro kernels), and so this relieves e2fsprogs
from testing kernel versions when deciding which defaults at mke2fs
time (for example).
- Ted
next prev parent reply other threads:[~2020-03-04 20:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 15:02 [git pull] device mapper fixes for 5.6-rc5 Mike Snitzer
2020-03-04 19:06 ` Linus Torvalds
2020-03-04 19:23 ` Mike Snitzer
2020-03-04 19:34 ` Linus Torvalds
2020-03-05 9:44 ` [dm-devel] " Zdenek Kabelac
2020-03-04 20:02 ` Theodore Y. Ts'o [this message]
2020-03-04 19:15 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304200250.GE74069@mit.edu \
--to=tytso@mit.edu \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=houtao1@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=shinichiro.kawasaki@wdc.com \
--cc=snitzer@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.