Re: [PATCH v2] ima: add a new CONFIG for loading arch-specific policies

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4665 bytes --]

Hi Nayna,

I love your patch! Yet something to improve:

[auto build test ERROR on integrity/next-integrity]
[also build test ERROR on powerpc/next s390/features linus/master v5.6-rc4]
[cannot apply to tip/x86/core next-20200304]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Nayna-Jain/ima-add-a-new-CONFIG-for-loading-arch-specific-policies/20200304-190747
base:   https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git next-integrity
config: x86_64-randconfig-s1-20200304 (attached as .config)
compiler: gcc-7 (Debian 7.5.0-5) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> arch/x86//kernel/ima_arch.c:54:6: error: redefinition of 'arch_ima_get_secureboot'
    bool arch_ima_get_secureboot(void)
         ^~~~~~~~~~~~~~~~~~~~~~~
   In file included from arch/x86//kernel/ima_arch.c:7:0:
   include/linux/ima.h:37:20: note: previous definition of 'arch_ima_get_secureboot' was here
    static inline bool arch_ima_get_secureboot(void)
                       ^~~~~~~~~~~~~~~~~~~~~~~
>> arch/x86//kernel/ima_arch.c:86:21: error: redefinition of 'arch_get_ima_policy'
    const char * const *arch_get_ima_policy(void)
                        ^~~~~~~~~~~~~~~~~~~
   In file included from arch/x86//kernel/ima_arch.c:7:0:
   include/linux/ima.h:42:35: note: previous definition of 'arch_get_ima_policy' was here
    static inline const char * const *arch_get_ima_policy(void)
                                      ^~~~~~~~~~~~~~~~~~~

vim +/arch_ima_get_secureboot +54 arch/x86//kernel/ima_arch.c

399574c64eaf94 Mimi Zohar   2018-11-18  53  
0914ade209c452 Nayna Jain   2018-10-09 @54  bool arch_ima_get_secureboot(void)
0914ade209c452 Nayna Jain   2018-10-09  55  {
399574c64eaf94 Mimi Zohar   2018-11-18  56  	static enum efi_secureboot_mode sb_mode;
399574c64eaf94 Mimi Zohar   2018-11-18  57  	static bool initialized;
399574c64eaf94 Mimi Zohar   2018-11-18  58  
399574c64eaf94 Mimi Zohar   2018-11-18  59  	if (!initialized && efi_enabled(EFI_BOOT)) {
399574c64eaf94 Mimi Zohar   2018-11-18  60  		sb_mode = boot_params.secure_boot;
399574c64eaf94 Mimi Zohar   2018-11-18  61  
399574c64eaf94 Mimi Zohar   2018-11-18  62  		if (sb_mode == efi_secureboot_mode_unset)
399574c64eaf94 Mimi Zohar   2018-11-18  63  			sb_mode = get_sb_mode();
399574c64eaf94 Mimi Zohar   2018-11-18  64  		initialized = true;
399574c64eaf94 Mimi Zohar   2018-11-18  65  	}
399574c64eaf94 Mimi Zohar   2018-11-18  66  
399574c64eaf94 Mimi Zohar   2018-11-18  67  	if (sb_mode == efi_secureboot_mode_enabled)
0914ade209c452 Nayna Jain   2018-10-09  68  		return true;
0914ade209c452 Nayna Jain   2018-10-09  69  	else
0914ade209c452 Nayna Jain   2018-10-09  70  		return false;
0914ade209c452 Nayna Jain   2018-10-09  71  }
d958083a8f6408 Eric Richter 2018-10-09  72  
d958083a8f6408 Eric Richter 2018-10-09  73  /* secureboot arch rules */
d958083a8f6408 Eric Richter 2018-10-09  74  static const char * const sb_arch_rules[] = {
99d5cadfde2b1a Jiri Bohac   2019-08-19  75  #if !IS_ENABLED(CONFIG_KEXEC_SIG)
d958083a8f6408 Eric Richter 2018-10-09  76  	"appraise func=KEXEC_KERNEL_CHECK appraise_type=imasig",
99d5cadfde2b1a Jiri Bohac   2019-08-19  77  #endif /* CONFIG_KEXEC_SIG */
d958083a8f6408 Eric Richter 2018-10-09  78  	"measure func=KEXEC_KERNEL_CHECK",
8db5da0b8618df Mimi Zohar   2019-01-27  79  #if !IS_ENABLED(CONFIG_MODULE_SIG)
8db5da0b8618df Mimi Zohar   2019-01-27  80  	"appraise func=MODULE_CHECK appraise_type=imasig",
8db5da0b8618df Mimi Zohar   2019-01-27  81  #endif
8db5da0b8618df Mimi Zohar   2019-01-27  82  	"measure func=MODULE_CHECK",
d958083a8f6408 Eric Richter 2018-10-09  83  	NULL
d958083a8f6408 Eric Richter 2018-10-09  84  };
d958083a8f6408 Eric Richter 2018-10-09  85  
d958083a8f6408 Eric Richter 2018-10-09 @86  const char * const *arch_get_ima_policy(void)

:::::: The code at line 54 was first introduced by commit
:::::: 0914ade209c452cff6a29b1c0ae6fff3167fa1d0 x86/ima: define arch_ima_get_secureboot

:::::: TO: Nayna Jain <nayna@linux.ibm.com>
:::::: CC: Mimi Zohar <zohar@linux.ibm.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34498 bytes --]