From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Rajeshwari <rkambl@codeaurora.org>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, sanm@codeaurora.org,
sivaa@codeaurora.org
Subject: Re: [PATCH 1/1] arm64: dts: qcom: sc7180: Added critical trip point Thermal-zones node
Date: Wed, 4 Mar 2020 21:19:27 -0800 [thread overview]
Message-ID: <20200305051927.GE857139@builder> (raw)
In-Reply-To: <1583324635-8271-2-git-send-email-rkambl@codeaurora.org>
On Wed 04 Mar 04:23 PST 2020, Rajeshwari wrote:
> To enable kernel critical shutdown feature added critical trip point to
s/added/add/
s/point/points/
> all non CPU sensors to perform shutdown in orderly manner.
>
> Signed-off-by: Rajeshwari <rkambl@codeaurora.org>
> ---
No need to provide a cover-letter for a single patch.
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 78 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 78 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index b8a72cf..7e5f14f 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1956,6 +1956,12 @@
> hysteresis = <2000>;
> type = "hot";
> };
> +
> + aoss0_crit: aoss0_crit {
> + temperature = <110000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
The indentation of all but the initial line is off. Same with below
hunks as well. Please correct this.
Regards,
Bjorn
next prev parent reply other threads:[~2020-03-05 5:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 12:23 [PATCH 0/1] Added critical trip point Thermal-zones node Rajeshwari
2020-03-04 12:23 ` [PATCH 1/1] arm64: dts: qcom: sc7180: " Rajeshwari
2020-03-05 5:19 ` Bjorn Andersson [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-03-05 7:49 [PATCH 0/1] " Rajeshwari
2020-03-05 7:49 ` [PATCH 1/1] arm64: dts: qcom: sc7180: " Rajeshwari
2020-03-05 12:59 ` Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305051927.GE857139@builder \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rkambl@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sanm@codeaurora.org \
--cc=sivaa@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.