All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@techsingularity.net>
To: lkp@lists.01.org
Subject: Re: [sched/numa] f6183ef98b: phoronix-test-suite.aom-av1.0.frames_per_second -25.0% regression
Date: Thu, 05 Mar 2020 10:12:57 +0000	[thread overview]
Message-ID: <20200305101257.GQ3818@techsingularity.net> (raw)
In-Reply-To: <20200305025822.GH5972@shao2-debian>

[-- Attachment #1: Type: text/plain, Size: 1523 bytes --]

On Thu, Mar 05, 2020 at 10:58:22AM +0800, Rong Chen wrote:
> Hi,
> 
> I tested on branch tip/sched/core, the regression is still there.
> 
> 
> =========================================================================================
> compiler/cpufreq_governor/kconfig/rootfs/tbox_group/test/testcase/ucode:
>   gcc-7/performance/x86_64-rhel-7.6/debian-x86_64-phoronix/lkp-nhm-2ep1/aom-av1-1.2.0/phoronix-test-suite/0x1d
> 
> commit: 
>   6d4d22468dae3d8757af9f8b81b848a76ef4409d ("sched/fair: Reorder enqueue/dequeue_task_fair path")
>   6499b1b2dd1b8d404a16b9fbbf1af6b9b3c1d83d ("sched/numa: Replace runnable_load_avg by load_avg")
>   253e2b69ef8fda4d9345ff496b12058faaeeff6b ("sched/fair: fix statistics for find_idlest_group()")
> 

Are you sure? I ask because tip/sched/core does not have the
patch "sched/fair: fix statistics for find_idlest_group" in it
nor is commit 253e2b69ef8fda4d9345ff496b12058faaeeff6b part of the
tip/sched/core history. You'd need to test the full series in the current
tip/sched/core with minimally 289de3598481 ("sched/fair: Fix statistics
for find_idlest_group()") from tip/sched/urgent on top. That's still
missing two fixes but one is a build issue and the other is a missing
rcu_read_lock that is unlikely to cause corruption unless there is a
hotplug event during the test.

Also, can you tell me more about the hardware? The stats indicate it's NUMA
but it only has 16 threads which seems very low for a modern NUMA machine.

-- 
Mel Gorman
SUSE Labs

  reply	other threads:[~2020-03-05 10:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26  1:32 [sched/numa] f6183ef98b: phoronix-test-suite.aom-av1.0.frames_per_second -25.0% regression kernel test robot
2020-02-26  8:03 ` Vincent Guittot
2020-02-26  8:33   ` Mel Gorman
2020-02-27  5:25     ` Rong Chen
2020-02-27  9:06       ` Mel Gorman
2020-03-05  2:58         ` Rong Chen
2020-03-05 10:12           ` Mel Gorman [this message]
2020-03-05 11:15             ` Chen, Rong A
2020-03-05 12:39               ` Mel Gorman
2020-03-18  8:43                 ` Rong Chen
2020-03-18 10:53                   ` Mel Gorman
2020-02-27  2:57   ` Rong Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200305101257.GQ3818@techsingularity.net \
    --to=mgorman@techsingularity.net \
    --cc=lkp@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.