From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [andersson-kernel:wip/sdm845-ipa-20200303 21/26] drivers/net//ipa/ipa_modem.c:315:64: error: parameter 2 ('event') has incomplete type
Date: Thu, 05 Mar 2020 13:21:44 +0800 [thread overview]
Message-ID: <202003051341.XB10p4OR%lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 15473 bytes --]
Hi Alex,
First bad commit (maybe != root cause):
tree: https://github.com/andersson/kernel wip/sdm845-ipa-20200303
head: 04ae10f45de49569b9f93efaa5a019b52ea2ccc5
commit: 4402cb49f3ec776610711605c19489b3a9ff0b80 [21/26] soc: qcom: ipa: support build of IPA code
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 4402cb49f3ec776610711605c19489b3a9ff0b80
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15:0,
from drivers/net//ipa/ipa_endpoint.c:8:
drivers/net//ipa/ipa_endpoint.c: In function 'ipa_endpoint_enable_one':
>> drivers/net//ipa/ipa_endpoint.c:1359:4: warning: format '%u' expects a matching 'unsigned int' argument [-Wformat=]
"error %d starting %cX channel %u for endpoint %u\n",
^
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
#define dev_fmt(fmt) fmt
^~~
>> drivers/net//ipa/ipa_endpoint.c:1358:3: note: in expansion of macro 'dev_err'
dev_err(&ipa->pdev->dev,
^~~~~~~
--
In file included from include/linux/bitops.h:5:0,
from include/linux/kernel.h:12,
from include/asm-generic/bug.h:19,
from arch/sh/include/asm/bug.h:112,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/current.h:5,
from ./arch/sh/include/generated/asm/current.h:1,
from include/linux/sched.h:12,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from drivers/net//ipa/ipa_cmd.c:8:
drivers/net//ipa/ipa_cmd.c: In function 'ipa_cmd_ip_tag_status_add':
>> include/linux/bits.h:23:11: warning: right shift count is negative [-Wshift-count-negative]
(~UL(0) >> (BITS_PER_LONG - 1 - (h))))
^
>> drivers/net//ipa/ipa_cmd.c:158:42: note: in expansion of macro 'GENMASK'
#define IP_PACKET_TAG_STATUS_TAG_FMASK GENMASK(63, 16)
^~~~~~~
>> drivers/net//ipa/ipa_cmd.c:605:38: note: in expansion of macro 'IP_PACKET_TAG_STATUS_TAG_FMASK'
payload->tag = u64_encode_bits(tag, IP_PACKET_TAG_STATUS_TAG_FMASK);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
>> drivers/net//ipa/ipa_modem.c:315:47: warning: 'enum qcom_rproc_event' declared inside parameter list will not be visible outside of this definition or declaration
static void ipa_modem_notify(void *data, enum qcom_rproc_event event)
^~~~~~~~~~~~~~~~
>> drivers/net//ipa/ipa_modem.c:315:64: error: parameter 2 ('event') has incomplete type
static void ipa_modem_notify(void *data, enum qcom_rproc_event event)
^~~~~
>> drivers/net//ipa/ipa_modem.c:315:13: error: function declaration isn't a prototype [-Werror=strict-prototypes]
static void ipa_modem_notify(void *data, enum qcom_rproc_event event)
^~~~~~~~~~~~~~~~
drivers/net//ipa/ipa_modem.c: In function 'ipa_modem_notify':
>> drivers/net//ipa/ipa_modem.c:322:7: error: 'MODEM_STARTING' undeclared (first use in this function); did you mean 'MOD_STATUS'?
case MODEM_STARTING:
^~~~~~~~~~~~~~
MOD_STATUS
drivers/net//ipa/ipa_modem.c:322:7: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/net//ipa/ipa_modem.c:327:7: error: 'MODEM_RUNNING' undeclared (first use in this function); did you mean 'SYSTEM_RUNNING'?
case MODEM_RUNNING:
^~~~~~~~~~~~~
SYSTEM_RUNNING
>> drivers/net//ipa/ipa_modem.c:331:7: error: 'MODEM_STOPPING' undeclared (first use in this function); did you mean 'MODEM_STARTING'?
case MODEM_STOPPING:
^~~~~~~~~~~~~~
MODEM_STARTING
>> drivers/net//ipa/ipa_modem.c:332:7: error: 'MODEM_CRASHED' undeclared (first use in this function); did you mean 'FMODE_CREATED'?
case MODEM_CRASHED:
^~~~~~~~~~~~~
FMODE_CREATED
>> drivers/net//ipa/ipa_modem.c:340:7: error: 'MODEM_OFFLINE' undeclared (first use in this function); did you mean 'KOBJ_OFFLINE'?
case MODEM_OFFLINE:
^~~~~~~~~~~~~
KOBJ_OFFLINE
>> drivers/net//ipa/ipa_modem.c:344:7: error: 'MODEM_REMOVING' undeclared (first use in this function); did you mean 'MODEM_RUNNING'?
case MODEM_REMOVING:
^~~~~~~~~~~~~~
MODEM_RUNNING
drivers/net//ipa/ipa_modem.c: In function 'ipa_modem_config':
>> drivers/net//ipa/ipa_modem.c:366:9: error: implicit declaration of function 'qcom_register_ipa_notify'; did you mean 'bus_register_notifier'? [-Werror=implicit-function-declaration]
return qcom_register_ipa_notify(ipa->modem_rproc, ipa_modem_notify,
^~~~~~~~~~~~~~~~~~~~~~~~
bus_register_notifier
drivers/net//ipa/ipa_modem.c: In function 'ipa_modem_deconfig':
>> drivers/net//ipa/ipa_modem.c:372:2: error: implicit declaration of function 'qcom_deregister_ipa_notify'; did you mean 'bus_unregister_notifier'? [-Werror=implicit-function-declaration]
qcom_deregister_ipa_notify(ipa->modem_rproc);
^~~~~~~~~~~~~~~~~~~~~~~~~~
bus_unregister_notifier
cc1: some warnings being treated as errors
--
In file included from include/linux/device.h:15:0,
from drivers/net//ipa/ipa_clock.c:10:
drivers/net//ipa/ipa_clock.c: In function 'ipa_interconnect_init_one':
>> drivers/net//ipa/ipa_clock.c:69:16: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long int' [-Wformat=]
dev_err(dev, "error %d getting memory interconnect\n",
^
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
#define dev_fmt(fmt) fmt
^~~
>> drivers/net//ipa/ipa_clock.c:69:3: note: in expansion of macro 'dev_err'
dev_err(dev, "error %d getting memory interconnect\n",
^~~~~~~
drivers/net//ipa/ipa_clock.c: In function 'ipa_clock_init':
drivers/net//ipa/ipa_clock.c:268:16: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long int' [-Wformat=]
dev_err(dev, "error %d getting core clock\n", PTR_ERR(clk));
^
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
#define dev_fmt(fmt) fmt
^~~
drivers/net//ipa/ipa_clock.c:268:3: note: in expansion of macro 'dev_err'
dev_err(dev, "error %d getting core clock\n", PTR_ERR(clk));
^~~~~~~
>> drivers/net//ipa/ipa_clock.c:274:16: warning: too many arguments for format [-Wformat-extra-args]
dev_err(dev, "error setting core clock rate to %u\n",
^
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
#define dev_fmt(fmt) fmt
^~~
drivers/net//ipa/ipa_clock.c:274:3: note: in expansion of macro 'dev_err'
dev_err(dev, "error setting core clock rate to %u\n",
^~~~~~~
--
drivers/net//ipa/gsi.c: In function 'gsi_evt_ring_program':
>> drivers/net//ipa/gsi.c:645:28: warning: right shift count >= width of type [-Wshift-count-overflow]
val = evt_ring->ring.addr >> 32;
^~
drivers/net//ipa/gsi.c: In function 'gsi_channel_program':
drivers/net//ipa/gsi.c:755:31: warning: right shift count >= width of type [-Wshift-count-overflow]
val = channel->tre_ring.addr >> 32;
^~
In file included from include/linux/device.h:15:0,
from include/linux/platform_device.h:13,
from drivers/net//ipa/gsi.c:15:
drivers/net//ipa/gsi.c: In function 'gsi_modem_channel_halt':
>> drivers/net//ipa/gsi.c:1563:21: warning: format '%u' expects a matching 'unsigned int' argument [-Wformat=]
dev_err(gsi->dev, "error %d halting modem channel %u\n",
^
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
#define dev_fmt(fmt) fmt
^~~
>> drivers/net//ipa/gsi.c:1563:3: note: in expansion of macro 'dev_err'
dev_err(gsi->dev, "error %d halting modem channel %u\n",
^~~~~~~
--
In file included from include/linux/device.h:15:0,
from include/linux/platform_device.h:13,
from drivers/net//ipa/gsi.h:13,
from drivers/net//ipa/gsi_trans.c:14:
drivers/net//ipa/gsi_trans.c: In function 'gsi_channel_trans_init':
>> drivers/net//ipa/gsi_trans.c:772:20: warning: format '%u' expects a matching 'unsigned int' argument [-Wformat=]
dev_err(gsi->dev, "error %d initializing channel %u transactions\n",
^
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
#define dev_fmt(fmt) fmt
^~~
>> drivers/net//ipa/gsi_trans.c:772:2: note: in expansion of macro 'dev_err'
dev_err(gsi->dev, "error %d initializing channel %u transactions\n",
^~~~~~~
--
In file included from include/linux/bitops.h:5:0,
from include/linux/kernel.h:12,
from include/asm-generic/bug.h:19,
from arch/sh/include/asm/bug.h:112,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/current.h:5,
from ./arch/sh/include/generated/asm/current.h:1,
from include/linux/sched.h:12,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from drivers/net/ipa/ipa_cmd.c:8:
drivers/net/ipa/ipa_cmd.c: In function 'ipa_cmd_ip_tag_status_add':
>> include/linux/bits.h:23:11: warning: right shift count is negative [-Wshift-count-negative]
(~UL(0) >> (BITS_PER_LONG - 1 - (h))))
^
drivers/net/ipa/ipa_cmd.c:158:42: note: in expansion of macro 'GENMASK'
#define IP_PACKET_TAG_STATUS_TAG_FMASK GENMASK(63, 16)
^~~~~~~
drivers/net/ipa/ipa_cmd.c:605:38: note: in expansion of macro 'IP_PACKET_TAG_STATUS_TAG_FMASK'
payload->tag = u64_encode_bits(tag, IP_PACKET_TAG_STATUS_TAG_FMASK);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +315 drivers/net//ipa/ipa_modem.c
3360c3a96b6dfb Alex Elder 2020-02-28 314
3360c3a96b6dfb Alex Elder 2020-02-28 @315 static void ipa_modem_notify(void *data, enum qcom_rproc_event event)
3360c3a96b6dfb Alex Elder 2020-02-28 316 {
3360c3a96b6dfb Alex Elder 2020-02-28 317 struct ipa *ipa = data;
3360c3a96b6dfb Alex Elder 2020-02-28 318 struct device *dev;
3360c3a96b6dfb Alex Elder 2020-02-28 319
3360c3a96b6dfb Alex Elder 2020-02-28 320 dev = &ipa->pdev->dev;
3360c3a96b6dfb Alex Elder 2020-02-28 321 switch (event) {
3360c3a96b6dfb Alex Elder 2020-02-28 @322 case MODEM_STARTING:
3360c3a96b6dfb Alex Elder 2020-02-28 323 dev_info(dev, "received modem starting event\n");
3360c3a96b6dfb Alex Elder 2020-02-28 324 ipa_smp2p_notify_reset(ipa);
3360c3a96b6dfb Alex Elder 2020-02-28 325 break;
3360c3a96b6dfb Alex Elder 2020-02-28 326
3360c3a96b6dfb Alex Elder 2020-02-28 @327 case MODEM_RUNNING:
3360c3a96b6dfb Alex Elder 2020-02-28 328 dev_info(dev, "received modem running event\n");
3360c3a96b6dfb Alex Elder 2020-02-28 329 break;
3360c3a96b6dfb Alex Elder 2020-02-28 330
3360c3a96b6dfb Alex Elder 2020-02-28 @331 case MODEM_STOPPING:
3360c3a96b6dfb Alex Elder 2020-02-28 @332 case MODEM_CRASHED:
3360c3a96b6dfb Alex Elder 2020-02-28 333 dev_info(dev, "received modem %s event\n",
3360c3a96b6dfb Alex Elder 2020-02-28 334 event == MODEM_STOPPING ? "stopping"
3360c3a96b6dfb Alex Elder 2020-02-28 335 : "crashed");
3360c3a96b6dfb Alex Elder 2020-02-28 336 if (ipa->setup_complete)
3360c3a96b6dfb Alex Elder 2020-02-28 337 ipa_modem_crashed(ipa);
3360c3a96b6dfb Alex Elder 2020-02-28 338 break;
3360c3a96b6dfb Alex Elder 2020-02-28 339
3360c3a96b6dfb Alex Elder 2020-02-28 @340 case MODEM_OFFLINE:
3360c3a96b6dfb Alex Elder 2020-02-28 341 dev_info(dev, "received modem offline event\n");
3360c3a96b6dfb Alex Elder 2020-02-28 342 break;
3360c3a96b6dfb Alex Elder 2020-02-28 343
3360c3a96b6dfb Alex Elder 2020-02-28 @344 case MODEM_REMOVING:
3360c3a96b6dfb Alex Elder 2020-02-28 345 dev_info(dev, "received modem stopping event\n");
3360c3a96b6dfb Alex Elder 2020-02-28 346 break;
3360c3a96b6dfb Alex Elder 2020-02-28 347
3360c3a96b6dfb Alex Elder 2020-02-28 348 default:
3360c3a96b6dfb Alex Elder 2020-02-28 349 dev_err(&ipa->pdev->dev, "unrecognized event %u\n", event);
3360c3a96b6dfb Alex Elder 2020-02-28 350 break;
3360c3a96b6dfb Alex Elder 2020-02-28 351 }
3360c3a96b6dfb Alex Elder 2020-02-28 352 }
3360c3a96b6dfb Alex Elder 2020-02-28 353
3360c3a96b6dfb Alex Elder 2020-02-28 354 int ipa_modem_init(struct ipa *ipa, bool modem_init)
3360c3a96b6dfb Alex Elder 2020-02-28 355 {
3360c3a96b6dfb Alex Elder 2020-02-28 356 return ipa_smp2p_init(ipa, modem_init);
3360c3a96b6dfb Alex Elder 2020-02-28 357 }
3360c3a96b6dfb Alex Elder 2020-02-28 358
3360c3a96b6dfb Alex Elder 2020-02-28 359 void ipa_modem_exit(struct ipa *ipa)
3360c3a96b6dfb Alex Elder 2020-02-28 360 {
3360c3a96b6dfb Alex Elder 2020-02-28 361 ipa_smp2p_exit(ipa);
3360c3a96b6dfb Alex Elder 2020-02-28 362 }
3360c3a96b6dfb Alex Elder 2020-02-28 363
3360c3a96b6dfb Alex Elder 2020-02-28 364 int ipa_modem_config(struct ipa *ipa)
3360c3a96b6dfb Alex Elder 2020-02-28 365 {
3360c3a96b6dfb Alex Elder 2020-02-28 @366 return qcom_register_ipa_notify(ipa->modem_rproc, ipa_modem_notify,
3360c3a96b6dfb Alex Elder 2020-02-28 367 ipa);
3360c3a96b6dfb Alex Elder 2020-02-28 368 }
3360c3a96b6dfb Alex Elder 2020-02-28 369
3360c3a96b6dfb Alex Elder 2020-02-28 370 void ipa_modem_deconfig(struct ipa *ipa)
3360c3a96b6dfb Alex Elder 2020-02-28 371 {
3360c3a96b6dfb Alex Elder 2020-02-28 @372 qcom_deregister_ipa_notify(ipa->modem_rproc);
3360c3a96b6dfb Alex Elder 2020-02-28 373 }
3360c3a96b6dfb Alex Elder 2020-02-28 374
:::::: The code at line 315 was first introduced by commit
:::::: 3360c3a96b6dfb11e309a1ad88570c768ed6e540 soc: qcom: ipa: modem and microcontroller
:::::: TO: Alex Elder <elder@linaro.org>
:::::: CC: Bjorn Andersson <bjorn.andersson@linaro.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 54037 bytes --]
reply other threads:[~2020-03-05 5:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202003051341.XB10p4OR%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.