From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Tommi Rantala <tommi.t.rantala@nokia.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Darren Hart <dvhart@infradead.org>,
Changbin Du <changbin.du@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] perf bench: Clear struct sigaction before sigaction() syscall
Date: Thu, 5 Mar 2020 11:53:04 -0300 [thread overview]
Message-ID: <20200305145304.GC7895@kernel.org> (raw)
In-Reply-To: <20200305083714.9381-4-tommi.t.rantala@nokia.com>
Em Thu, Mar 05, 2020 at 10:37:14AM +0200, Tommi Rantala escreveu:
> Avoid garbage in sigaction structs used in sigaction() syscalls.
> Valgrind is complaining about it.
Thanks, applied.
- Arnaldo
> Signed-off-by: Tommi Rantala <tommi.t.rantala@nokia.com>
> ---
> tools/perf/bench/epoll-ctl.c | 1 +
> tools/perf/bench/epoll-wait.c | 1 +
> tools/perf/bench/futex-hash.c | 1 +
> tools/perf/bench/futex-lock-pi.c | 1 +
> tools/perf/bench/futex-requeue.c | 1 +
> tools/perf/bench/futex-wake-parallel.c | 1 +
> tools/perf/bench/futex-wake.c | 1 +
> 7 files changed, 7 insertions(+)
>
> diff --git a/tools/perf/bench/epoll-ctl.c b/tools/perf/bench/epoll-ctl.c
> index bb617e5688412..63e2520017d81 100644
> --- a/tools/perf/bench/epoll-ctl.c
> +++ b/tools/perf/bench/epoll-ctl.c
> @@ -313,6 +313,7 @@ int bench_epoll_ctl(int argc, const char **argv)
> exit(EXIT_FAILURE);
> }
>
> + memset(&act, 0, sizeof(act));
> sigfillset(&act.sa_mask);
> act.sa_sigaction = toggle_done;
> sigaction(SIGINT, &act, NULL);
> diff --git a/tools/perf/bench/epoll-wait.c b/tools/perf/bench/epoll-wait.c
> index 7af694437f4ea..5336e628b404c 100644
> --- a/tools/perf/bench/epoll-wait.c
> +++ b/tools/perf/bench/epoll-wait.c
> @@ -427,6 +427,7 @@ int bench_epoll_wait(int argc, const char **argv)
> exit(EXIT_FAILURE);
> }
>
> + memset(&act, 0, sizeof(act));
> sigfillset(&act.sa_mask);
> act.sa_sigaction = toggle_done;
> sigaction(SIGINT, &act, NULL);
> diff --git a/tools/perf/bench/futex-hash.c b/tools/perf/bench/futex-hash.c
> index 8ba0c3330a9a2..c441aa446c7f8 100644
> --- a/tools/perf/bench/futex-hash.c
> +++ b/tools/perf/bench/futex-hash.c
> @@ -137,6 +137,7 @@ int bench_futex_hash(int argc, const char **argv)
> if (!cpu)
> goto errmem;
>
> + memset(&act, 0, sizeof(act));
> sigfillset(&act.sa_mask);
> act.sa_sigaction = toggle_done;
> sigaction(SIGINT, &act, NULL);
> diff --git a/tools/perf/bench/futex-lock-pi.c b/tools/perf/bench/futex-lock-pi.c
> index d0cae8125423f..27c6e1944cbed 100644
> --- a/tools/perf/bench/futex-lock-pi.c
> +++ b/tools/perf/bench/futex-lock-pi.c
> @@ -161,6 +161,7 @@ int bench_futex_lock_pi(int argc, const char **argv)
> if (!cpu)
> err(EXIT_FAILURE, "calloc");
>
> + memset(&act, 0, sizeof(act));
> sigfillset(&act.sa_mask);
> act.sa_sigaction = toggle_done;
> sigaction(SIGINT, &act, NULL);
> diff --git a/tools/perf/bench/futex-requeue.c b/tools/perf/bench/futex-requeue.c
> index a00a6891447ab..7a15c2e610228 100644
> --- a/tools/perf/bench/futex-requeue.c
> +++ b/tools/perf/bench/futex-requeue.c
> @@ -128,6 +128,7 @@ int bench_futex_requeue(int argc, const char **argv)
> if (!cpu)
> err(EXIT_FAILURE, "cpu_map__new");
>
> + memset(&act, 0, sizeof(act));
> sigfillset(&act.sa_mask);
> act.sa_sigaction = toggle_done;
> sigaction(SIGINT, &act, NULL);
> diff --git a/tools/perf/bench/futex-wake-parallel.c b/tools/perf/bench/futex-wake-parallel.c
> index a053cf2b70397..cd2b81a845acb 100644
> --- a/tools/perf/bench/futex-wake-parallel.c
> +++ b/tools/perf/bench/futex-wake-parallel.c
> @@ -234,6 +234,7 @@ int bench_futex_wake_parallel(int argc, const char **argv)
> exit(EXIT_FAILURE);
> }
>
> + memset(&act, 0, sizeof(act));
> sigfillset(&act.sa_mask);
> act.sa_sigaction = toggle_done;
> sigaction(SIGINT, &act, NULL);
> diff --git a/tools/perf/bench/futex-wake.c b/tools/perf/bench/futex-wake.c
> index 58906e9499bb0..2dfcef3e371e4 100644
> --- a/tools/perf/bench/futex-wake.c
> +++ b/tools/perf/bench/futex-wake.c
> @@ -136,6 +136,7 @@ int bench_futex_wake(int argc, const char **argv)
> if (!cpu)
> err(EXIT_FAILURE, "calloc");
>
> + memset(&act, 0, sizeof(act));
> sigfillset(&act.sa_mask);
> act.sa_sigaction = toggle_done;
> sigaction(SIGINT, &act, NULL);
> --
> 2.21.1
>
--
- Arnaldo
next prev parent reply other threads:[~2020-03-05 14:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200305083714.9381-1-tommi.t.rantala@nokia.com>
2020-03-05 8:37 ` [PATCH 1/3] perf top: Fix stdio interface input handling with glibc 2.28+ Tommi Rantala
2020-03-05 14:49 ` Arnaldo Carvalho de Melo
2020-03-06 7:47 ` Rantala, Tommi T. (Nokia - FI/Espoo)
2020-03-07 7:36 ` [tip: perf/urgent] " tip-bot2 for Tommi Rantala
2020-03-05 8:37 ` [PATCH 2/3] perf bench futex-wake: Restore thread count default to online CPU count Tommi Rantala
2020-03-05 14:51 ` Arnaldo Carvalho de Melo
2020-03-05 15:34 ` Davidlohr Bueso
2020-03-05 18:14 ` Arnaldo Melo
2020-03-07 7:36 ` [tip: perf/urgent] " tip-bot2 for Tommi Rantala
2020-03-05 8:37 ` [PATCH 3/3] perf bench: Clear struct sigaction before sigaction() syscall Tommi Rantala
2020-03-05 14:53 ` Arnaldo Carvalho de Melo [this message]
2020-03-07 7:36 ` [tip: perf/urgent] " tip-bot2 for Tommi Rantala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305145304.GC7895@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=changbin.du@intel.com \
--cc=dvhart@infradead.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tommi.t.rantala@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.