From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 03/11] xfs: refactor and split xfs_log_done()
Date: Thu, 5 Mar 2020 07:20:13 -0800 [thread overview]
Message-ID: <20200305152013.GC8974@infradead.org> (raw)
In-Reply-To: <20200304212818.GA10776@dread.disaster.area>
On Thu, Mar 05, 2020 at 08:28:18AM +1100, Dave Chinner wrote:
> On Wed, Mar 04, 2020 at 07:49:55AM -0800, Christoph Hellwig wrote:
> > > +int
> > > +xlog_write_done(
> > > + struct xlog *log,
> > > struct xlog_ticket *ticket,
> > > struct xlog_in_core **iclog,
> > > + xfs_lsn_t *lsn)
> > > {
> > > + if (XLOG_FORCED_SHUTDOWN(log))
> > > + return -EIO;
> > >
> > > + return xlog_commit_record(log, ticket, iclog, lsn);
> > > +}
> >
> > Can we just move the XLOG_FORCED_SHUTDOWN check into xlog_commit_record
> > and call xlog_commit_record directly?
>
> Next patch, because merging isn't obvious until the split is done.
Can you please at least avoid moving the code around in the next
patch then? With the function now non-static there shouldn't really
be any reason to move it.
next prev parent reply other threads:[~2020-03-05 15:20 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 7:53 [PATCH 00/11] xfs: clean up log tickets and record writes Dave Chinner
2020-03-04 7:53 ` [PATCH 01/11] xfs: don't try to write a start record into every iclog Dave Chinner
2020-03-04 15:44 ` Christoph Hellwig
2020-03-04 21:26 ` Dave Chinner
2020-03-05 15:19 ` Christoph Hellwig
2020-03-05 18:05 ` Brian Foster
2020-03-04 7:53 ` [PATCH 02/11] xfs: re-order initial space accounting checks in xlog_write Dave Chinner
2020-03-05 18:05 ` Brian Foster
2020-03-04 7:53 ` [PATCH 03/11] xfs: refactor and split xfs_log_done() Dave Chinner
2020-03-04 15:49 ` Christoph Hellwig
2020-03-04 21:28 ` Dave Chinner
2020-03-05 15:20 ` Christoph Hellwig [this message]
2020-03-05 18:06 ` Brian Foster
2020-03-24 12:37 ` Christoph Hellwig
2020-03-04 7:53 ` [PATCH 04/11] xfs: merge xlog_commit_record with xlog_write_done() Dave Chinner
2020-03-04 15:50 ` Christoph Hellwig
2020-03-05 18:06 ` Brian Foster
2020-03-04 7:53 ` [PATCH 05/11] xfs: factor out unmount record writing Dave Chinner
2020-03-04 15:51 ` Christoph Hellwig
2020-03-05 18:07 ` Brian Foster
2020-03-04 7:53 ` [PATCH 06/11] xfs: move xlog_state_ioerror() Dave Chinner
2020-03-04 15:51 ` Christoph Hellwig
2020-03-04 21:41 ` Dave Chinner
2020-03-05 15:21 ` Christoph Hellwig
2020-03-05 18:07 ` Brian Foster
2020-03-04 7:53 ` [PATCH 07/11] xfs: clean up xlog_state_ioerror() Dave Chinner
2020-03-05 18:07 ` Brian Foster
2020-03-04 7:53 ` [PATCH 08/11] xfs: rename the log unmount writing functions Dave Chinner
2020-03-04 15:52 ` Christoph Hellwig
2020-03-05 18:07 ` Brian Foster
2020-03-04 7:53 ` [PATCH 09/11] xfs: merge unmount record write iclog cleanup Dave Chinner
2020-03-04 15:53 ` Christoph Hellwig
2020-03-04 21:38 ` Dave Chinner
2020-03-05 15:27 ` Christoph Hellwig
2020-03-05 18:08 ` Brian Foster
2020-03-04 7:54 ` [PATCH 10/11] xfs: remove some stale comments from the log code Dave Chinner
2020-03-04 15:53 ` Christoph Hellwig
2020-03-05 18:08 ` Brian Foster
2020-03-04 7:54 ` [PATCH 11/11] xfs: kill XLOG_TIC_INITED Dave Chinner
2020-03-04 15:54 ` Christoph Hellwig
2020-03-05 18:08 ` Brian Foster
2020-03-05 16:05 ` [PATCH 00/11] xfs: clean up log tickets and record writes Christoph Hellwig
2020-03-05 21:42 ` Dave Chinner
2020-03-06 1:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305152013.GC8974@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.