From: Christoph Hellwig <hch@lst.de>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Christoph Hellwig <hch@lst.de>, Haibo Chen <haibo.chen@nxp.com>,
Arnd Bergmann <arnd@arndb.de>,
Adrian Hunter <adrian.hunter@intel.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v4 14/14] mmc: queue: create dev->dma_parms before call dma_set_max_seg_size()
Date: Thu, 5 Mar 2020 16:22:45 +0100 [thread overview]
Message-ID: <20200305152245.GB4870@lst.de> (raw)
In-Reply-To: <CAPDyKFrkwbr1n_Se+gEA3uSH+aEPawN0qLQBjppjg4y_K4-w=w@mail.gmail.com>
On Thu, Mar 05, 2020 at 11:52:04AM +0100, Ulf Hansson wrote:
> > It really is not the job of the upper level driver to allocate the
> > dma params. This should be done by the bus driver.
>
> I agree that allocating the dma_parms doesn't belong in the mmc block
> queue layer.
>
> However, it seems silly that each an every mmc host driver needs to do
> this themselves. So, perhaps we could manage this from
> mmc_alloc_host(), which is a common interface that mmc host drivers
> calls during initialization.
Neither mmc drivers nor the mmc core should allocate dma_params ever.
This should be once in their bus providers.
next prev parent reply other threads:[~2020-03-05 15:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 8:25 [PATCH v4 06/14] mmc: sdhci-esdhc-imx: add strobe-dll-delay-target support haibo.chen
2020-02-19 8:25 ` [PATCH v4 07/14] mmc: sdhci-esdhc-imx: optimize the clock setting haibo.chen
2020-02-19 8:25 ` [PATCH v4 08/14] mmc: sdhci-esdhc-imx: optimize the strobe dll setting haibo.chen
2020-02-19 8:25 ` [PATCH v4 09/14] mmc: sdhci-esdhc-imx: add flag ESDHC_FLAG_BROKEN_AUTO_CMD23 haibo.chen
2020-02-19 8:25 ` [PATCH v4 10/14] mmc: sdhci-esdhc-imx: Add an new esdhc_soc_data for i.MX8MM haibo.chen
2020-02-19 8:25 ` [PATCH v4 11/14] mmc: sdhci-esdhc-imx: clear pending interrupt and halt cqhci haibo.chen
2020-02-19 8:25 ` [PATCH v4 12/14] mmc: sdhci-esdhc-imx: clear DMA_SEL when disable DMA mode haibo.chen
2020-02-19 8:25 ` [PATCH v4 13/14] mmc: sdhci-esdhc-imx: restore pin state when resume back haibo.chen
2020-02-19 8:25 ` [PATCH v4 14/14] mmc: queue: create dev->dma_parms before call dma_set_max_seg_size() haibo.chen
2020-03-04 13:32 ` Ulf Hansson
2020-03-04 16:28 ` Christoph Hellwig
2020-03-05 10:52 ` Ulf Hansson
2020-03-05 15:22 ` Christoph Hellwig [this message]
2020-03-05 14:29 ` Linus Walleij
2020-03-05 14:45 ` Arnd Bergmann
2020-03-05 15:03 ` Linus Walleij
2020-03-05 15:31 ` Arnd Bergmann
2020-03-05 15:23 ` Christoph Hellwig
2020-03-06 14:02 ` Ulf Hansson
2020-03-06 14:19 ` Christoph Hellwig
2020-03-11 9:31 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305152245.GB4870@lst.de \
--to=hch@lst.de \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=haibo.chen@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-imx@nxp.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.