From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2, 1/1] package/jpeg-turbo: fix build with SIMD
Date: Thu, 5 Mar 2020 18:54:07 +0100 [thread overview]
Message-ID: <20200305175407.GJ5357@scaer> (raw)
In-Reply-To: <20200211204034.266999-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2020-02-11 21:40 +0100, Fabrice Fontaine spake thusly:
> Add -fPIC as requested by upstream in
> https://github.com/libjpeg-turbo/libjpeg-turbo/pull/366
The comment from upstream does not seem entirely correct, as I can
understand...
> Fixes:
> - http://autobuild.buildroot.org/results/5b7ce0a8f8d1f485bd7104ac2b40257bb17b284b
I was unable to reproduce this build failure on current master...
It seems that 37f3d09d46a (package/jpeg-turbo: force fPIC for shared
libraries) fixed it in a different manner (I reverted said commit, and
got the faillure back).
Regards,
Yann E. MORIN.
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2:
> - Fix typo in title: without -> with
>
> package/jpeg-turbo/jpeg-turbo.mk | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/package/jpeg-turbo/jpeg-turbo.mk b/package/jpeg-turbo/jpeg-turbo.mk
> index 2767ce6de4..1d24406e0f 100644
> --- a/package/jpeg-turbo/jpeg-turbo.mk
> +++ b/package/jpeg-turbo/jpeg-turbo.mk
> @@ -13,7 +13,9 @@ JPEG_TURBO_INSTALL_STAGING = YES
> JPEG_TURBO_PROVIDES = jpeg
> JPEG_TURBO_DEPENDENCIES = host-pkgconf
>
> -JPEG_TURBO_CONF_OPTS = -DWITH_JPEG8=ON
> +JPEG_TURBO_CONF_OPTS = \
> + -DCMAKE_C_FLAGS="$(TARGET_CFLAGS) -fPIC" \
> + -DWITH_JPEG8=ON
>
> ifeq ($(BR2_STATIC_LIBS),y)
> JPEG_TURBO_CONF_OPTS += -DENABLE_STATIC=ON -DENABLE_SHARED=OFF
> --
> 2.24.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2020-03-05 17:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 20:40 [Buildroot] [PATCH v2, 1/1] package/jpeg-turbo: fix build with SIMD Fabrice Fontaine
2020-03-05 17:54 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305175407.GJ5357@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.