From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2146615871494868065==" MIME-Version: 1.0 From: Peter Zijlstra To: kbuild-all@lists.01.org Subject: Re: [peterz-queue:core/rcu 31/33] arch/x86/kernel/alternative.c:961:26: error: inlining failed in call to always_inline 'try_get_desc': function attribute mismatch Date: Thu, 05 Mar 2020 19:47:27 +0100 Message-ID: <20200305184727.GA3348@worktop.programming.kicks-ass.net> In-Reply-To: List-Id: --===============2146615871494868065== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Thu, Mar 05, 2020 at 05:29:27PM +0100, Dmitry Vyukov wrote: > On Thu, Mar 5, 2020 at 4:55 PM Peter Zijlstra wr= ote: > > > > On Thu, Mar 05, 2020 at 04:23:11PM +0100, Dmitry Vyukov wrote: > > > Compilers just don't allow this: asking to inline sanitized function > > > into a non-sanitized function. But I don't know the ptrace/alternative > > > code good enough to suggest the right alternative (don't call > > > user_mode, copy user_mode, or something else). > > > > Does it work if we inline into a .c file and build it with: > > > > KASAN_SANITIZE :=3D n > > UBSAN_SANITIZE :=3D n > > KCOV_INSTRUMENT :=3D n > > > > Which would be effectively the very same, just more cumbersome. > = > I think it should work, because then user_mode will also not be instrumen= ted. Right, but then I have to ask how this is different vs inlining things into a __no_sanitize function. Anyway, I'll go move code around so we can do this.. --===============2146615871494868065==--