From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Eric Whitney <enwlinux@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: clean up error return for convert_initialized_extent()
Date: Thu, 5 Mar 2020 20:28:59 -0500 [thread overview]
Message-ID: <20200306012859.GK20967@mit.edu> (raw)
In-Reply-To: <20200218202656.21561-1-enwlinux@gmail.com>
On Tue, Feb 18, 2020 at 03:26:56PM -0500, Eric Whitney wrote:
> Although convert_initialized_extent() can potentially return an error
> code with a negative value, its returned value is assigned to an
> unsigned variable containing a block count in ext4_ext_map_blocks() and
> then returned to that function's caller. The code currently works,
> though the way this happens is obscure. The code would be more
> readable if it followed the error handling convention used elsewhere
> in ext4_ext_map_blocks().
>
> This patch does not address any known test failure or bug report - it's
> simply a cleanup. It also addresses a nearby coding standard issue.
>
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2020-03-06 1:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 20:26 [PATCH] ext4: clean up error return for convert_initialized_extent() Eric Whitney
2020-03-06 1:28 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306012859.GK20967@mit.edu \
--to=tytso@mit.edu \
--cc=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.