From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] Revert "thunderbolt: Prevent crash if non-active NVMem file is read"
Date: Fri, 6 Mar 2020 07:34:55 +0200 [thread overview]
Message-ID: <20200306053455.GY2540@lahna.fi.intel.com> (raw)
In-Reply-To: <101ca1ac-c3d3-6685-e21b-4c519346b67f@linaro.org>
On Thu, Mar 05, 2020 at 05:05:47PM +0000, Srinivas Kandagatla wrote:
>
>
> On 04/03/2020 16:18, Mika Westerberg wrote:
> > On Wed, Mar 04, 2020 at 04:07:29PM +0000, Nicholas Johnson wrote:
> > > On Tue, Mar 03, 2020 at 12:33:10PM +0200, Mika Westerberg wrote:
> > > > On Mon, Mar 02, 2020 at 03:43:29PM +0000, Nicholas Johnson wrote:
> > > > > This reverts commit 03cd45d2e219301880cabc357e3cf478a500080f.
> > > > >
> > > > > Since NVMEM subsystem gained support for write-only instances, this
> > > > > workaround is no longer required, so drop it.
> > > > >
> > > > > Signed-off-by: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
> > > >
> > > > Assuming this goes through The NVMem tree:
> > > >
> > > > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > > >
> > > > If that's not the case, please let me know. I can also take them through
> > > > the Thunderbolt tree.
> > > I do not know how this would normally work - I have not experienced much
> > > cross-subsystem work. Perhaps it should be taken through your tree. If
> > > it goes through your tree and not part of this series, perhaps it does
> > > not make sense for it to be authored by me, either. It's just a revert;
> > > it does not take a lot of effort or doing something original.
> >
> > Your authorship is fine.
> >
> > Since this patch depends on the first one, it should go together with
> > that one either to NVMem tree or Thunderbolt tree. Either is fine by me
> > but if I take them then I need an ack from Srinivas.
> >
>
> I applied 2/3 patch which should show up in next 5.7-rc1 release, with that
> in place you can revert this patch. Please take this patch via respective
> tree, it does not make much sense for me to apply this as its not going to
> break any build.
OK, that works for me as well.
Nicholas, can you send this one again after 5.7-rc1 is is released? I
can then pick it up to my tree.
prev parent reply other threads:[~2020-03-06 5:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 15:41 [PATCH v2 0/3] nvmem: Add support for write-only instances, and clean-up Nicholas Johnson
2020-03-02 15:42 ` [PATCH v2 1/3] nvmem: Add support for write-only instances Nicholas Johnson
2020-03-05 17:03 ` Srinivas Kandagatla
2020-03-05 18:11 ` Nicholas Johnson
2020-03-05 18:22 ` Srinivas Kandagatla
2020-03-02 15:43 ` [PATCH v2 2/3] nvmem: check for NULL reg_read and reg_write before dereferencing Nicholas Johnson
2020-03-03 10:29 ` Mika Westerberg
2020-03-04 16:03 ` Nicholas Johnson
2020-03-05 17:03 ` Srinivas Kandagatla
2020-03-02 15:43 ` [PATCH v2 3/3] Revert "thunderbolt: Prevent crash if non-active NVMem file is read" Nicholas Johnson
2020-03-03 10:33 ` Mika Westerberg
2020-03-04 16:07 ` Nicholas Johnson
2020-03-04 16:18 ` Mika Westerberg
2020-03-05 17:05 ` Srinivas Kandagatla
2020-03-06 5:34 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306053455.GY2540@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicholas.johnson-opensource@outlook.com.au \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.