From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>,
Thomas Richter <tmricht@linux.vnet.ibm.com>
Cc: Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Igor Lubashev <ilubashe@akamai.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Alexios Zavras <alexios.zavras@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Wei Li <liwei391@huawei.com>,
Kan Liang <kan.liang@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 3/3] tools/perf: build fixes for arch_errno_names.sh
Date: Fri, 6 Mar 2020 08:40:54 -0300 [thread overview]
Message-ID: <20200306114054.GB27494@kernel.org> (raw)
In-Reply-To: <20200306071110.130202-4-irogers@google.com>
Em Thu, Mar 05, 2020 at 11:11:10PM -0800, Ian Rogers escreveu:
> Allow the CC compiler to accept a CFLAGS environment variable.
> Make the architecture test directory agree with the code comment.
> This doesn't change the code generated but makes it easier to integrate
> running the shell script in build systems like bazel.
Hendrik and Thomas, can you please take a look at this and provide a
Reviewed-by tag?
Thanks,
- Arnaldo
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/trace/beauty/arch_errno_names.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/trace/beauty/arch_errno_names.sh b/tools/perf/trace/beauty/arch_errno_names.sh
> index 22c9fc900c84..9f9ea45cddc4 100755
> --- a/tools/perf/trace/beauty/arch_errno_names.sh
> +++ b/tools/perf/trace/beauty/arch_errno_names.sh
> @@ -57,7 +57,7 @@ process_arch()
> local arch="$1"
> local asm_errno=$(asm_errno_file "$arch")
>
> - $gcc $include_path -E -dM -x c $asm_errno \
> + $gcc $CFLAGS $include_path -E -dM -x c $asm_errno \
> |grep -hE '^#define[[:blank:]]+(E[^[:blank:]]+)[[:blank:]]+([[:digit:]]+).*' \
> |awk '{ print $2","$3; }' \
> |sort -t, -k2 -nu \
> @@ -91,7 +91,7 @@ EoHEADER
> # in tools/perf/arch
> archlist=""
> for arch in $(find $toolsdir/arch -maxdepth 1 -mindepth 1 -type d -printf "%f\n" | grep -v x86 | sort); do
> - test -d arch/$arch && archlist="$archlist $arch"
> + test -d $toolsdir/perf/arch/$arch && archlist="$archlist $arch"
> done
>
> for arch in x86 $archlist generic; do
> --
> 2.25.1.481.gfbce0eb801-goog
>
--
- Arnaldo
next prev parent reply other threads:[~2020-03-06 11:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 7:11 [PATCH 0/3] perf tool: build related fixes Ian Rogers
2020-03-06 7:11 ` [PATCH 1/3] tools: fix off-by 1 relative directory includes Ian Rogers
2020-03-06 9:33 ` Jiri Olsa
2020-03-06 16:47 ` Ian Rogers
2020-03-06 20:13 ` Arnaldo Carvalho de Melo
2020-03-06 11:41 ` Arnaldo Carvalho de Melo
2020-03-07 7:36 ` [tip: perf/urgent] tools: Fix " tip-bot2 for Ian Rogers
2020-03-06 7:11 ` [PATCH 2/3] libperf: avoid redefining _GNU_SOURCE in test Ian Rogers
2020-03-06 11:38 ` Arnaldo Carvalho de Melo
2020-03-06 17:54 ` Ian Rogers
2020-03-06 7:11 ` [PATCH 3/3] tools/perf: build fixes for arch_errno_names.sh Ian Rogers
2020-03-06 11:40 ` Arnaldo Carvalho de Melo [this message]
2020-04-29 19:16 ` Ian Rogers
2020-05-14 15:04 ` Arnaldo Carvalho de Melo
2020-05-14 17:54 ` Ian Rogers
2020-05-15 13:50 ` Arnaldo Carvalho de Melo
2020-03-06 9:35 ` [PATCH 0/3] perf tool: build related fixes Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306114054.GB27494@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexios.zavras@intel.com \
--cc=brueckner@linux.vnet.ibm.com \
--cc=eranian@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilubashe@akamai.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tmricht@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.