From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C95DCC10DCE for ; Fri, 6 Mar 2020 12:48:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A26972084E for ; Fri, 6 Mar 2020 12:48:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726378AbgCFMsS (ORCPT ); Fri, 6 Mar 2020 07:48:18 -0500 Received: from elvis.franken.de ([193.175.24.41]:53419 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726108AbgCFMsS (ORCPT ); Fri, 6 Mar 2020 07:48:18 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jACOl-0004Q9-00; Fri, 06 Mar 2020 13:48:15 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id A1D50C0F47; Fri, 6 Mar 2020 13:47:55 +0100 (CET) Date: Fri, 6 Mar 2020 13:47:55 +0100 From: Thomas Bogendoerfer To: afzal mohammed Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ralf Baechle , Paul Burton , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, "Maciej W. Rozycki" , Jiaxun Yang , Keguang Zhang , Huacai Chen , John Crispin Subject: Re: [PATCH v4] MIPS: Replace setup_irq() by request_irq() Message-ID: <20200306124755.GA10251@alpha.franken.de> References: <20200304203144.GA4323@alpha.franken.de> <20200305115759.3186-1-afzal.mohd.ma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200305115759.3186-1-afzal.mohd.ma@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Thu, Mar 05, 2020 at 05:27:53PM +0530, afzal mohammed wrote: > request_irq() is preferred over setup_irq(). Invocations of setup_irq() > occur after memory allocators are ready. > > Per tglx[1], setup_irq() existed in olden days when allocators were not > ready by the time early interrupts were initialized. > > Hence replace setup_irq() by request_irq(). > > remove_irq() has been replaced by free_irq() as well. > > There were build error's during previous version, couple of which was > reported by kbuild test robot of which one was reported > by Thomas Bogendoerfer as well. There were a > few more issues including build errors, those also have been fixed. > > [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos > > Signed-off-by: afzal mohammed thank you, applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 689AEC10F00 for ; Fri, 6 Mar 2020 12:48:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F4DC2166E for ; Fri, 6 Mar 2020 12:48:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TwWb7lzH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F4DC2166E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tuoktvUbn7wURNgIx0ysq1tjEw0JK+TIiz4z+ZH6ZMQ=; b=TwWb7lzHkpEtlN bUn8aXc9eW1VHjShY3lUnYliWTr0BFUTCRN6Zgmv4BIiD8JKWvm3U8Trwal4GLBIQP0IdRQI3HWw9 64zldbNTwxGUdWUVdAY2JxbaUHpaQbm4cIZJzvlpm7e7BRxTMprozaT3NjHaU0u7CV6k3N5wFVJa2 NHgk000Kfv3dEwrw50P87Ql8i9HeIoYjTPGG7vJzju9osl+s8E+ftOY7pcoE3ReBR1lcjimcKBac+ EcEg7aL5HANCCyYJoNO6bQktoRZAQNWSo/Llhls8xhs3L4YqFLmmhLJkvVz54yOAZ+1myauYoyT3T thlB+RXS+Xi7leaz0Xgw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jACOw-0000am-As; Fri, 06 Mar 2020 12:48:26 +0000 Received: from elvis.franken.de ([193.175.24.41]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jACOq-0000Yi-L4 for linux-arm-kernel@lists.infradead.org; Fri, 06 Mar 2020 12:48:22 +0000 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jACOl-0004Q9-00; Fri, 06 Mar 2020 13:48:15 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id A1D50C0F47; Fri, 6 Mar 2020 13:47:55 +0100 (CET) Date: Fri, 6 Mar 2020 13:47:55 +0100 From: Thomas Bogendoerfer To: afzal mohammed Subject: Re: [PATCH v4] MIPS: Replace setup_irq() by request_irq() Message-ID: <20200306124755.GA10251@alpha.franken.de> References: <20200304203144.GA4323@alpha.franken.de> <20200305115759.3186-1-afzal.mohd.ma@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200305115759.3186-1-afzal.mohd.ma@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200306_044820_844831_9076421F X-CRM114-Status: GOOD ( 10.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , Paul Burton , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Jiaxun Yang , "Maciej W. Rozycki" , John Crispin , Huacai Chen , Keguang Zhang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 05, 2020 at 05:27:53PM +0530, afzal mohammed wrote: > request_irq() is preferred over setup_irq(). Invocations of setup_irq() > occur after memory allocators are ready. > > Per tglx[1], setup_irq() existed in olden days when allocators were not > ready by the time early interrupts were initialized. > > Hence replace setup_irq() by request_irq(). > > remove_irq() has been replaced by free_irq() as well. > > There were build error's during previous version, couple of which was > reported by kbuild test robot of which one was reported > by Thomas Bogendoerfer as well. There were a > few more issues including build errors, those also have been fixed. > > [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos > > Signed-off-by: afzal mohammed thank you, applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel