From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3] pty: Test data transmission with SLIP line discipline
Date: Fri, 6 Mar 2020 14:20:11 +0100 [thread overview]
Message-ID: <20200306132011.GA25572@dell5510> (raw)
In-Reply-To: <20200306120021.19997-1-rpalethorpe@suse.com>
Hi Richard,
...
> +static int set_ldisc(int tty, struct ldisc_info *ldisc)
> +{
> + TEST(ioctl(tty, TIOCSETD, &ldisc->n));
> +
> + if (!TST_RET)
> + return 0;
> +
> + if (TST_ERR == EINVAL) {
> + tst_res(TCONF | TTERRNO,
> + "You don't appear to have the %s TTY line discipline",
> + ldisc->name);
> + } else {
> + tst_res(TBROK | TTERRNO,
This must be TFAIL now.
This can be done by person who merges this patch.
BTW as the same function (with corrected TBROK) is
already in pty03.c (although struct ldisc_info is different).
Kind regards,
Petr
next prev parent reply other threads:[~2020-03-06 13:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 12:00 [LTP] [PATCH v3] pty: Test data transmission with SLIP line discipline Richard Palethorpe
2020-03-06 13:20 ` Petr Vorel [this message]
2020-03-06 13:45 ` Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306132011.GA25572@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.