From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 923EDC10DCE for ; Fri, 6 Mar 2020 14:44:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 697FF20848 for ; Fri, 6 Mar 2020 14:44:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Jq3zLI6A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 697FF20848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a42TyG4vbZ/a5TNJBAPCNOSJPbsYte+Ha04fHBRKYm8=; b=Jq3zLI6AZ8FrGw 60t4K+DTAoIrg/Abj7wHvcvbGbWbfyRlOxL2WqnVvFGj4Doe91mGESQfC3jsXB1slPGCWmREggKy4 77KR5FjL1aC7sptvCHeDfw7K94Chu6ntPm/QEgcbOP8k8e4RpyHpidW54E35Gs65E2JInNAMmd5mu 3uXl2tYqvW2gSF9+5ebPEgJbkQoo61yZ+10sId9KoIxuIySn8eyYJLcaoyCRdhvklF8YO5tivsK5h /F0EG/F8/X/adJ47jISr+2Su5dL9gg7n+rN/FRRTceA/c0Bh+CoRjHMoep9VuQSG3B6kszAxbQ9GK REa8fMsjM04AO0lexypg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jAECe-0004Jy-Kb; Fri, 06 Mar 2020 14:43:52 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jAECW-0004C4-DD; Fri, 06 Mar 2020 14:43:45 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5F34831B; Fri, 6 Mar 2020 06:43:43 -0800 (PST) Received: from arm.com (e112269-lin.cambridge.arm.com [10.1.195.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 132703F534; Fri, 6 Mar 2020 06:43:40 -0800 (PST) Date: Fri, 6 Mar 2020 14:43:36 +0000 From: Steven Price To: Rob Herring Subject: Re: [PATCH v4 1/7] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 Message-ID: <20200306144336.GA9234@arm.com> References: <20200207052627.130118-1-drinkcat@chromium.org> <20200207052627.130118-2-drinkcat@chromium.org> <20200225171613.GA7063@bogus> <1583462055.4947.6.camel@mtksdaap41> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200306_064344_494709_0BF2FA44 X-CRM114-Status: GOOD ( 13.82 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Devicetree List , Ulf Hansson , Nicolas Boichat , Tomeu Vizoso , David Airlie , Liam Girdwood , dri-devel , lkml , Sj Huang , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Alyssa Rosenzweig , Daniel Vetter , Hsin-Yi Wang , Matthias Brugger , Nick Fan , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, Mar 06, 2020 at 02:13:08PM +0000, Rob Herring wrote: > On Thu, Mar 5, 2020 at 8:34 PM Nick Fan wrote: > > > > Sorry for my late reply. > > I have checked internally. > > The MT8183_POWER_DOMAIN_MFG_2D is just a legacy name, not really 2D > > domain. > > > > If the naming too confusing, we can change this name to > > MT8183_POWER_DOMAIN_MFG_CORE2 for consistency. > > Can you clarify what's in each domain? Are there actually 3 shader > cores (IIRC, that should be discoverable)? The cover letter from Nicolas includes: > [ 501.321752] panfrost 13040000.gpu: shader_present=0x7 l2_present=0x1 0x7 is three bits set, so it certainly looks like there are 3 shader cores. Of course I wouldn't guarantee that it is as simple as each power domain has a shader core in. The job manager and tiler also need to be powered somehow, so they are either sharing with a shader core or there's something more complex going on. Steve _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E127BC10F25 for ; Fri, 6 Mar 2020 14:43:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B10A420848 for ; Fri, 6 Mar 2020 14:43:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Dd9gOJap" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B10A420848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fU6zVs2jx4Uku4efAOB9/GfDB0CJBqJJRnhykJ7REu0=; b=Dd9gOJap03coDC mk/8h0tWyhi56d8a/4znj2NAdmH/WFFkFZpZQy/dYfPwAFlmlGH5U8jyhJvtONaDzT0N1AXQIiRXR DAeArdh7Kw2u5MfylcZ/STMXnyw7uyZkGRg/U5/LcVAhYNh5WuPcENsShdopSWBRvvQGrMUs8X+I4 IbZtJdK0Xm2/2ZJTftXPT1e/xB9QNFhohZLPYPl3PLhT6kjH1+DwKZPSntDT+riM9uyZeeI+k0/Kd FPJi0Alf9Arno6zSMHYzi/CJqAbj/yu1LZdwR5fWs4si3TJ/90EeyJZUNGE1Kimeo7lI2W6mjJ2CI 6O5QWHwu3mmvghtUXfzw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jAECa-0004D2-2q; Fri, 06 Mar 2020 14:43:48 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jAECW-0004C4-DD; Fri, 06 Mar 2020 14:43:45 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5F34831B; Fri, 6 Mar 2020 06:43:43 -0800 (PST) Received: from arm.com (e112269-lin.cambridge.arm.com [10.1.195.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 132703F534; Fri, 6 Mar 2020 06:43:40 -0800 (PST) Date: Fri, 6 Mar 2020 14:43:36 +0000 From: Steven Price To: Rob Herring Subject: Re: [PATCH v4 1/7] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 Message-ID: <20200306144336.GA9234@arm.com> References: <20200207052627.130118-1-drinkcat@chromium.org> <20200207052627.130118-2-drinkcat@chromium.org> <20200225171613.GA7063@bogus> <1583462055.4947.6.camel@mtksdaap41> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200306_064344_494709_0BF2FA44 X-CRM114-Status: GOOD ( 13.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Devicetree List , Ulf Hansson , Nicolas Boichat , Tomeu Vizoso , David Airlie , Liam Girdwood , dri-devel , lkml , Sj Huang , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Alyssa Rosenzweig , Daniel Vetter , Hsin-Yi Wang , Matthias Brugger , Nick Fan , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 06, 2020 at 02:13:08PM +0000, Rob Herring wrote: > On Thu, Mar 5, 2020 at 8:34 PM Nick Fan wrote: > > > > Sorry for my late reply. > > I have checked internally. > > The MT8183_POWER_DOMAIN_MFG_2D is just a legacy name, not really 2D > > domain. > > > > If the naming too confusing, we can change this name to > > MT8183_POWER_DOMAIN_MFG_CORE2 for consistency. > > Can you clarify what's in each domain? Are there actually 3 shader > cores (IIRC, that should be discoverable)? The cover letter from Nicolas includes: > [ 501.321752] panfrost 13040000.gpu: shader_present=0x7 l2_present=0x1 0x7 is three bits set, so it certainly looks like there are 3 shader cores. Of course I wouldn't guarantee that it is as simple as each power domain has a shader core in. The job manager and tiler also need to be powered somehow, so they are either sharing with a shader core or there's something more complex going on. Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3F0EC10F26 for ; Fri, 6 Mar 2020 14:43:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BEB0D208CD for ; Fri, 6 Mar 2020 14:43:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727578AbgCFOnq (ORCPT ); Fri, 6 Mar 2020 09:43:46 -0500 Received: from foss.arm.com ([217.140.110.172]:34844 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727059AbgCFOno (ORCPT ); Fri, 6 Mar 2020 09:43:44 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5F34831B; Fri, 6 Mar 2020 06:43:43 -0800 (PST) Received: from arm.com (e112269-lin.cambridge.arm.com [10.1.195.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 132703F534; Fri, 6 Mar 2020 06:43:40 -0800 (PST) Date: Fri, 6 Mar 2020 14:43:36 +0000 From: Steven Price To: Rob Herring Cc: Nick Fan , Nicolas Boichat , Sj Huang , David Airlie , Daniel Vetter , Mark Rutland , Matthias Brugger , Tomeu Vizoso , Alyssa Rosenzweig , Liam Girdwood , Mark Brown , dri-devel , Devicetree List , lkml , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Hsin-Yi Wang , Ulf Hansson Subject: Re: [PATCH v4 1/7] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 Message-ID: <20200306144336.GA9234@arm.com> References: <20200207052627.130118-1-drinkcat@chromium.org> <20200207052627.130118-2-drinkcat@chromium.org> <20200225171613.GA7063@bogus> <1583462055.4947.6.camel@mtksdaap41> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Mar 06, 2020 at 02:13:08PM +0000, Rob Herring wrote: > On Thu, Mar 5, 2020 at 8:34 PM Nick Fan wrote: > > > > Sorry for my late reply. > > I have checked internally. > > The MT8183_POWER_DOMAIN_MFG_2D is just a legacy name, not really 2D > > domain. > > > > If the naming too confusing, we can change this name to > > MT8183_POWER_DOMAIN_MFG_CORE2 for consistency. > > Can you clarify what's in each domain? Are there actually 3 shader > cores (IIRC, that should be discoverable)? The cover letter from Nicolas includes: > [ 501.321752] panfrost 13040000.gpu: shader_present=0x7 l2_present=0x1 0x7 is three bits set, so it certainly looks like there are 3 shader cores. Of course I wouldn't guarantee that it is as simple as each power domain has a shader core in. The job manager and tiler also need to be powered somehow, so they are either sharing with a shader core or there's something more complex going on. Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50612C10DCE for ; Fri, 6 Mar 2020 14:43:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C1E1208CD for ; Fri, 6 Mar 2020 14:43:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C1E1208CD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BB1216E46F; Fri, 6 Mar 2020 14:43:45 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 0BAAE6E46F for ; Fri, 6 Mar 2020 14:43:43 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5F34831B; Fri, 6 Mar 2020 06:43:43 -0800 (PST) Received: from arm.com (e112269-lin.cambridge.arm.com [10.1.195.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 132703F534; Fri, 6 Mar 2020 06:43:40 -0800 (PST) Date: Fri, 6 Mar 2020 14:43:36 +0000 From: Steven Price To: Rob Herring Subject: Re: [PATCH v4 1/7] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 Message-ID: <20200306144336.GA9234@arm.com> References: <20200207052627.130118-1-drinkcat@chromium.org> <20200207052627.130118-2-drinkcat@chromium.org> <20200225171613.GA7063@bogus> <1583462055.4947.6.camel@mtksdaap41> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Devicetree List , Ulf Hansson , Nicolas Boichat , Tomeu Vizoso , David Airlie , Liam Girdwood , dri-devel , lkml , Sj Huang , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Alyssa Rosenzweig , Hsin-Yi Wang , Matthias Brugger , Nick Fan , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Mar 06, 2020 at 02:13:08PM +0000, Rob Herring wrote: > On Thu, Mar 5, 2020 at 8:34 PM Nick Fan wrote: > > > > Sorry for my late reply. > > I have checked internally. > > The MT8183_POWER_DOMAIN_MFG_2D is just a legacy name, not really 2D > > domain. > > > > If the naming too confusing, we can change this name to > > MT8183_POWER_DOMAIN_MFG_CORE2 for consistency. > > Can you clarify what's in each domain? Are there actually 3 shader > cores (IIRC, that should be discoverable)? The cover letter from Nicolas includes: > [ 501.321752] panfrost 13040000.gpu: shader_present=0x7 l2_present=0x1 0x7 is three bits set, so it certainly looks like there are 3 shader cores. Of course I wouldn't guarantee that it is as simple as each power domain has a shader core in. The job manager and tiler also need to be powered somehow, so they are either sharing with a shader core or there's something more complex going on. Steve _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel