All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org,
	linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Carsten Emde <C.Emde@osadl.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	John Kacur <jkacur@redhat.com>, Julia Cartwright <julia@ni.com>,
	Daniel Wagner <wagi@monom.org>, Tom Zanussi <zanussi@kernel.org>,
	"Srivatsa S. Bhat" <srivatsa@csail.mit.edu>,
	Matt Fleming <matt@codeblueprint.co.uk>
Subject: [PATCH RT 4/8] mm/memcontrol: Move misplaced local_unlock_irqrestore()
Date: Fri, 06 Mar 2020 13:40:39 -0500	[thread overview]
Message-ID: <20200306184052.332769343@goodmis.org> (raw)
In-Reply-To: 20200306184035.948924528@goodmis.org

4.19.106-rt45-rc1 stable review patch.
If anyone has any objections, please let me know.

------------------

From: Matt Fleming <matt@codeblueprint.co.uk>

[ Upstream commit 071a1d6a6e14d0dec240a8c67b425140d7f92f6a ]

The comment about local_lock_irqsave() mentions just the counters and
css_put_many()'s callback just invokes a worker so it is safe to move the
unlock function after memcg_check_events() so css_put_many() can be invoked
without the lock acquired.

Cc: Daniel Wagner <wagi@monom.org>
Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
[bigeasy: rewrote the patch description]
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 mm/memcontrol.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 421ac74450f6..519528959eef 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -6540,10 +6540,10 @@ void mem_cgroup_swapout(struct page *page, swp_entry_t entry)
 	mem_cgroup_charge_statistics(memcg, page, PageTransHuge(page),
 				     -nr_entries);
 	memcg_check_events(memcg, page);
+	local_unlock_irqrestore(event_lock, flags);
 
 	if (!mem_cgroup_is_root(memcg))
 		css_put_many(&memcg->css, nr_entries);
-	local_unlock_irqrestore(event_lock, flags);
 }
 
 /**
-- 
2.25.0



  parent reply	other threads:[~2020-03-06 18:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-06 18:40 [PATCH RT 0/8] Linux 4.19.106-rt45-rc1 Steven Rostedt
2020-03-06 18:40 ` [PATCH RT 1/8] userfaultfd: Use a seqlock instead of seqcount Steven Rostedt
2020-03-06 18:40 ` [PATCH RT 2/8] sched: migrate_enable: Use per-cpu cpu_stop_work Steven Rostedt
2020-03-06 18:40 ` [PATCH RT 3/8] sched: migrate_enable: Remove __schedule() call Steven Rostedt
2020-03-06 18:40 ` Steven Rostedt [this message]
2020-03-06 18:40 ` [PATCH RT 5/8] locallock: Include header for the `current macro Steven Rostedt
2020-03-06 18:40 ` [PATCH RT 6/8] drm/vmwgfx: Drop preempt_disable() in vmw_fifo_ping_host() Steven Rostedt
2020-03-06 18:40 ` [PATCH RT 7/8] tracing: make preempt_lazy and migrate_disable counter smaller Steven Rostedt
2020-03-06 18:40 ` [PATCH RT 8/8] Linux 4.19.106-rt45-rc1 Steven Rostedt
  -- strict thread matches above, loose matches on Subject: below --
2020-03-09 19:47 [PATCH RT 0/8] Linux v4.14.172-rt78-rc1 zanussi
2020-03-09 19:47 ` [PATCH RT 4/8] mm/memcontrol: Move misplaced local_unlock_irqrestore() zanussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200306184052.332769343@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=C.Emde@osadl.org \
    --cc=bigeasy@linutronix.de \
    --cc=jkacur@redhat.com \
    --cc=julia@ni.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=srivatsa@csail.mit.edu \
    --cc=tglx@linutronix.de \
    --cc=wagi@monom.org \
    --cc=zanussi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.