From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Tomasz Figa <tfiga@chromium.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sakari Ailus <sakari.ailus@iki.fi>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Pawel Osciak <posciak@chromium.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv4 10/11] videobuf2: add begin/end cpu_access callbacks to dma-sg
Date: Sat, 7 Mar 2020 14:26:28 +0900 [thread overview]
Message-ID: <20200307052628.GB176460@google.com> (raw)
In-Reply-To: <f99cd8d2-26a2-acd1-a986-aee66cd2ba12@xs4all.nl>
On (20/03/06 15:04), Hans Verkuil wrote:
[..]
> > + /*
> > + * NOTE: dma-sg allocates memory using the page allocator directly, so
> > + * there is no memory consistency guarantee, hence dma-sg ignores DMA
> > + * attributes passed from the upper layer. That means that
> > + * V4L2_FLAG_MEMORY_NON_CONSISTENT has no effect on dma-sg buffers.
> > + */
> > buf->pages = kvmalloc_array(buf->num_pages, sizeof(struct page *),
> > GFP_KERNEL | __GFP_ZERO);
> > if (!buf->pages)
> > @@ -470,6 +476,26 @@ static void vb2_dma_sg_dmabuf_ops_release(struct dma_buf *dbuf)
> > vb2_dma_sg_put(dbuf->priv);
> > }
> >
> > +static int vb2_dma_sg_dmabuf_ops_begin_cpu_access(struct dma_buf *dbuf,
> > + enum dma_data_direction direction)
>
> I suggest you use this style to avoid checkpatch warnings:
>
> static int
> vb2_dma_sg_dmabuf_ops_begin_cpu_access(struct dma_buf *dbuf,
> enum dma_data_direction direction)
OK, will do.
Just for information, my checkpatch doesn't warn me:
$ ./scripts/checkpatch.pl outgoing/0010-videobuf2-add-begin-end-cpu_access-callbacks-to-dma-.patch
total: 0 errors, 0 warnings, 46 lines checked
outgoing/0010-videobuf2-add-begin-end-cpu_access-callbacks-to-dma-.patch has no obvious style problems and is ready for submission.
-ss
next prev parent reply other threads:[~2020-03-07 5:26 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 4:12 [PATCHv4 00/11] Implement V4L2_BUF_FLAG_NO_CACHE_* flags Sergey Senozhatsky
2020-03-02 4:12 ` [PATCHv4 01/11] videobuf2: add cache management members Sergey Senozhatsky
2020-03-06 13:57 ` Hans Verkuil
2020-03-07 5:22 ` Sergey Senozhatsky
2020-03-07 9:46 ` Sergey Senozhatsky
2020-03-07 10:10 ` Hans Verkuil
2020-03-07 11:28 ` Sergey Senozhatsky
2020-03-07 11:47 ` Hans Verkuil
2020-03-09 3:27 ` Sergey Senozhatsky
2020-03-09 3:44 ` Sergey Senozhatsky
2020-03-09 7:21 ` Hans Verkuil
2020-03-09 7:25 ` Sergey Senozhatsky
2020-03-09 7:28 ` Hans Verkuil
2020-03-09 7:39 ` Sergey Senozhatsky
2020-03-09 8:58 ` Tomasz Figa
2020-03-09 9:08 ` Sergey Senozhatsky
2020-03-09 9:17 ` Tomasz Figa
2020-03-09 9:29 ` Sergey Senozhatsky
2020-03-09 4:03 ` Sergey Senozhatsky
2020-03-09 7:17 ` Hans Verkuil
2020-03-02 4:12 ` [PATCHv4 02/11] videobuf2: handle V4L2 buffer cache flags Sergey Senozhatsky
2020-03-02 4:12 ` [PATCHv4 03/11] videobuf2: add V4L2_FLAG_MEMORY_NON_CONSISTENT flag Sergey Senozhatsky
2020-03-06 13:58 ` Hans Verkuil
2020-03-07 8:09 ` Sergey Senozhatsky
2020-03-02 4:12 ` [PATCHv4 04/11] videobuf2: add queue memory consistency parameter Sergey Senozhatsky
2020-03-06 14:04 ` Hans Verkuil
2020-03-07 7:50 ` Sergey Senozhatsky
2020-03-07 10:03 ` Hans Verkuil
2020-03-20 13:46 ` Dafna Hirschfeld
2020-03-24 2:39 ` Sergey Senozhatsky
2020-03-24 10:17 ` Ezequiel Garcia
2020-03-25 2:32 ` Sergey Senozhatsky
2020-03-27 11:27 ` Tomasz Figa
2020-03-02 4:12 ` [PATCHv4 05/11] videobuf2: handle V4L2_FLAG_MEMORY_NON_CONSISTENT flag Sergey Senozhatsky
2020-03-06 15:30 ` Hans Verkuil
2020-03-07 7:51 ` Sergey Senozhatsky
2020-03-07 9:38 ` Sergey Senozhatsky
2020-03-07 10:05 ` Hans Verkuil
2020-03-02 4:12 ` [PATCHv4 06/11] videobuf2: factor out planes prepare/finish functions Sergey Senozhatsky
2020-03-02 4:12 ` [PATCHv4 07/11] videobuf2: do not sync caches when we are allowed not to Sergey Senozhatsky
2020-03-02 4:12 ` [PATCHv4 08/11] videobuf2: check ->synced flag in prepare() and finish() Sergey Senozhatsky
2020-03-02 4:12 ` [PATCHv4 09/11] videobuf2: add begin/end cpu_access callbacks to dma-contig Sergey Senozhatsky
2020-03-02 4:12 ` [PATCHv4 10/11] videobuf2: add begin/end cpu_access callbacks to dma-sg Sergey Senozhatsky
2020-03-06 14:04 ` Hans Verkuil
2020-03-07 5:26 ` Sergey Senozhatsky [this message]
2020-03-07 9:32 ` Hans Verkuil
2020-03-07 9:39 ` Sergey Senozhatsky
2020-03-02 4:12 ` [PATCHv4 11/11] videobuf2: don't test db_attach in dma-contig prepare and finish Sergey Senozhatsky
2020-03-06 14:18 ` [PATCHv4 00/11] Implement V4L2_BUF_FLAG_NO_CACHE_* flags Hans Verkuil
2020-03-07 8:08 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200307052628.GB176460@google.com \
--to=senozhatsky@chromium.org \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@kernel.org \
--cc=posciak@chromium.org \
--cc=sakari.ailus@iki.fi \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.